You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amruth Sampath <am...@gmail.com> on 2015/08/30 21:25:04 UTC
Review Request 37934: LENS-742 Saved query and parameterization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
lens-api/src/main/resources/lens-errors.conf 3fb191e
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/QueryValidatorResponse.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ResourceNotFoundException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterParserTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterResolutionTest.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service testing.
Thanks,
Amruth Sampath
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/lens-errors.conf, line 58
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064148#file1064148line58>
> >
> > Should user name also go in error message?
> >
> > Will "%s access" say admin/read/write access ?
> >
> > What is %s:%s ? Should that be single param %s ?
The format is
User does not have {priv} access to {resource_type}:{resource_identifier}
priv -> create/read/write/delete
resource_type -> saved_query/schedule etc
resource_identifier -> id of the resource.
I thought user name wont be needed as the exception is anyways returned to the concerned users.
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java, line 31
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>
> >
> > Same as above - If this requires interaction with user/client, it should be lens-api package.
The ParameterDataType and ParameterCollectionType throws some exceptions which are extending from LensException (so that error code mapping is done automatically).
Moving this to lens-api would mean LensException is not vissible anymore. Should I rather create wrapper around these exceptions @ lens-server-api?
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java, line 264
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064170#file1064170line264>
> >
> > what is this Result handler for? Can you add comments?
Sure. This was for getting the last inserted id from the saved queries table (Needed when an creates a saved query. ID has to be sent back as a response).
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/resources/lens-site.xml, lines 141-152
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064177#file1064177line141>
> >
> > Need to be removed?
yes.. Will remove it:)
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java, line 53
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064171#file1064171line53>
> >
> > should we have this under queryapi/ itself?
> >
> > I'm thinking 'yes'. What do you think?
> >
> > Making this path /queryapi will cause any issue with other query resource? I'm hoping it should not, not sure though.
Yes it will work. We just have to ensure that there are no ambiguity in the paths. I have tested it now.
I also think it makes more sense under queryapi/. Ill make the changes.
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
-----------------------------------------------------------
On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 5:25 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java, line 31
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>
> >
> > Same as above - If this requires interaction with user/client, it should be lens-api package.
>
> Amruth Sampath wrote:
> The ParameterDataType and ParameterCollectionType throws some exceptions which are extending from LensException (so that error code mapping is done automatically).
>
> Moving this to lens-api would mean LensException is not vissible anymore. Should I rather create wrapper around these exceptions @ lens-server-api?
>
> Amareshwari Sriramadasu wrote:
> Exceptions cannot be thrown from REST api request/response elements. If you want to pass payload to clients, have a look at FieldsCannotBeQueriedTogetherException to see how payload can be passed. If no sending payload is required, leaving the exceptions in server-api and server side classes throwing exception is good enough - clients would get appropriate error with error code mapped correctly.
>
> Amruth Sampath wrote:
> Sure. My problem is the classes like ParameterDataType and ParameterCollectionType was itself throwing exceptions that were extending LensException. Would it be better if I not extend from LensException for these and wrap it up in lens-server?
Sure. Go ahead and put up the changes, will review them again.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
-----------------------------------------------------------
On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 5:25 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java, line 31
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>
> >
> > Same as above - If this requires interaction with user/client, it should be lens-api package.
>
> Amruth Sampath wrote:
> The ParameterDataType and ParameterCollectionType throws some exceptions which are extending from LensException (so that error code mapping is done automatically).
>
> Moving this to lens-api would mean LensException is not vissible anymore. Should I rather create wrapper around these exceptions @ lens-server-api?
Exceptions cannot be thrown from REST api request/response elements. If you want to pass payload to clients, have a look at FieldsCannotBeQueriedTogetherException to see how payload can be passed. If no sending payload is required, leaving the exceptions in server-api and server side classes throwing exception is good enough - clients would get appropriate error with error code mapped correctly.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
-----------------------------------------------------------
On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 5:25 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java, line 31
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>
> >
> > Same as above - If this requires interaction with user/client, it should be lens-api package.
>
> Amruth Sampath wrote:
> The ParameterDataType and ParameterCollectionType throws some exceptions which are extending from LensException (so that error code mapping is done automatically).
>
> Moving this to lens-api would mean LensException is not vissible anymore. Should I rather create wrapper around these exceptions @ lens-server-api?
>
> Amareshwari Sriramadasu wrote:
> Exceptions cannot be thrown from REST api request/response elements. If you want to pass payload to clients, have a look at FieldsCannotBeQueriedTogetherException to see how payload can be passed. If no sending payload is required, leaving the exceptions in server-api and server side classes throwing exception is good enough - clients would get appropriate error with error code mapped correctly.
Sure. My problem is the classes like ParameterDataType and ParameterCollectionType was itself throwing exceptions that were extending LensException. Would it be better if I not extend from LensException for these and wrap it up in lens-server?
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
-----------------------------------------------------------
On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 5:25 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
-----------------------------------------------------------
lens-api/src/main/resources/lens-errors.conf (line 58)
<https://reviews.apache.org/r/37934/#comment153977>
Should user name also go in error message?
Will "%s access" say admin/read/write access ?
What is %s:%s ? Should that be single param %s ?
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java (line 37)
<https://reviews.apache.org/r/37934/#comment153978>
If this requires interaction with user/client, it should be lens-api package.
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java (line 38)
<https://reviews.apache.org/r/37934/#comment153979>
Please add javadoc to the class and each variable (sothat lombak doc gets generated), explaining details about the class.
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java (line 31)
<https://reviews.apache.org/r/37934/#comment153980>
Same as above - If this requires interaction with user/client, it should be lens-api package.
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java (line 27)
<https://reviews.apache.org/r/37934/#comment153981>
If this requires interaction with user/client, it should be lens-api package.
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java (line 31)
<https://reviews.apache.org/r/37934/#comment153982>
If this requires interaction with user/client, it should be lens-api package.
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java (line 40)
<https://reviews.apache.org/r/37934/#comment153983>
If this requires interaction with user/client, it should be lens-api package.
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java (line 29)
<https://reviews.apache.org/r/37934/#comment153984>
Please add javadoc for the methods.
lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java (line 33)
<https://reviews.apache.org/r/37934/#comment153985>
Would move to lens-api package.
lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java (line 30)
<https://reviews.apache.org/r/37934/#comment153986>
Would move to lens-api package
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java (line 232)
<https://reviews.apache.org/r/37934/#comment153987>
I assume this is HSQL? if so, please rename to HSQL instead of HQL.
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java (line 264)
<https://reviews.apache.org/r/37934/#comment153988>
what is this Result handler for? Can you add comments?
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 53)
<https://reviews.apache.org/r/37934/#comment153991>
should we have this under queryapi/ itself?
I'm thinking 'yes'. What do you think?
Making this path /queryapi will cause any issue with other query resource? I'm hoping it should not, not sure though.
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 54)
<https://reviews.apache.org/r/37934/#comment153989>
Please add javadoc for all methods and all params clearly, sothat resource doc gets updated in site docs.
Have suggested changes in api paths. Put them below:
GET on /savedqueries will give list of saved queries
POST on /savedqueries will create a new saved query.
GET on /savedqueries/{id} : Get saved query.
DELETE on /savedqueries/{id} : Delete saved query.
PUT on /savedqueries/{id} : Updated saved query.
POST on /savedqueries/{id} : Will execute the saved query.
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 79)
<https://reviews.apache.org/r/37934/#comment153990>
list cannot be a path name
should be /savedqueries
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 98)
<https://reviews.apache.org/r/37934/#comment153993>
let us make this path to be savedqueries/{id}
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 111)
<https://reviews.apache.org/r/37934/#comment153994>
let us make this path to be savedqueries/{id}
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 127)
<https://reviews.apache.org/r/37934/#comment153995>
There is no path specified here.
It should have been savedqueries
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 147)
<https://reviews.apache.org/r/37934/#comment153996>
let us make this path to be savedqueries/{id}
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 173)
<https://reviews.apache.org/r/37934/#comment153997>
let us make this path to be savedqueries/{id}. POST on id will be executing the query.
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java (line 46)
<https://reviews.apache.org/r/37934/#comment154000>
Please move this to LensConfConstants and add it in lensserver-default.xml.
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java (line 105)
<https://reviews.apache.org/r/37934/#comment154002>
Please go ahead and remove @localhost, if it needs to be removed.
lens-server/src/test/resources/lens-site.xml (lines 141 - 152)
<https://reviews.apache.org/r/37934/#comment154003>
Need to be removed?
- Amareshwari Sriramadasu
On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 5:25 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98589
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Sept. 11, 2015, 10:10 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 10:10 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
(Updated Sept. 11, 2015, 10:10 a.m.)
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
Changes
-------
Adding syntax error back to lens-errors.conf
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
lens-api/src/main/resources/lens-errors.conf 5428041
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
lens-server/enunciate.xml 94b5199
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
src/site/apt/admin/config.apt b163a3a
src/site/apt/user/index.apt 6a86b1b
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service testing.
Thanks,
Amruth Sampath
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
(Updated Sept. 11, 2015, 8:01 a.m.)
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
Changes
-------
Have made the changes pointed out
- Removed default start (and made this static, so that it can be used with @DefaultValue)
- Default value for count is made as 20 in lensserver-default.xml
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
lens-api/src/main/resources/lens-errors.conf 5428041
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
lens-server/enunciate.xml 94b5199
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
src/site/apt/admin/config.apt b163a3a
src/site/apt/user/index.apt 6a86b1b
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service testing.
Thanks,
Amruth Sampath
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 11, 2015, 7:03 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java, lines 73-74
> > <https://reviews.apache.org/r/37934/diff/6-7/?file=1066468#file1066468line73>
> >
> > Can't these be made static so that they can be used in `@DefaultValue`?
Only static final inline declarations can be used in @DefaultValue. I can initialize this only in the constructor. Nevertheless I have made defaultStart as static final and have used it with @DefaultValue
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98567
-----------------------------------------------------------
On Sept. 10, 2015, 6:50 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 6:50 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98567
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java (lines 74 - 79)
<https://reviews.apache.org/r/37934/#comment155075>
+1
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 948)
<https://reviews.apache.org/r/37934/#comment155080>
`lens.server.savedquery.list.default.start` would probably never be used in any installation.
`lens.server.savedquery.list.default.count`, on the other hand, might be pre-decided by an installation and can be different for different installations.
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java (lines 73 - 74)
<https://reviews.apache.org/r/37934/#comment155081>
Can't these be made static so that they can be used in `@DefaultValue`?
lens-server/src/main/resources/lensserver-default.xml (line 781)
<https://reviews.apache.org/r/37934/#comment155082>
inconsistent value. Make this 20 also.
- Rajat Khandelwal
On Sept. 11, 2015, 12:20 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 12:20 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
(Updated Sept. 10, 2015, 6:50 p.m.)
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
Changes
-------
- Configurable page size and offset
- Validations handled better (through JAXB callback)
- Error code refactoring (same names as in the standard)
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
lens-api/src/main/resources/lens-errors.conf 5428041
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
lens-server/enunciate.xml 94b5199
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
src/site/apt/admin/config.apt b163a3a
src/site/apt/user/index.apt 6a86b1b
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service testing.
Thanks,
Amruth Sampath
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 10, 2015, 11:02 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java, line 34
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066460#file1066460line34>
> >
> > Should this also be merged with `ParameterDataType`
The same issue here as well. Parameter model requires ParameterDataType. So these are going inside lens-api which cant through LensException (not available in lens-api). If I merge the behaviour into ParameterDataType, it might have to through some exception (which has to be mapped with proper error codes through LensException).
I can do two things here
- The current way of having an adapter for ParameterDataType and ParameterCollectionType.
- Have the exceptions not extend LensException at lens-api level and wrap it up at the server level with lens exception with appropriate error codes
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98369
-----------------------------------------------------------
On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 7:23 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 10, 2015, 11:02 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java, line 74
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066468#file1066468line74>
> >
> > Make default pagination configurable.
I was using @DefaultValue annotation to inject default values in service calls
@DefaultValue(defaultStart) @QueryParam("start") int start,
If I make this configurable, I need to remove this annotation and do the check inside the function (@DefaultValue takes only final static inline declared values)
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98369
-----------------------------------------------------------
On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 7:23 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 10, 2015, 11:02 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java, line 74
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066468#file1066468line74>
> >
> > Make default pagination configurable.
>
> Amruth Sampath wrote:
> I was using @DefaultValue annotation to inject default values in service calls
>
> @DefaultValue(defaultStart) @QueryParam("start") int start,
>
> If I make this configurable, I need to remove this annotation and do the check inside the function (@DefaultValue takes only final static inline declared values)
have made this configurable
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98369
-----------------------------------------------------------
On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 7:23 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98369
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java (line 34)
<https://reviews.apache.org/r/37934/#comment154825>
Should this also be merged with `ParameterDataType`
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java (line 74)
<https://reviews.apache.org/r/37934/#comment154861>
Make default pagination configurable.
- Rajat Khandelwal
On Sept. 10, 2015, 12:53 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 12:53 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Sept. 10, 2015, 1:19 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/lens-errors.conf, lines 105-108
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066449#file1066449line105>
> >
> > Why do we need to remove it?
>
> Amruth Sampath wrote:
> There is an INVALID_XML_ERROR in LensCommonErrorCode which is best suited to this.
syntax error was supposed to be for syntax errors in queries. But now invalid queries are not accepted so I guess removing should be fine.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
-----------------------------------------------------------
On Sept. 10, 2015, 12:53 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 12:53 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth S <am...@gmail.com>.
Hi Amereshwari, Syntax error was never in Lenscommonerrorcode. It was
always in Lenscubeerrorcode.
Initially I added it in Lenscommonerrorcode for saved queries also for some
validation purposes but later removed it. Syntaxerror is still present in
Lenscubeerrorcode.
(sent from mobile, excuse typos!)
Thanks,
On Sep 11, 2015 1:49 PM, "Amareshwari Sriramadasu" <am...@apache.org>
wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
>
> On September 10th, 2015, 7:49 a.m. UTC, *Rajat Khandelwal* wrote:
>
> lens-api/src/main/resources/lens-errors.conf
> <https://reviews.apache.org/r/37934/diff/6/?file=1066449#file1066449line105> (Diff
> revision 6) 78
>
> errorCode = 3001
>
> 79
>
> httpStatusCode = ${BAD_REQUEST}
>
> 80
>
> errorMsg = "Syntax Error: %s"
>
> 81
>
> }
>
> Why do we need to remove it?
>
> On September 10th, 2015, 9:24 a.m. UTC, *Amruth Sampath* wrote:
>
> There is an INVALID_XML_ERROR in LensCommonErrorCode which is best suited to this.
>
> On September 10th, 2015, 10:30 a.m. UTC, *Rajat Khandelwal* wrote:
>
> syntax error was supposed to be for syntax errors in queries. But now invalid queries are not accepted so I guess removing should be fine.
>
> Reopening this comment. SYNTAX_ERROR still comes from queries with invalid syntax and the mapping should not be removed.
>
>
> - Amareshwari
>
> On September 11th, 2015, 8:01 a.m. UTC, Amruth Sampath wrote:
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat
> Khandelwal, and sharad agarwal.
> By Amruth Sampath.
>
> *Updated Sept. 11, 2015, 8:01 a.m.*
> *Repository: * lens
> Description
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
> Testing
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
> Diffs
>
> - lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java
> (754e6e1)
> - lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java
> (PRE-CREATION)
> - lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java
> (PRE-CREATION)
> - lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
> (PRE-CREATION)
> - lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java
> (PRE-CREATION)
> - lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
> (PRE-CREATION)
> - lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
> (PRE-CREATION)
> - lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java
> (PRE-CREATION)
> - lens-api/src/main/resources/lens-errors.conf (5428041)
> - lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
> (fb11f93)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
> (PRE-CREATION)
> - lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
> (PRE-CREATION)
> - lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
> (PRE-CREATION)
> - lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
> (PRE-CREATION)
> - lens-server/enunciate.xml (94b5199)
> - lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
> (PRE-CREATION)
> - lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
> (PRE-CREATION)
> - lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
> (PRE-CREATION)
> - lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
> (PRE-CREATION)
> - lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java
> (5d77eb7)
> - lens-server/src/main/resources/lensserver-default.xml (5d33eda)
> - lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
> (PRE-CREATION)
> - lens-server/src/test/resources/lens-site.xml (4cf94d5)
> - src/site/apt/admin/config.apt (b163a3a)
> - src/site/apt/user/index.apt (6a86b1b)
>
> View Diff <https://reviews.apache.org/r/37934/diff/>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/lens-errors.conf, lines 105-108
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066449#file1066449line105>
> >
> > Why do we need to remove it?
>
> Amruth Sampath wrote:
> There is an INVALID_XML_ERROR in LensCommonErrorCode which is best suited to this.
>
> Rajat Khandelwal wrote:
> syntax error was supposed to be for syntax errors in queries. But now invalid queries are not accepted so I guess removing should be fine.
Reopening this comment. SYNTAX_ERROR still comes from queries with invalid syntax and the mapping should not be removed.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
-----------------------------------------------------------
On Sept. 11, 2015, 8:01 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 8:01 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/lens-errors.conf, lines 105-108
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066449#file1066449line105>
> >
> > Why do we need to remove it?
>
> Amruth Sampath wrote:
> There is an INVALID_XML_ERROR in LensCommonErrorCode which is best suited to this.
>
> Rajat Khandelwal wrote:
> syntax error was supposed to be for syntax errors in queries. But now invalid queries are not accepted so I guess removing should be fine.
>
> Amareshwari Sriramadasu wrote:
> Reopening this comment. SYNTAX_ERROR still comes from queries with invalid syntax and the mapping should not be removed.
>
> Amareshwari Sriramadasu wrote:
> The one removed here is removal of existing error from cube error codes, itself.
Oh!! Got it. Thanks.. Adding it back.
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
-----------------------------------------------------------
On Sept. 11, 2015, 10:10 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 10:10 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/lens-errors.conf, lines 105-108
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066449#file1066449line105>
> >
> > Why do we need to remove it?
>
> Amruth Sampath wrote:
> There is an INVALID_XML_ERROR in LensCommonErrorCode which is best suited to this.
>
> Rajat Khandelwal wrote:
> syntax error was supposed to be for syntax errors in queries. But now invalid queries are not accepted so I guess removing should be fine.
>
> Amareshwari Sriramadasu wrote:
> Reopening this comment. SYNTAX_ERROR still comes from queries with invalid syntax and the mapping should not be removed.
The one removed here is removal of existing error from cube error codes, itself.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
-----------------------------------------------------------
On Sept. 11, 2015, 8:01 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 8:01 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Sept. 10, 2015, 1:19 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java, line 30
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066442#file1066442line30>
> >
> > This response can be generified to anything that is supposed to return a list.
> >
> > Can we probably make this `ListResponse<T>` and use `ListResponse<SavedQuery>` wherever required in this patch.
>
> Amruth Sampath wrote:
> There is an issue when we try to use generics and marshalling. The default MoxYJsonProvider seem to run into a bug whenever it encounters generics (whenever accept header is JSON).
>
> Existing APIs like run which results a LensAPIResult<T> is also failing when the accept header is JSON.
Unaware of the issue. Let's file a jira with steps to reproduce.
> On Sept. 10, 2015, 1:19 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java, line 42
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066443#file1066443line42>
> >
> > final?
>
> Amruth Sampath wrote:
> I need getters and setters for jaxb to do marshalling and un marshalling (?). If I have to keep the object immutable, I need to have XML entities for each model entity. Can I do these changes ?
understood. It's okay if jaxb requires it.
> On Sept. 10, 2015, 1:19 p.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java, lines 112-113
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line112>
> >
> > Validations should be on constructor level.
>
> Amruth Sampath wrote:
> Again this is possible if I can have user facing entities for every model entity I have and let JAXB do the marsh/unmarsh for user facing entities. I can convert user facing entity to model entity internally. Should I proceed doing these changes?
I don't suppose there's a way to impose restrictions purely thorugh java annotations. If something can be found, that'd be great.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
-----------------------------------------------------------
On Sept. 10, 2015, 12:53 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 12:53 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java, line 42
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066454#file1066454line42>
> >
> > can we pass error info object to super instead of just a message?
As I see LensErrorInfo object has code, weight and name.
ParameterCollectionException and ValueEncodeException are too low level exceptions (like SQLException) where error code might not make sense. I am catching them and throwing a ParameverValueException and then calling super with lens error info object (with mapped error code)
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
-----------------------------------------------------------
On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 7:23 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java, line 88
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line88>
> >
> > Just a thought here: `parameter.getDataType()` is converted to `ParameterDataTypeEncoder` and sample value is asked. perhaps both(data type and encoder) can be merged?
It was like that initially but we would ideally want to keep the user facing entities in lens-api. If we inline some methods into the models, it might have to throw exceptions. And in lens-api, LensException is not available
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/lens-errors.conf, lines 105-108
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066449#file1066449line105>
> >
> > Why do we need to remove it?
There is an INVALID_XML_ERROR in LensCommonErrorCode which is best suited to this.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java, line 30
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066442#file1066442line30>
> >
> > This response can be generified to anything that is supposed to return a list.
> >
> > Can we probably make this `ListResponse<T>` and use `ListResponse<SavedQuery>` wherever required in this patch.
There is an issue when we try to use generics and marshalling. The default MoxYJsonProvider seem to run into a bug whenever it encounters generics (whenever accept header is JSON).
Existing APIs like run which results a LensAPIResult<T> is also failing when the accept header is JSON.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java, line 50
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066448#file1066448line50>
> >
> > `Parameter` has `name`, `displayName` but not `description`. `SavedQuery` has `name`, `description` but not `displayName`. Should they both have all three?
> >
> > Thinking more on this, `XField` has all three, so maybe they can extend that. But if that happens, we'll be better off renaming `XField` to something that reveals it has 3 compulsary methods.
display name for parameter is needed as the query cannot have pretty parameter names but description for the same would be too much too ask (@parameter level)
In case of saved query, the name itself could be pretty. So display name is not needed here
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java, line 97
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line97>
> >
> > why two values?
This is generating sample value for collection. So two values would make more sense.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java, line 63
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066452#file1066452line63>
> >
> > Instead of `long`, can we re-use `QueryHandle`?
The IDs are generated by the underlying store which I feel is better instead of generating them at server? Your thoughts?
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java, lines 132-134
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line132>
> >
> > Instead of validating outside of `parameter`, creation of `Parameter` Object itself should be valid. As in these checks should be at the constructor level.
If I have to keep the object immutable, I need to have XML entities for each model entity.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java, line 42
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066443#file1066443line42>
> >
> > final?
I need getters and setters for jaxb to do marshalling and un marshalling (?). If I have to keep the object immutable, I need to have XML entities for each model entity. Can I do these changes ?
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java, lines 112-113
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line112>
> >
> > Validations should be on constructor level.
Again this is possible if I can have user facing entities for every model entity I have and let JAXB do the marsh/unmarsh for user facing entities. I can convert user facing entity to model entity internally. Should I proceed doing these changes?
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
-----------------------------------------------------------
On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 7:23 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java, line 118
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line118>
> >
> > Can we reuse `LensJAXBValidationException` here?
Validation happens immediately post un marshalling. removed this code.
> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java, lines 112-113
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line112>
> >
> > Validations should be on constructor level.
>
> Amruth Sampath wrote:
> Again this is possible if I can have user facing entities for every model entity I have and let JAXB do the marsh/unmarsh for user facing entities. I can convert user facing entity to model entity internally. Should I proceed doing these changes?
>
> Rajat Khandelwal wrote:
> I don't suppose there's a way to impose restrictions purely thorugh java annotations. If something can be found, that'd be great.
There is a way to validate as soon as the unmarshalling is done by JAXB. Removing these.
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
-----------------------------------------------------------
On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 7:23 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java (line 30)
<https://reviews.apache.org/r/37934/#comment154786>
This response can be generified to anything that is supposed to return a list.
Can we probably make this `ListResponse<T>` and use `ListResponse<SavedQuery>` wherever required in this patch.
lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java (line 42)
<https://reviews.apache.org/r/37934/#comment154788>
final?
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java (line 42)
<https://reviews.apache.org/r/37934/#comment154789>
change the comment to remove `if valid`
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java (lines 43 - 53)
<https://reviews.apache.org/r/37934/#comment154790>
CAPITAL CASE plase
lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java (line 50)
<https://reviews.apache.org/r/37934/#comment154791>
`Parameter` has `name`, `displayName` but not `description`. `SavedQuery` has `name`, `description` but not `displayName`. Should they both have all three?
Thinking more on this, `XField` has all three, so maybe they can extend that. But if that happens, we'll be better off renaming `XField` to something that reveals it has 3 compulsary methods.
lens-api/src/main/resources/lens-errors.conf (lines 27 - 28)
<https://reviews.apache.org/r/37934/#comment154793>
`javax.ws.rs.core.Response.Status`:
OK(200, "OK"),
CREATED(201, "Created"),
ACCEPTED(202, "Accepted"),
NO_CONTENT(204, "No Content"),
RESET_CONTENT(205, "Reset Content"),
PARTIAL_CONTENT(206, "Partial Content"),
MOVED_PERMANENTLY(301, "Moved Permanently"),
FOUND(302, "Found"),
SEE_OTHER(303, "See Other"),
NOT_MODIFIED(304, "Not Modified"),
USE_PROXY(305, "Use Proxy"),
TEMPORARY_REDIRECT(307, "Temporary Redirect"),
BAD_REQUEST(400, "Bad Request"),
UNAUTHORIZED(401, "Unauthorized"),
PAYMENT_REQUIRED(402, "Payment Required"),
FORBIDDEN(403, "Forbidden"),
NOT_FOUND(404, "Not Found"),
METHOD_NOT_ALLOWED(405, "Method Not Allowed"),
NOT_ACCEPTABLE(406, "Not Acceptable"),
PROXY_AUTHENTICATION_REQUIRED(407, "Proxy Authentication Required"),
REQUEST_TIMEOUT(408, "Request Timeout"),
CONFLICT(409, "Conflict"),
GONE(410, "Gone"),
LENGTH_REQUIRED(411, "Length Required"),
PRECONDITION_FAILED(412, "Precondition Failed"),
REQUEST_ENTITY_TOO_LARGE(413, "Request Entity Too Large"),
REQUEST_URI_TOO_LONG(414, "Request-URI Too Long"),
UNSUPPORTED_MEDIA_TYPE(415, "Unsupported Media Type"),
REQUESTED_RANGE_NOT_SATISFIABLE(416, "Requested Range Not Satisfiable"),
EXPECTATION_FAILED(417, "Expectation Failed"),
INTERNAL_SERVER_ERROR(500, "Internal Server Error"),
NOT_IMPLEMENTED(501, "Not Implemented"),
BAD_GATEWAY(502, "Bad Gateway"),
SERVICE_UNAVAILABLE(503, "Service Unavailable"),
GATEWAY_TIMEOUT(504, "Gateway Timeout"),
HTTP_VERSION_NOT_SUPPORTED(505, "HTTP Version Not Supported");
Let's keep the names consistent, and try to re-use from there if possible?
lens-api/src/main/resources/lens-errors.conf
<https://reviews.apache.org/r/37934/#comment154796>
Why do we need to remove it?
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java (line 88)
<https://reviews.apache.org/r/37934/#comment154798>
Just a thought here: `parameter.getDataType()` is converted to `ParameterDataTypeEncoder` and sample value is asked. perhaps both(data type and encoder) can be merged?
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java (line 97)
<https://reviews.apache.org/r/37934/#comment154801>
why two values?
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java (lines 112 - 113)
<https://reviews.apache.org/r/37934/#comment154818>
Validations should be on constructor level.
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java (line 118)
<https://reviews.apache.org/r/37934/#comment154816>
Can we reuse `LensJAXBValidationException` here?
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java (lines 132 - 134)
<https://reviews.apache.org/r/37934/#comment154817>
Instead of validating outside of `parameter`, creation of `Parameter` Object itself should be valid. As in these checks should be at the constructor level.
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java (line 63)
<https://reviews.apache.org/r/37934/#comment154819>
Instead of `long`, can we re-use `QueryHandle`?
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java (line 42)
<https://reviews.apache.org/r/37934/#comment154822>
can we pass error info object to super instead of just a message?
- Rajat Khandelwal
On Sept. 10, 2015, 12:53 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 12:53 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/enunciate.xml 94b5199
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 7:23 p.m.)
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
Changes
-------
- Rebased with master (changes with respect to LensErrorInfo incorporated)
- Updated java docs for all classes and methods
- Updated index.apt for user documentation
- Other minor refactoring pointed out
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
lens-api/src/main/resources/lens-errors.conf 5428041
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fb11f93
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
lens-server/enunciate.xml 94b5199
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
src/site/apt/admin/config.apt b163a3a
src/site/apt/user/index.apt 6a86b1b
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service testing.
Thanks,
Amruth Sampath
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
On Sept. 9, 2015, 10:46 a.m., Amruth Sampath wrote:
> > Overall changes look fine.
> > Can you add one section in user doc explaining the feature ?
Sure. Where is the user doc?
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98163
-----------------------------------------------------------
On Sept. 8, 2015, 6:11 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 6:11 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 720825a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amareshwari Sriramadasu <am...@apache.org>.
On Sept. 9, 2015, 10:46 a.m., Amruth Sampath wrote:
> > Overall changes look fine.
> > Can you add one section in user doc explaining the feature ?
>
> Amruth Sampath wrote:
> Sure. Where is the user doc?
src/site/api/user/index.apt
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98163
-----------------------------------------------------------
On Sept. 8, 2015, 6:11 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 6:11 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 720825a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98163
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java (line 26)
<https://reviews.apache.org/r/37934/#comment154454>
Why is this extending Throwable? and not extedning LensException for giving the error out?
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java (line 89)
<https://reviews.apache.org/r/37934/#comment154455>
Please add javadoc for all methods and explaining params.
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java (line 92)
<https://reviews.apache.org/r/37934/#comment154456>
Have the variable names same as param names, sothat auto generated docs match.
Please verify autugenerated docs for the new resource by running
'mvn enunciate:docs' - all docs are fine.
lens-server/src/main/resources/lensserver-default.xml (line 769)
<https://reviews.apache.org/r/37934/#comment154457>
Update config.apt by running tests in lens-api
lens-server/src/test/resources/lens-site.xml (line 143)
<https://reviews.apache.org/r/37934/#comment154458>
Update description to HSQL
Overall changes look fine.
Can you add one section in user doc explaining the feature ?
- Amareshwari Sriramadasu
On Sept. 8, 2015, 6:11 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 6:11 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 720825a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
(Updated Sept. 8, 2015, 6:11 p.m.)
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
Changes
-------
- Improved list api to show totalRecords for the specified criteria
- Other minior changes pointed out (removed requiredargsconstructor, removed count from ListResponse)
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
lens-api/src/main/resources/lens-errors.conf 3fb191e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 720825a
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service testing.
Thanks,
Amruth Sampath
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 8, 2015, 4:23 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java, line 43
> > <https://reviews.apache.org/r/37934/diff/4/?file=1064882#file1064882line43>
> >
> > Do we need to store this or `resources.size()` should be enough"
Changed this to totalCount that shows the total number of records found for the specified criteria
> On Sept. 8, 2015, 4:23 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java, lines 39-44
> > <https://reviews.apache.org/r/37934/diff/4/?file=1064886#file1064886line39>
> >
> > Is `valid == isNotBlank(message)`. In that case, `valid` is redundant.
I think having the valid flag would give the UI apps a cleaner way of deciding an invalid scenerio. Later on probably the API might add messages on valid cases also.
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97986
-----------------------------------------------------------
On Sept. 7, 2015, 8:49 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 8:49 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 720825a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97986
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java (line 43)
<https://reviews.apache.org/r/37934/#comment154121>
Do we need to store this or `resources.size()` should be enough"
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java (lines 39 - 44)
<https://reviews.apache.org/r/37934/#comment154129>
Is `valid == isNotBlank(message)`. In that case, `valid` is redundant.
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java (line 29)
<https://reviews.apache.org/r/37934/#comment154130>
None of the args are required.
- Rajat Khandelwal
On Sept. 8, 2015, 2:19 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 2:19 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 720825a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
(Updated Sept. 7, 2015, 8:49 p.m.)
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
Changes
-------
1) Moving api classes to lens-api
2) Restructuring rest apis
3) Added javadoc to all API and service classes
4) Other refactorings pointed out in the review
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java PRE-CREATION
lens-api/src/main/resources/lens-errors.conf 3fb191e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 720825a
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service testing.
Thanks,
Amruth Sampath
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 5:25 p.m.)
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
Changes
-------
- Moving "SyntaxError" to LensCommonErrorCode
- Adding validation for saved query api
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
lens-api/src/main/resources/lens-errors.conf 3fb191e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0dfd7da
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 2189eb8
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service testing.
Thanks,
Amruth Sampath
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 11:39 a.m.)
Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
Changes
-------
- Extending lens exception and mapping the error codes
- Removed syntax error code and added more meaningful codes
- Using lensserver db for saving the queries
- Updated utility methods to produce a pooling data source
(All test cases working fine)
Repository: lens
Description
-------
Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
lens-api/src/main/resources/lens-errors.conf 3fb191e
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/QueryValidatorResponse.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterParserTest.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterResolutionTest.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7
lens-server/src/main/resources/lensserver-default.xml 5d33eda
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 4cf94d5
Diff: https://reviews.apache.org/r/37934/diff/
Testing
-------
Have added unit test cases for parsing, resolution of parameter and service testing.
Thanks,
Amruth Sampath
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amruth Sampath <am...@gmail.com>.
> On Sept. 2, 2015, 4:20 a.m., Amareshwari Sriramadasu wrote:
> > - Why are parameterization and saved query are combined into one entity? I think parameterization should be separate and even simple queries can use them.
> > - Do we have any expiry on saved queries?
> > - Can we put up differences between prepared queries and saved queries clearly?
> > - Can we put up differences between set param available on session and parameterization that is getting added in this change?
Why are parameterization and saved query are combined into one entity? I think parameterization should be separate and even simple queries can use them.
SavedQuery is just encapsulating Parameters. These parameters could be used with the normal on the fly queries also. But it would not make sense as an use case because if an user is going to run a parameterized query providing bind values on the fly, he might as well just provide a static query.
Do we have any expiry on saved queries?
Saved queries cannot be expired. They are more like an user generated resource
Can we put up differences between prepared queries and saved queries clearly?
The description in jira explains the complete use case of saved queries. Also I have added a comment that distinguishes saved query from prepared queries. https://issues.apache.org/jira/browse/LENS-742
Can we put up differences between set param available on session and parameterization that is getting added in this change?
This setParam available in session is for setting session level parameters that could be used under any context. The parameterization available here is completely different.
Say we have a query that is saved like this - "select col1 from table where col1 = :param" (param is a bind parameter)
The query would be run with through an API like this - /savedquery/4/run?param="value"
(Essentially the user is running the saved query with id 4 supplying values for whatever parameter he has specified while creating it)
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97395
-----------------------------------------------------------
On Aug. 30, 2015, 7:25 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 7:25 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/QueryValidatorResponse.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ResourceNotFoundException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterParserTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterResolutionTest.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 37934: LENS-742 Saved query and parameterization
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97395
-----------------------------------------------------------
- Why are parameterization and saved query are combined into one entity? I think parameterization should be separate and even simple queries can use them.
- Do we have any expiry on saved queries?
- Can we put up differences between prepared queries and saved queries clearly?
- Can we put up differences between set param available on session and parameterization that is getting added in this change?
lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java (line 35)
<https://reviews.apache.org/r/37934/#comment153284>
We have SYNTAX_ERROR sitting in LensCubeErrorCode, may be that should be moved here, instead of creating a new one.
lens-api/src/main/resources/lens-errors.conf (line 52)
<https://reviews.apache.org/r/37934/#comment153285>
Can we parameterize this passing the resource?
lens-api/src/main/resources/lens-errors.conf (line 64)
<https://reviews.apache.org/r/37934/#comment153286>
we should use Syntax error already defined - which gives details on syntax error as well.
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java (line 27)
<https://reviews.apache.org/r/37934/#comment153287>
Please extend from LensException and associate an Error code and error message in lens-errors.conf
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java (line 28)
<https://reviews.apache.org/r/37934/#comment153288>
Same as above
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java (line 82)
<https://reviews.apache.org/r/37934/#comment153289>
Importing LensException would reduce code.
lens-server/src/main/resources/lensserver-default.xml (line 769)
<https://reviews.apache.org/r/37934/#comment153290>
Does it need to have a separate db url? Using lensserver db itself would be good?
- Amareshwari Sriramadasu
On Aug. 30, 2015, 7:25 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 7:25 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1
> lens-api/src/main/resources/lens-errors.conf 3fb191e
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/QueryValidatorResponse.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ResourceNotFoundException.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterParserTest.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterResolutionTest.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>