[jira] [Commented] (TINKERPOP-2438) Provide a way for scripts to respect with() specification of timeout

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242728#comment-17242728 ] 

ASF GitHub Bot commented on TINKERPOP-2438:
-------------------------------------------

spmallette opened a new pull request #1368:
URL: https://github.com/apache/tinkerpop/pull/1368


   https://issues.apache.org/jira/browse/TINKERPOP-2438
   
   Used CompileStatic annotation and introduced a lightweight check to validate that there was reason to accept the expense of parsing. It's a bit of a hack in a sense but after some analysis it seems that there are no easy fixes. Everything ends in fairly advanced refactoring and extension of GremlinGroovyScriptEngine and GremlinGroovyClassLoader (with possible pull requests to Groovy). That seems like a fair bit of effort for what this feature is and I'm not sure it's worth it. The typical use case for timeout setting should not encounter the performance problem that would ensue from parsing to the Groovy AST.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Provide a way for scripts to respect with() specification of timeout
> --------------------------------------------------------------------
>
>                 Key: TINKERPOP-2438
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2438
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.8
>            Reporter: Stephen Mallette
>            Assignee: Stephen Mallette
>            Priority: Major
>
> This issue sorta relates to the Gremlin Console but I think it's generally a server side problem as it could easily occur with HTTP or just scripts sent over web sockets. Folks tend to see all the ways they can set timeouts and then mix/match them. It only remains a problem with sending a script as {{g.with("evalTimeout",100)}} because the server won't know that this value was set until the script is passed to {{eval()}} but by then it's too late because we would have already started the timeout countdown.  While most users wouldn't send that as a bare script submission it's a common mistake in the Gremlin Console and similar environments where it is not clear you are working with a remote graph. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)