You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2017/07/11 17:21:01 UTC
[jira] [Commented] (AMBARI-21358) Upgrades Must Track To/From
Repository Versions Instead of Strings
[ https://issues.apache.org/jira/browse/AMBARI-21358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082555#comment-16082555 ]
Hudson commented on AMBARI-21358:
---------------------------------
FAILURE: Integrated in Jenkins build Ambari-branch-2.5 #1667 (See [https://builds.apache.org/job/Ambari-branch-2.5/1667/])
AMBARI-21358 - Upgrades Must Track To/From Repository Versions Instead (jhurley: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=7ad307c2c36e6170cd3053e707b313edebbdaa1a])
* (edit) ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
* (edit) ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
* (edit) ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/PreviousUpgradeCompletedTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/services/RetryUpgradeActionService.java
* (edit) ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
* (edit) ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
* (edit) ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
* (edit) ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
* (edit) ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContextFactory.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java
AMBARI-21367 - Fix Unit Test Failures Caused by AMBARI-21358 (jhurley: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=77099797a6326d285245e8af8dd156900804cf31])
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
> Upgrades Must Track To/From Repository Versions Instead of Strings
> ------------------------------------------------------------------
>
> Key: AMBARI-21358
> URL: https://issues.apache.org/jira/browse/AMBARI-21358
> Project: Ambari
> Issue Type: Task
> Affects Versions: 2.5.2
> Reporter: Jonathan Hurley
> Assignee: Jonathan Hurley
> Priority: Blocker
> Fix For: 2.5.2
>
> Attachments: AMBARI-21358.patch
>
>
> When creating an upgrade in Ambari 2.5.x, the request appears as follows:
> {code}
> POST api/v1/clusters/c1/upgrades
> {
> "Upgrade": {
> "repository_version": "2.6.0.0-334",
> "skip_failures": "true",
> "skip_service_check_failures": "true",
> "skip_prerequisite_checks": "true",
> "upgrade_type": "NON_ROLLING",
> "direction": "UPGRADE"
> }
> }
> {code}
> The only identifier for the repository is the repo version. This forces the query to assume that the repository has the same name as the repository currently installed for the cluster. When going between stack vendors, this is incorrect:
> STR:
> - Install BigInsights 4.2.0 or 4.2.5
> - Upgrade to Ambari 2.5.2
> - Register HDP 2.6 and try to upgrade
> The backend will look for {{BigInsights-2.6.0.0-1234}} instead of {{HDP-2.6.0.0-1234}}. A quick workaround is to fallback to a version-only search when the repository is not found.
> The fix for this is to allow the web client to pass the stack name in addition to the version. A repository ID can also be specified instead of the stack name/version.
> Additionally, the {{upgrade}} itself must track the to/from repo versions instead of strings:
> {code}
> CREATE TABLE upgrade (
> upgrade_id BIGINT NOT NULL,
> cluster_id BIGINT NOT NULL,
> request_id BIGINT NOT NULL,
> from_repo_version_id BIGINT NOT NULL,
> to_repo_version_id BIGINT NOT NULL,
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)