You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2011/04/25 20:45:03 UTC
[jira] [Created] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Delegation token cancellation shouldn't hold global JobTracker lock
-------------------------------------------------------------------
Key: MAPREDUCE-2452
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: jobtracker
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.23.0
Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042606#comment-13042606 ]
Devaraj Das commented on MAPREDUCE-2452:
----------------------------------------
The test failed without the patch too. The findbugs warning (to do with System.exit) is expected. Not sure why it is flagging two warnings..
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated MAPREDUCE-2452:
-------------------------------------------
Fix Version/s: (was: 0.23.0)
0.22.1
I just committed this to branch 0.22.1. Thank you Benoy.
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.1
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated MAPREDUCE-2452:
-----------------------------------
Status: Patch Available (was: Open)
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated MAPREDUCE-2452:
-----------------------------------
Status: Open (was: Patch Available)
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated MAPREDUCE-2452:
-----------------------------------
Attachment: cancel-delegation-token-fix.patch
Patch addressing Owen's comments.
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042611#comment-13042611 ]
Owen O'Malley commented on MAPREDUCE-2452:
------------------------------------------
+1
Please add a suppression of the exit findbugs warning to src/test/findbugsExcludeFile.xml.
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated MAPREDUCE-2452:
-----------------------------------
Attachment: cancel-delegation-token-fix.patch
Addresses Owen's comments..
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289430#comment-13289430 ]
Hudson commented on MAPREDUCE-2452:
-----------------------------------
Integrated in Hadoop-Mapreduce-22-branch #104 (See [https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/104/])
MAPREDUCE-2452. Moves the cancellation of delegation tokens to a separate thread. Contributed by Devaraj Das and Benoy Antony. (Revision 1346235)
Result = SUCCESS
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346235
Files :
* /hadoop/common/branches/branch-0.22/mapreduce/CHANGES.txt
* /hadoop/common/branches/branch-0.22/mapreduce/src/java/org/apache/hadoop/mapreduce/security/token/DelegationTokenRenewal.java
* /hadoop/common/branches/branch-0.22/mapreduce/src/test/findbugsExcludeFile.xml
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.1
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057265#comment-13057265 ]
Hudson commented on MAPREDUCE-2452:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #722 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/])
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated MAPREDUCE-2452:
-----------------------------------
Attachment: cancel-delegation-token-fix.patch
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated MAPREDUCE-2452:
-----------------------------------
Attachment: cancel-delegation-token-fix-trunk.patch
Suppresses the findbugs warning.
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042353#comment-13042353 ]
Owen O'Malley commented on MAPREDUCE-2452:
------------------------------------------
Looking good. A few more points:
* Please have the cancelToken catch the InterruptedException and create a new RuntimeException that wraps it.
* Please have the DelegationTokenCancelThread catch InterruptedException and exit gracefully.
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044072#comment-13044072 ]
Devaraj Das commented on MAPREDUCE-2452:
----------------------------------------
Compared the number of findbugs warnings with the number of findbugs warnings for another recent hudson run. They are the same. Not sure why this patch is triggering false findbugs alarms. I intend to commit the patch soon..
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035132#comment-13035132 ]
Owen O'Malley commented on MAPREDUCE-2452:
------------------------------------------
Devaraj,
Can you please have the Thread catch IOExceptions and log them. Throwable should be caught, logged, and call System.exit.
I think you need to retry if the offer returns false rather than just dropping the cancel request.
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044104#comment-13044104 ]
Hudson commented on MAPREDUCE-2452:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #712 (See [https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/712/])
MAPREDUCE-2452. Makes the cancellation of delegation tokens happen in a separate thread. Contributed by Devaraj Das.
ddas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1131265
Files :
* /hadoop/mapreduce/trunk/CHANGES.txt
* /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/security/token/DelegationTokenRenewal.java
* /hadoop/mapreduce/trunk/src/test/findbugsExcludeFile.xml
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Benoy Antony (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280536#comment-13280536 ]
Benoy Antony commented on MAPREDUCE-2452:
-----------------------------------------
I removed my patch for 22. The latest patch for trunk is good for 22
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042550#comment-13042550 ]
Hadoop QA commented on MAPREDUCE-2452:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481158/cancel-delegation-token-fix-trunk.patch
against trunk revision 1130147.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/330//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/330//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/330//console
This message is automatically generated.
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044070#comment-13044070 ]
Hadoop QA commented on MAPREDUCE-2452:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481390/cancel-delegation-token-fix-trunk.patch
against trunk revision 1130994.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/344//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/344//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/344//console
This message is automatically generated.
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Benoy Antony (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoy Antony updated MAPREDUCE-2452:
------------------------------------
Attachment: (was: mr-2452-022.patch)
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated MAPREDUCE-2452:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Benoy Antony (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoy Antony updated MAPREDUCE-2452:
------------------------------------
Attachment: mr-2452-022.patch
Patch for 22
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, mr-2452-022.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated MAPREDUCE-2452:
-----------------------------------
Affects Version/s: 0.22.0
Status: Patch Available (was: Open)
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042438#comment-13042438 ]
Owen O'Malley commented on MAPREDUCE-2452:
------------------------------------------
+1
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035158#comment-13035158 ]
Devaraj Das commented on MAPREDUCE-2452:
----------------------------------------
I should ideally put a small sleep between the retries whenever 'offer' returns false. That would need InterruptedException to be handled. I ideally don't want to swallow the InterruptedException but if I don't it leads to a big cascading change in the method declarations in the call hierarchy of the token cancellation method... I am in two minds on whether to swallow/ignore the interrupted exception or propagate it all the way up and effect a major change in the method signatures...
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2452) Delegation token cancellation
shouldn't hold global JobTracker lock
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated MAPREDUCE-2452:
-----------------------------------
Attachment: cancel-delegation-token-fix-trunk.patch
Patch for trunk
> Delegation token cancellation shouldn't hold global JobTracker lock
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.23.0
>
> Attachments: cancel-delegation-token-fix-trunk.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch, cancel-delegation-token-fix.patch
>
>
> Currently, when the JobTracker cancels a job's delegation token (at the end of the job), it holds the global lock. This is not desired.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira