You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by to...@apache.org on 2019/12/12 20:43:25 UTC
[libcloud] branch trunk updated (0989163 -> d23eeb2)
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git.
from 0989163 Fix formatting.
new 8ad8a68 Fix attach and detach volume for DO. Volume name instead of id is needed
new 4533e3e Merge branch 'attach-disk-digital-ocean' of https://github.com/mistio/libcloud into mistio-attach-disk-digital-ocean
new e583297 Fix lint.
new d23eeb2 Add changelog entry.
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.rst | 11 +++++++++++
libcloud/compute/drivers/digitalocean.py | 5 +++--
2 files changed, 14 insertions(+), 2 deletions(-)
[libcloud] 03/04: Fix lint.
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit e583297c6675bcaa7b2052a38431a8efed36cf7e
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Thu Dec 12 21:38:51 2019 +0100
Fix lint.
---
libcloud/compute/drivers/digitalocean.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libcloud/compute/drivers/digitalocean.py b/libcloud/compute/drivers/digitalocean.py
index 643c9dd..c01572e 100644
--- a/libcloud/compute/drivers/digitalocean.py
+++ b/libcloud/compute/drivers/digitalocean.py
@@ -437,7 +437,8 @@ class DigitalOcean_v2_NodeDriver(DigitalOcean_v2_BaseDriver,
:rytpe: ``bool``
"""
attr = {'type': 'attach', 'droplet_id': node.id,
- 'volume_name': volume.name, 'region': volume.extra['region_slug']}
+ 'volume_name': volume.name,
+ 'region': volume.extra['region_slug']}
res = self.connection.request('/v2/volumes/actions',
data=json.dumps(attr), method='POST')
[libcloud] 02/04: Merge branch 'attach-disk-digital-ocean' of
https://github.com/mistio/libcloud into mistio-attach-disk-digital-ocean
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 4533e3efea2d5d99dea401caf98fde1792c14f91
Merge: 0989163 8ad8a68
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Thu Dec 12 21:38:22 2019 +0100
Merge branch 'attach-disk-digital-ocean' of https://github.com/mistio/libcloud into mistio-attach-disk-digital-ocean
libcloud/compute/drivers/digitalocean.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[libcloud] 01/04: Fix attach and detach volume for DO. Volume name
instead of id is needed
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 8ad8a68d8b5f3ee06edd5ea9132677d39c7aefc3
Author: mpempekos <sp...@mist.io>
AuthorDate: Tue Dec 10 19:17:59 2019 +0000
Fix attach and detach volume for DO. Volume name instead of id is needed
---
libcloud/compute/drivers/digitalocean.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libcloud/compute/drivers/digitalocean.py b/libcloud/compute/drivers/digitalocean.py
index 631f8d9..1ad8c6a 100644
--- a/libcloud/compute/drivers/digitalocean.py
+++ b/libcloud/compute/drivers/digitalocean.py
@@ -424,7 +424,7 @@ class DigitalOcean_v2_NodeDriver(DigitalOcean_v2_BaseDriver,
:rytpe: ``bool``
"""
attr = {'type': 'attach', 'droplet_id': node.id,
- 'volume_id': volume.id, 'region': volume.extra['region_slug']}
+ 'volume_name': volume.name, 'region': volume.extra['region_slug']}
res = self.connection.request('/v2/volumes/actions',
data=json.dumps(attr), method='POST')
@@ -440,7 +440,7 @@ class DigitalOcean_v2_NodeDriver(DigitalOcean_v2_BaseDriver,
:rtype: ``bool``
"""
- attr = {'type': 'detach', 'volume_id': volume.id,
+ attr = {'type': 'detach', 'volume_name': volume.name,
'region': volume.extra['region_slug']}
responses = []
[libcloud] 04/04: Add changelog entry.
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit d23eeb2862d761cc88973c2e73175b6fed87af66
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Thu Dec 12 21:40:38 2019 +0100
Add changelog entry.
---
CHANGES.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/CHANGES.rst b/CHANGES.rst
index b05bd18..e4a24b1 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,6 +1,17 @@
Changelog
=========
+Changes in Apache Libcloud in development
+-----------------------------------------
+
+Compute
+-------
+
+- [DigitalOcean] Fix ``attach_volume`` and ``detach_volume`` methods.
+ Previously those two methods incorrectly passed volume id instead of
+ volume name to the API. (GITHUB-1380)
+ [@mpempekos]
+
Changes in Apache Libcloud v2.7.0
---------------------------------