You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <de...@geronimo.apache.org> on 2005/08/30 01:22:05 UTC

[jira] Created: (GERONIMO-947) Configuration should have multiple parents

Configuration should have multiple parents
------------------------------------------

         Key: GERONIMO-947
         URL: http://issues.apache.org/jira/browse/GERONIMO-947
     Project: Geronimo
        Type: Bug
  Components: kernel  
    Versions: 1.0-M5    
 Reporter: David Jencks
 Assigned to: David Jencks 
     Fix For: 1.0-M5


A configuration should have multiple parents.  This is needed for many reasons including to allow us to split our configurations into more manageable pieces.  Some discussion has produced this plan:

1. change all the builder code to produce an URI[] instead of URI for parentId using a parentId attribute with comma separated list of parents in the plans

2. Find a multi-parent classloader and use it in Configuration.  Dain says he has one and I think Eclipse has one.

3. Change the plan xml to have multiple import elements for the parents

4. split up our plans to take advantage of this feature.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-947) Configuration should have multiple parents

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-947?page=comments#action_12320513 ] 

David Jencks commented on GERONIMO-947:
---------------------------------------

Step 1:

Sending        trunk/applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/handlers/CreateDestinationHandler.java
Sending        trunk/modules/client-builder/src/java/org/apache/geronimo/client/builder/AppClientModuleBuilder.java
Sending        trunk/modules/connector-builder/src/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java
Sending        trunk/modules/connector-builder/src/test/org/apache/geronimo/connector/deployment/ConnectorModuleBuilderTest.java
Sending        trunk/modules/deployment/src/java/org/apache/geronimo/deployment/DeploymentContext.java
Sending        trunk/modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/ApplicationInfo.java
Sending        trunk/modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/AppClientModule.java
Sending        trunk/modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/ConnectorModule.java
Sending        trunk/modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/EARConfigBuilder.java
Sending        trunk/modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/EARContext.java
Sending        trunk/modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/EJBModule.java
Sending        trunk/modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/Module.java
Sending        trunk/modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/WebModule.java
Sending        trunk/modules/j2ee-builder/src/test/org/apache/geronimo/j2ee/deployment/EARConfigBuilderTest.java
Sending        trunk/modules/j2ee-builder/src/test/org/apache/geronimo/j2ee/deployment/MockWARConfigBuilder.java
Sending        trunk/modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java
Sending        trunk/modules/jetty-builder/src/test/org/apache/geronimo/jetty/deployment/JettyModuleBuilderTest.java
Sending        trunk/modules/jetty-builder/src/test/org/apache/geronimo/jetty/deployment/PlanParsingTest.java
Sending        trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/Configuration.java
Sending        trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/ConfigurationData.java
Sending        trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/ConfigurationManagerImpl.java
Sending        trunk/modules/service-builder/src/java/org/apache/geronimo/deployment/service/ServiceConfigBuilder.java
Sending        trunk/modules/service-builder/src/test/org/apache/geronimo/deployment/service/ServiceConfigBuilderTest.java
Sending        trunk/modules/servicemix-builder/src/java/org/apache/geronimo/servicemix/deployment/ServiceMixConfigBuilder.java
Sending        trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRConfigBuilder.java
Sending        trunk/modules/spring-builder/src/java/org/apache/geronimo/spring/deployment/SPRContext.java
Sending        trunk/modules/system/src/java/org/apache/geronimo/system/configuration/ExecutableConfigurationUtil.java
Sending        trunk/modules/tomcat-builder/src/java/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilder.java
Sending        trunk/modules/tomcat-builder/src/test/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilderTest.java
Transmitting file data .............................
Committed revision 264657.

Checking in modules/openejb-builder/src/java/org/openejb/deployment/OpenEJBModuleBuilder.java;
new revision: 1.52; previous revision: 1.51
Checking in modules/openejb-builder/src/test/org/openejb/deployment/KernelHelper.java;
new revision: 1.4; previous revision: 1.3

> Configuration should have multiple parents
> ------------------------------------------
>
>          Key: GERONIMO-947
>          URL: http://issues.apache.org/jira/browse/GERONIMO-947
>      Project: Geronimo
>         Type: Bug
>   Components: kernel
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> A configuration should have multiple parents.  This is needed for many reasons including to allow us to split our configurations into more manageable pieces.  Some discussion has produced this plan:
> 1. change all the builder code to produce an URI[] instead of URI for parentId using a parentId attribute with comma separated list of parents in the plans
> 2. Find a multi-parent classloader and use it in Configuration.  Dain says he has one and I think Eclipse has one.
> 3. Change the plan xml to have multiple import elements for the parents
> 4. split up our plans to take advantage of this feature.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-947) Configuration should have multiple parents

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-947?page=comments#action_12322716 ] 

David Jencks commented on GERONIMO-947:
---------------------------------------

Much of step 4 is included in commit 278940, see GERONIMO-966.  There's still a bit of cleanup to do.

> Configuration should have multiple parents
> ------------------------------------------
>
>          Key: GERONIMO-947
>          URL: http://issues.apache.org/jira/browse/GERONIMO-947
>      Project: Geronimo
>         Type: Bug
>   Components: kernel
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> A configuration should have multiple parents.  This is needed for many reasons including to allow us to split our configurations into more manageable pieces.  Some discussion has produced this plan:
> 1. change all the builder code to produce an URI[] instead of URI for parentId using a parentId attribute with comma separated list of parents in the plans
> 2. Find a multi-parent classloader and use it in Configuration.  Dain says he has one and I think Eclipse has one.
> 3. Change the plan xml to have multiple import elements for the parents
> 4. split up our plans to take advantage of this feature.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-947) Configuration should have multiple parents

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-947?page=all ]
     
David Jencks closed GERONIMO-947:
---------------------------------

    Resolution: Won't Fix

We could dice up the plans a bit more, but the multiparent classloader is  working great! Thanks Dain!!!

> Configuration should have multiple parents
> ------------------------------------------
>
>          Key: GERONIMO-947
>          URL: http://issues.apache.org/jira/browse/GERONIMO-947
>      Project: Geronimo
>         Type: Bug
>   Components: kernel
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> A configuration should have multiple parents.  This is needed for many reasons including to allow us to split our configurations into more manageable pieces.  Some discussion has produced this plan:
> 1. change all the builder code to produce an URI[] instead of URI for parentId using a parentId attribute with comma separated list of parents in the plans
> 2. Find a multi-parent classloader and use it in Configuration.  Dain says he has one and I think Eclipse has one.
> 3. Change the plan xml to have multiple import elements for the parents
> 4. split up our plans to take advantage of this feature.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-947) Configuration should have multiple parents

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-947?page=comments#action_12320646 ] 

David Jencks commented on GERONIMO-947:
---------------------------------------

Step 2b: use the MultiParentClassLoader in configurations.
Step 3: the parentId attribute can again only hold a single parent, but you can use any number of import elements (schema type same as dependency) to list parents.

Sending        trunk/modules/client-builder/src/java/org/apache/geronimo/client/builder/AppClientModuleBuilder.java
Sending        trunk/modules/client-builder/src/schema/geronimo-application-client.xsd
Sending        trunk/modules/connector-builder/maven.xml
Sending        trunk/modules/connector-builder/src/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java
Adding         trunk/modules/connector-builder/src/schema/geronimo-connector.xsd
Deleting       trunk/modules/connector-builder/src/schema/geronimo-connector_1_5.xsd
Sending        trunk/modules/deployment/src/java/org/apache/geronimo/deployment/DeploymentContext.java
Sending        trunk/modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/EARConfigBuilder.java
Sending        trunk/modules/j2ee-builder/src/schema/geronimo-application.xsd
Sending        trunk/modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java
Sending        trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/Configuration.java
Sending        trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/MultiParentClassLoader.java
Sending        trunk/modules/kernel/src/test/org/apache/geronimo/kernel/ConfigTest.java
Sending        trunk/modules/kernel/src/test/org/apache/geronimo/kernel/config/MultiParentClassLoaderTest.java
Sending        trunk/modules/service-builder/src/java/org/apache/geronimo/deployment/service/ServiceConfigBuilder.java
Sending        trunk/modules/service-builder/src/schema/geronimo-config.xsd
Adding         trunk/modules/service-builder/src/test/org/apache/geronimo/deployment/service/ParentIDTest.java
Sending        trunk/modules/system/src/java/org/apache/geronimo/system/configuration/ExecutableConfigurationUtil.java
Sending        trunk/modules/tomcat-builder/src/java/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilder.java
Sending        trunk/modules/web-builder/src/schema/geronimo-web.xsd
Transmitting file data ...................
Committed revision 264914.

Checking in modules/openejb-builder/src/java/org/openejb/deployment/OpenEJBModuleBuilder.java;
new revision: 1.53; previous revision: 1.52
Checking in modules/openejb-builder/src/schema/openejb-jar.xsd;
new revision: 1.25; previous revision: 1.24


> Configuration should have multiple parents
> ------------------------------------------
>
>          Key: GERONIMO-947
>          URL: http://issues.apache.org/jira/browse/GERONIMO-947
>      Project: Geronimo
>         Type: Bug
>   Components: kernel
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> A configuration should have multiple parents.  This is needed for many reasons including to allow us to split our configurations into more manageable pieces.  Some discussion has produced this plan:
> 1. change all the builder code to produce an URI[] instead of URI for parentId using a parentId attribute with comma separated list of parents in the plans
> 2. Find a multi-parent classloader and use it in Configuration.  Dain says he has one and I think Eclipse has one.
> 3. Change the plan xml to have multiple import elements for the parents
> 4. split up our plans to take advantage of this feature.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-947) Configuration should have multiple parents

Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-947?page=comments#action_12320617 ] 

Dain Sundstrom commented on GERONIMO-947:
-----------------------------------------

Step 2:

Adding         kernel/src/java/org/apache/geronimo/kernel/config/MultiParentClassLoader.java
Adding         kernel/src/test/org/apache/geronimo/kernel/config/MultiParentClassLoaderTest.java
Transmitting file data ..
Committed revision 264851.


> Configuration should have multiple parents
> ------------------------------------------
>
>          Key: GERONIMO-947
>          URL: http://issues.apache.org/jira/browse/GERONIMO-947
>      Project: Geronimo
>         Type: Bug
>   Components: kernel
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> A configuration should have multiple parents.  This is needed for many reasons including to allow us to split our configurations into more manageable pieces.  Some discussion has produced this plan:
> 1. change all the builder code to produce an URI[] instead of URI for parentId using a parentId attribute with comma separated list of parents in the plans
> 2. Find a multi-parent classloader and use it in Configuration.  Dain says he has one and I think Eclipse has one.
> 3. Change the plan xml to have multiple import elements for the parents
> 4. split up our plans to take advantage of this feature.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira