You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by PuspenduBanerjee <gi...@git.apache.org> on 2016/05/02 08:29:31 UTC
[GitHub] nifi pull request: Code modification for typeSafety
GitHub user PuspenduBanerjee opened a pull request:
https://github.com/apache/nifi/pull/400
Code modification for typeSafety
In post 1.4 Java era we should adhere to stricter code compliance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PuspenduBanerjee/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #400
----
commit 1c52e096da907d30df43ea9f5c97a1e1234b856e
Author: Puspendu Banerjee <pu...@gmail.com>
Date: 2016-05-02T06:24:51Z
TypeSafety related modification.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Code modification for typeSafety
Posted by PuspenduBanerjee <gi...@git.apache.org>.
Github user PuspenduBanerjee commented on the pull request:
https://github.com/apache/nifi/pull/400#issuecomment-216117511
@joewitt @apiri Please guide. Not sure why appveyor build is failing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Fix for NIFI-1838 & NIFI-1152 & Code modificati...
Posted by PuspenduBanerjee <gi...@git.apache.org>.
Github user PuspenduBanerjee commented on the pull request:
https://github.com/apache/nifi/pull/400#issuecomment-216557197
@markap14 If it looks good, will you be able to check in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #400: Fix for NIFI-1838 & NIFI-1152 & Code modification fo...
Posted by PuspenduBanerjee <gi...@git.apache.org>.
Github user PuspenduBanerjee closed the pull request at:
https://github.com/apache/nifi/pull/400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Fix for NIFI-1838 & NIFI-1152 & Code modificati...
Posted by PuspenduBanerjee <gi...@git.apache.org>.
Github user PuspenduBanerjee commented on the pull request:
https://github.com/apache/nifi/pull/400#issuecomment-216414833
Updated to address Fix for NIFI-1838 & NIFI-1152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Code modification for typeSafety
Posted by PuspenduBanerjee <gi...@git.apache.org>.
Github user PuspenduBanerjee commented on the pull request:
https://github.com/apache/nifi/pull/400#issuecomment-216302926
@apiri Please incorporate PR #370 as soon as you can. It will be a great help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Code modification for typeSafety
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/400#issuecomment-216305090
@PuspenduBanerjee Certainly will. Currently pending review before I am able to incorporate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Code modification for typeSafety
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/400#issuecomment-216268893
@PuspenduBanerjee unfortunately the appveyor results are a bit of noise at the moment as the associated PR #370 has yet to be incorporated. As a result, out of the box, it is trying to build its default which is not a Maven based project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Fix for NIFI-1838 & NIFI-1152 & Code modificati...
Posted by PuspenduBanerjee <gi...@git.apache.org>.
Github user PuspenduBanerjee commented on the pull request:
https://github.com/apache/nifi/pull/400#issuecomment-217337176
@markap14 @trkurc @apiri Will anyone get a chance to merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---