You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/04/03 20:01:08 UTC
Review Request 20013: Ambari hiveserver2 smoke test wrong for hiveserver 2
that uses LDAP authentication
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20013/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
Bugs: AMBARI-5343
https://issues.apache.org/jira/browse/AMBARI-5343
Repository: ambari
Description
-------
PROBLEM:
from /tmp/hiveserver2Smoke.sh
smokeout=`/usr/lib/hive/bin/beeline -u $1 -n fakeuser -p fakepwd -d org.apache.hive.jdbc.HiveDriver -e '!run $2'
2>&1| awk '{print}'|grep Error`
if [ "x$smokeout" == "x" ]; then
echo "Smoke test of hiveserver2 passed"
exit 0
else
echo "Smoke test of hiveserver2 wasnt passed"
echo $smokeout
exit 1
fi
Few errors in this script:
1. for LDAP authentication, it requires a real user and password
2. LDAP authentication may hang, not generating 'Error' string. The script will not detect the failure.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/service_check.py 111e8a1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/service_check.py 111e8a1
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_service_check.py f1deec7
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6390a70
Diff: https://reviews.apache.org/r/20013/diff/
Testing
-------
----------------------------------------------------------------------
Ran 191 tests in 1.418s
OK
----------------------------------------------------------------------
Total run:521
Total errors:0
Total failures:0
OK
Thanks,
Vitalyi Brodetskyi
Re: Review Request 20013: Ambari hiveserver2 smoke test wrong for hiveserver
2 that uses LDAP authentication
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On April 4, 2014, 3:09 a.m., Mahadev Konar wrote:
> > Looks like the port is hard coded and are we getting the hive server host via cluster host mapping? We should not be using globals which can go away.
Added some corrections(port init moved to params). About hardcoded port, we have no property in config with hiveserver port, that's why it's hardcoded(not only in my case). Hive server host i'm getting from config->clusterHostInfo->hive_server_host(this property we are using not only in my part of code).
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20013/#review39507
-----------------------------------------------------------
On April 4, 2014, 9:44 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20013/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 9:44 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
>
>
> Bugs: AMBARI-5343
> https://issues.apache.org/jira/browse/AMBARI-5343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> from /tmp/hiveserver2Smoke.sh
>
>
> smokeout=`/usr/lib/hive/bin/beeline -u $1 -n fakeuser -p fakepwd -d org.apache.hive.jdbc.HiveDriver -e '!run $2'
> 2>&1| awk '{print}'|grep Error`
>
> if [ "x$smokeout" == "x" ]; then
> echo "Smoke test of hiveserver2 passed"
> exit 0
> else
> echo "Smoke test of hiveserver2 wasnt passed"
> echo $smokeout
> exit 1
> fi
>
>
> Few errors in this script:
>
> 1. for LDAP authentication, it requires a real user and password
> 2. LDAP authentication may hang, not generating 'Error' string. The script will not detect the failure.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 968ade0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py f8f5231
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_service_check.py f1deec7
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6390a70
>
> Diff: https://reviews.apache.org/r/20013/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 191 tests in 1.418s
>
> OK
> ----------------------------------------------------------------------
> Total run:521
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 20013: Ambari hiveserver2 smoke test wrong for hiveserver
2 that uses LDAP authentication
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20013/#review39507
-----------------------------------------------------------
Looks like the port is hard coded and are we getting the hive server host via cluster host mapping? We should not be using globals which can go away.
- Mahadev Konar
On April 3, 2014, 6:10 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20013/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 6:10 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
>
>
> Bugs: AMBARI-5343
> https://issues.apache.org/jira/browse/AMBARI-5343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> from /tmp/hiveserver2Smoke.sh
>
>
> smokeout=`/usr/lib/hive/bin/beeline -u $1 -n fakeuser -p fakepwd -d org.apache.hive.jdbc.HiveDriver -e '!run $2'
> 2>&1| awk '{print}'|grep Error`
>
> if [ "x$smokeout" == "x" ]; then
> echo "Smoke test of hiveserver2 passed"
> exit 0
> else
> echo "Smoke test of hiveserver2 wasnt passed"
> echo $smokeout
> exit 1
> fi
>
>
> Few errors in this script:
>
> 1. for LDAP authentication, it requires a real user and password
> 2. LDAP authentication may hang, not generating 'Error' string. The script will not detect the failure.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_service_check.py f1deec7
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6390a70
>
> Diff: https://reviews.apache.org/r/20013/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 191 tests in 1.418s
>
> OK
> ----------------------------------------------------------------------
> Total run:521
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 20013: Ambari hiveserver2 smoke test wrong for hiveserver
2 that uses LDAP authentication
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20013/#review39442
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On April 3, 2014, 6:10 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20013/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 6:10 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
>
>
> Bugs: AMBARI-5343
> https://issues.apache.org/jira/browse/AMBARI-5343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> from /tmp/hiveserver2Smoke.sh
>
>
> smokeout=`/usr/lib/hive/bin/beeline -u $1 -n fakeuser -p fakepwd -d org.apache.hive.jdbc.HiveDriver -e '!run $2'
> 2>&1| awk '{print}'|grep Error`
>
> if [ "x$smokeout" == "x" ]; then
> echo "Smoke test of hiveserver2 passed"
> exit 0
> else
> echo "Smoke test of hiveserver2 wasnt passed"
> echo $smokeout
> exit 1
> fi
>
>
> Few errors in this script:
>
> 1. for LDAP authentication, it requires a real user and password
> 2. LDAP authentication may hang, not generating 'Error' string. The script will not detect the failure.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_service_check.py f1deec7
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6390a70
>
> Diff: https://reviews.apache.org/r/20013/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 191 tests in 1.418s
>
> OK
> ----------------------------------------------------------------------
> Total run:521
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 20013: Ambari hiveserver2 smoke test wrong for hiveserver
2 that uses LDAP authentication
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20013/#review39534
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On April 4, 2014, 9:44 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20013/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 9:44 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
>
>
> Bugs: AMBARI-5343
> https://issues.apache.org/jira/browse/AMBARI-5343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> from /tmp/hiveserver2Smoke.sh
>
>
> smokeout=`/usr/lib/hive/bin/beeline -u $1 -n fakeuser -p fakepwd -d org.apache.hive.jdbc.HiveDriver -e '!run $2'
> 2>&1| awk '{print}'|grep Error`
>
> if [ "x$smokeout" == "x" ]; then
> echo "Smoke test of hiveserver2 passed"
> exit 0
> else
> echo "Smoke test of hiveserver2 wasnt passed"
> echo $smokeout
> exit 1
> fi
>
>
> Few errors in this script:
>
> 1. for LDAP authentication, it requires a real user and password
> 2. LDAP authentication may hang, not generating 'Error' string. The script will not detect the failure.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 968ade0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py f8f5231
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_service_check.py f1deec7
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6390a70
>
> Diff: https://reviews.apache.org/r/20013/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 191 tests in 1.418s
>
> OK
> ----------------------------------------------------------------------
> Total run:521
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 20013: Ambari hiveserver2 smoke test wrong for hiveserver
2 that uses LDAP authentication
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20013/#review39529
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On April 4, 2014, 9:44 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20013/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 9:44 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
>
>
> Bugs: AMBARI-5343
> https://issues.apache.org/jira/browse/AMBARI-5343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> from /tmp/hiveserver2Smoke.sh
>
>
> smokeout=`/usr/lib/hive/bin/beeline -u $1 -n fakeuser -p fakepwd -d org.apache.hive.jdbc.HiveDriver -e '!run $2'
> 2>&1| awk '{print}'|grep Error`
>
> if [ "x$smokeout" == "x" ]; then
> echo "Smoke test of hiveserver2 passed"
> exit 0
> else
> echo "Smoke test of hiveserver2 wasnt passed"
> echo $smokeout
> exit 1
> fi
>
>
> Few errors in this script:
>
> 1. for LDAP authentication, it requires a real user and password
> 2. LDAP authentication may hang, not generating 'Error' string. The script will not detect the failure.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 968ade0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py f8f5231
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/service_check.py 111e8a1
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_service_check.py f1deec7
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6390a70
>
> Diff: https://reviews.apache.org/r/20013/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 191 tests in 1.418s
>
> OK
> ----------------------------------------------------------------------
> Total run:521
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 20013: Ambari hiveserver2 smoke test wrong for hiveserver
2 that uses LDAP authentication
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20013/
-----------------------------------------------------------
(Updated April 4, 2014, 9:44 a.m.)
Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
Changes
-------
Added some corrections to patch.
Bugs: AMBARI-5343
https://issues.apache.org/jira/browse/AMBARI-5343
Repository: ambari
Description
-------
PROBLEM:
from /tmp/hiveserver2Smoke.sh
smokeout=`/usr/lib/hive/bin/beeline -u $1 -n fakeuser -p fakepwd -d org.apache.hive.jdbc.HiveDriver -e '!run $2'
2>&1| awk '{print}'|grep Error`
if [ "x$smokeout" == "x" ]; then
echo "Smoke test of hiveserver2 passed"
exit 0
else
echo "Smoke test of hiveserver2 wasnt passed"
echo $smokeout
exit 1
fi
Few errors in this script:
1. for LDAP authentication, it requires a real user and password
2. LDAP authentication may hang, not generating 'Error' string. The script will not detect the failure.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 968ade0
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/service_check.py 111e8a1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py f8f5231
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/service_check.py 111e8a1
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_service_check.py f1deec7
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6390a70
Diff: https://reviews.apache.org/r/20013/diff/
Testing
-------
----------------------------------------------------------------------
Ran 191 tests in 1.418s
OK
----------------------------------------------------------------------
Total run:521
Total errors:0
Total failures:0
OK
Thanks,
Vitalyi Brodetskyi
Re: Review Request 20013: Ambari hiveserver2 smoke test wrong for hiveserver
2 that uses LDAP authentication
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20013/
-----------------------------------------------------------
(Updated April 3, 2014, 6:10 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
Bugs: AMBARI-5343
https://issues.apache.org/jira/browse/AMBARI-5343
Repository: ambari
Description
-------
PROBLEM:
from /tmp/hiveserver2Smoke.sh
smokeout=`/usr/lib/hive/bin/beeline -u $1 -n fakeuser -p fakepwd -d org.apache.hive.jdbc.HiveDriver -e '!run $2'
2>&1| awk '{print}'|grep Error`
if [ "x$smokeout" == "x" ]; then
echo "Smoke test of hiveserver2 passed"
exit 0
else
echo "Smoke test of hiveserver2 wasnt passed"
echo $smokeout
exit 1
fi
Few errors in this script:
1. for LDAP authentication, it requires a real user and password
2. LDAP authentication may hang, not generating 'Error' string. The script will not detect the failure.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/service_check.py 111e8a1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/service_check.py 111e8a1
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_service_check.py f1deec7
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6390a70
Diff: https://reviews.apache.org/r/20013/diff/
Testing
-------
----------------------------------------------------------------------
Ran 191 tests in 1.418s
OK
----------------------------------------------------------------------
Total run:521
Total errors:0
Total failures:0
OK
Thanks,
Vitalyi Brodetskyi