[jira] [Commented] (SYSTEMML-1527) Use top-level algorithm scripts for application tests

["Krishna Kalyan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYSTEMML-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000193#comment-16000193 ] 

Krishna Kalyan commented on SYSTEMML-1527:
------------------------------------------

Hello [~mboehm7],
I could you please help me with some questions related to this tasks below.

Lets take for example GLM algorithm
Essentially both the files are the same except for some minor differences
https://gist.github.com/krishnakalyan3/be28d984714a1be97f66dee15b9154ae

As far as I understand, the scope of this sub task would be to change the file below
https://github.com/apache/incubator-systemml/blob/master/src/test/scripts/applications/glm/GLM.dml
to point to the actual algorithm
https://github.com/apache/incubator-systemml/blob/master/scripts/algorithms/GLM.dml

Reproduce the same for comparison with R in GLM.R
Translate GLM.dml code to GLM.pydml (Not sure about this!).

Could you please confirm that I am not missing anything?.

Regards,
Krishna

cc [~nakul02]

https://docs.google.com/spreadsheets/d/1IjI4OqgXfZKNKmj8uxib4nG4SMk_ep0PIxj8n64SQMI/edit#gid=0

> Use top-level algorithm scripts for application tests
> -----------------------------------------------------
>
>                 Key: SYSTEMML-1527
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-1527
>             Project: SystemML
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: Matthias Boehm
>
> There are numerous dml and pydml application tests that aim to test our existing algorithms. However, these tests use replicated (and mostly outdated) scripts. This task aims to remove the duplicated dml and pydml scripts and to refer directly to the existing algorithm tests. This also includes the update of R comparison scripts.
> See SYSTEMML-1363 for examples.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)