You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/08/30 20:35:00 UTC

[jira] [Created] (HBASE-18722) Replace copied guava code w/ pointer to the (shaded) lib

stack created HBASE-18722:
-----------------------------

             Summary: Replace copied guava code w/ pointer to the (shaded) lib
                 Key: HBASE-18722
                 URL: https://issues.apache.org/jira/browse/HBASE-18722
             Project: HBase
          Issue Type: Bug
            Reporter: stack
            Priority: Minor


I found a few bits of code copied from guava src:

{code}
./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * Copied from guava source code v15 (LimitedInputStream)
./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * allows to be compatible with guava 11 to 15+.
./src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java:         * from guava v21
./src/main/java/org/apache/hadoop/hbase/util/Bytes.java:             * comparator from guava v21
{code}

We can instead point back at guava implementations now we use shaded guava internally. No point having it in our code base when latest guava is on latest CLASSPATH (This wasn't always the case; this is why the code was copied into hbase).

Also, there are other copies other than the above.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)