[GitHub] [samza] bkonold commented on a change in pull request #1283: SAMZA-2464: Container shuts down when task fails to remove old state checkpoint dirs

[GitBox <gi...@apache.org>]

bkonold commented on a change in pull request #1283: SAMZA-2464: Container shuts down when task fails to remove old state checkpoint dirs
URL: https://github.com/apache/samza/pull/1283#discussion_r381633029
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala
 ##########
 @@ -274,7 +274,11 @@ class TaskInstance(
 
     if (storageManager != null) {
       trace("Remove old checkpoint stores for taskName: %s" format taskName)
-      storageManager.removeOldCheckpoints(checkpointId)
+      try {
+        storageManager.removeOldCheckpoints(checkpointId)
+      } catch {
+        case e: Exception => error("Failed to remove old checkpoints", e)
 
 Review comment:
   ack, i'll add those

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services