You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/05 12:33:08 UTC

[GitHub] [incubator-superset] kstrz commented on a change in pull request #12226: test: birth names

kstrz commented on a change in pull request #12226:
URL: https://github.com/apache/incubator-superset/pull/12226#discussion_r551903712



##########
File path: tests/conftest.py
##########
@@ -43,14 +43,12 @@ def setup_sample_data() -> Any:
 
         examples.load_css_templates()
         examples.load_world_bank_health_n_pop(sample=True)
-        examples.load_birth_names(sample=True)
 
     yield
 
     with app.app_context():
         engine = get_example_database().get_sqla_engine()
         engine.execute("DROP TABLE wb_health_population")

Review comment:
       Do you mean leaving sth like this: `engine.execute("DROP TABLE IF EXISTS birth_names")`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org