You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/02/16 21:54:45 UTC

[GitHub] flink pull request: [FLINK-3401] [api breaking] AscendingTimestamp...

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/1647

    [FLINK-3401] [api breaking] AscendingTimestampExtractor only logs violations

    This pull requests is based on #1646 
    
    The AscendingTimestampExtractor only logs violations of ascending timestamp order. 
    
    Previously it failed hard on a violation. Since that would be in many cases irrecoverable as soon as one order violation happens in the stream, it it changed to by default only log violations.
    
    The user can still explicitly set an 'IgnoringHandler' or a 'FailingHandler', which do nothing on violations,
    respectively fail hard as before.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink ascending_extractor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1647
    
----
commit bfe22cf7ea72941056fbbb657094ec75e58c74c4
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-16T09:37:59Z

    [FLINK-3379] [FLINK-3415] [streaming] Refactor TimestampExtractor into two separate classes
    
     - one class handled periodic watermarks
     - the other class handled watermarks triggered by elements
    
    This also makes sure that any timestamp assigner / watermark generators cannot generate
    negative watermarks

commit 6dcdc3e3a82024c066d73b2d25b27a723bbccdd3
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-15T17:41:15Z

    [FLINK-3401] [streaming] [api breaking] AscendingTimestampExtractor only logs violations of ascending timestamp order.
    
    The user can also explicitly set an 'IgnoringHandler' or a 'FailingHandler', which do nothing on violations,
    respectively fail hard.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3401] [api breaking] AscendingTimestamp...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen closed the pull request at:

    https://github.com/apache/flink/pull/1647


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3401] [api breaking] AscendingTimestamp...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1647#issuecomment-185199372
  
    Manually merged in e08d7a6f30f8e3b845ff33d4266fbd4fad4bec63


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---