You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2013/03/11 13:43:13 UTC
[jira] [Commented] (LUCENE-4822) Add PatternKeywordTokenFilter to
marks keywords based on regular expressions
[ https://issues.apache.org/jira/browse/LUCENE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598778#comment-13598778 ]
Uwe Schindler commented on LUCENE-4822:
---------------------------------------
In my opinion, the abstract isKeyword() methods should take no arguments and use the CharTermAttribute directly (it would then be consistent to the accept() method of the abstract base class [FilteringTokenFilter|http://lucene.apache.org/core/4_1_0/analyzers-common/org/apache/lucene/analysis/util/FilteringTokenFilter.html] of e.g. StopFilter). We would also need no spare CharsRef, as CharTermAttribute implements CharSequence, so Matcher can handle it directly without cloning.
The explicit access to the buffer, offset and length is implementation specific to only the one backed by CharArraySet.
> Add PatternKeywordTokenFilter to marks keywords based on regular expressions
> ----------------------------------------------------------------------------
>
> Key: LUCENE-4822
> URL: https://issues.apache.org/jira/browse/LUCENE-4822
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 4.2
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 5.0, 4.3
>
> Attachments: LUCENE-4822.patch
>
>
> today we need to pass in an explicit set of terms that we want to marks as keywords. It might make sense to allow patterns as well to prevent certain suffixes etc. to be keyworded.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org