You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/09 03:37:29 UTC

[GitHub] [spark] beliefer opened a new pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

beliefer opened a new pull request #30292:
URL: https://github.com/apache/spark/pull/30292


   ### What changes were proposed in this pull request?
   In the last few releases, our Spark documentation  https://spark.apache.org/docs/latest/ becomes richer. It would nice to provide a search function to make our users find contents faster. 
   
   [DocSearch](https://docsearch.algolia.com/) is entirely free and automated.  This PR will use it to provides search function.
   
   ### Why are the changes needed?
   Let the users of Spark documentation could find the needed information effectively.
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes
   
   
   ### How was this patch tested?
   build on my machine and look on brower.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520466692



##########
File path: docs/_layouts/global.html
##########
@@ -172,6 +178,15 @@ <h1 class="title">{{ page.title }}</h1>
         <script src="js/vendor/bootstrap.bundle.min.js"></script>
         <script src="js/vendor/anchor.min.js"></script>
         <script src="js/main.js"></script>
+        <script type="text/javascript" src="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.js"></script>
+        <script type="text/javascript"> docsearch({
+            apiKey: 'b18ca3732c502995563043aa17bc6ecb',

Review comment:
       OK




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726317238






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723741911


   **[Test build #130768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130768/testReport)** for PR 30292 at commit [`cae8dd1`](https://github.com/apache/spark/commit/cae8dd17320fc79723295998fdda4fff4fe1cc6f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723753864






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724639828






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724431063


   @sarutak and @srowen too


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520342782



##########
File path: docs/_layouts/global.html
##########
@@ -30,6 +30,8 @@
         <script src="js/vendor/modernizr-2.6.1-respond-1.1.0.min.js"></script>
 
         <link rel="stylesheet" href="css/pygments-default.css">
+        <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css" />

Review comment:
       Yeah. the `docsearch.js` maybe associate with external search engines. It's not good to copy as part of source code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723751313


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35375/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725276736


   > If so, we should apply different id from docsearch when we ready release a new spark version. @gatorsmile
   
   Sounds good if we can do it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725262955


   > @sarutak Because this PR not merged and not publish to the online Spark document.
   
   Yes. But even if this is published, the search results consistently refer to the latest release at the time point.
   Imagine that this feature is merged to 3.1 and then 3.2 is released in the future, and someone still uses Spark 3.1.
   In that case, even though the user uses this feature for 3.1, the search result refer to the document for 3.2 right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726248061


   **[Test build #131016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131016/testReport)** for PR 30292 at commit [`7120c5b`](https://github.com/apache/spark/commit/7120c5be01e191d31dcae65170a87d8c44d404e0).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723738154






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726282575


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726237800


   retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724797190






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724531759


   > What browser are you using?
   
   I tried with Chrome/Safari/Firefox on macOS.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724687732






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725262955


   > @sarutak Because this PR not merged and not publish to the online Spark document.
   
   Yes. But even if this is published the search results consistently refers to the latest release at the time point.
   Imagine that this feature is merged to 3.1 and then 3.2 is released in the future, and someone still uses Spark 3.1.
   In that case, even though the user uses this feature for 3.1, one moves to the document for 3.2 right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520290288



##########
File path: docs/_layouts/global.html
##########
@@ -30,6 +30,8 @@
         <script src="js/vendor/modernizr-2.6.1-respond-1.1.0.min.js"></script>
 
         <link rel="stylesheet" href="css/pygments-default.css">
+        <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css" />

Review comment:
       For all the external css/js files for Spark UI/Doc, we always download it and make it as part of the source code.
   I think this is to make sure Spark UI/Doc can be run and access in a private network.
   However, it seems fine for Spark Doc. cc @srowen @sarutak , WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726475064


   @gengliangwang I resolved the issue you said.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724751360


   **[Test build #130876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130876/testReport)** for PR 30292 at commit [`9c9d639`](https://github.com/apache/spark/commit/9c9d639ed51ea65be502a059b19494902593b154).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520267913



##########
File path: docs/_layouts/global.html
##########
@@ -172,6 +178,15 @@ <h1 class="title">{{ page.title }}</h1>
         <script src="js/vendor/bootstrap.bundle.min.js"></script>
         <script src="js/vendor/anchor.min.js"></script>
         <script src="js/main.js"></script>
+        <script type="text/javascript" src="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.js"></script>
+        <script type="text/javascript"> docsearch({
+            apiKey: 'b18ca3732c502995563043aa17bc6ecb',

Review comment:
       For other reviewers, this API key was applied by me. Below is the basic descriptions sent by DocSearch 
   
   > DocSearch is built in two parts:
   > – a crawler which we run on our own infrastructure every 24 hours. It follows every link in your website and extract content from every page it traverses. It then pushes this content to an Algolia index.
   > – a JavaScript snippet to be inserted in your website that will bind this Algolia index to your search input and display its results in a dropdown UI.
   > If you want to find more details on how works DocSearch, check [our docs](https://docsearch.algolia.com/docs/what-is-docsearch/).
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725537870


   @beliefer Thanks for the work!
   I just tried the PR in my local setup. The element "Documentation" is wired to me:
   * It is always with the same URL as the first search result. 
   * I thought the rectangle outside the "Documentation" is an input text box but it is not.
   ![image](https://user-images.githubusercontent.com/1097932/98840305-7c0e2f80-23fb-11eb-90dd-36c634d654f3.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726282548


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35622/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724520338


   > The loupe icon and the first one or two characters of the search text overlaps. Can we adjust somehow?
   > <img alt="loupe" width="311" src="https://user-images.githubusercontent.com/4736016/98643340-3a857200-2372-11eb-9418-9552038cd15b.png">
   
   What browser are you using?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724519691


   The loupe icon and the first one or two characters of the search text overlaps. Can we adjust somehow?
   <img width="311" alt="loupe" src="https://user-images.githubusercontent.com/4736016/98643340-3a857200-2372-11eb-9418-9552038cd15b.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520327417



##########
File path: docs/_layouts/global.html
##########
@@ -30,6 +30,8 @@
         <script src="js/vendor/modernizr-2.6.1-respond-1.1.0.min.js"></script>
 
         <link rel="stylesheet" href="css/pygments-default.css">
+        <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css" />

Review comment:
       In my experience, HistoryServer is used within a closed network so I think it's better to make css/js as part of source code for WebUI.
   On the other hand, I think it's fine for docs to use external link.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725084375


   @sarutak I cannot reproduce the two problems you mentioned on my Safari browser. It seems the css style is different. Could you pull and build with Jekyll again?
   ![input](https://user-images.githubusercontent.com/8486025/98757235-fd49d000-23c3-11eb-879d-46b9fcb95330.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726176304


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35612/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726141997


   **[Test build #131005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131005/testReport)** for PR 30292 at commit [`7120c5b`](https://github.com/apache/spark/commit/7120c5be01e191d31dcae65170a87d8c44d404e0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725537870


   @beliefer Thanks for the work!
   I just tried the PR in my local setup. The element "Documentation" is wired to me:
   * It is always with the same URL as the first search result. 
   * I thought the rectangle outside the "Documentation" is an input text box but it is not.
   ![image](https://user-images.githubusercontent.com/1097932/98840694-f63eb400-23fb-11eb-9af2-75df75e37524.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724751360


   **[Test build #130876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130876/testReport)** for PR 30292 at commit [`9c9d639`](https://github.com/apache/spark/commit/9c9d639ed51ea65be502a059b19494902593b154).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724531759


   > What browser are you using?
   
   I tried Chrome/Safari/Firefox on macOS.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725537870


   @beliefer Thanks for the work!
   I just tried the PR in my local setup. The element "Documentation" looks wired to me:
   * It is always with the same URL as the first search result. 
   * I thought the rectangle outside the "Documentation" is an input text box but it is not.
   ![image](https://user-images.githubusercontent.com/1097932/98840694-f63eb400-23fb-11eb-9af2-75df75e37524.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726141997


   **[Test build #131005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131005/testReport)** for PR 30292 at commit [`7120c5b`](https://github.com/apache/spark/commit/7120c5be01e191d31dcae65170a87d8c44d404e0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724465992


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35438/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723739517


   Nice, it's shorter than I thought. Can you show the screenshots too?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724548469


   After moving to another page by searching with this feature, the search box disappears.
   This screenshot is also took with Safari.
   <img width="312" alt="disappear" src="https://user-images.githubusercontent.com/4736016/98649580-1bd7a900-237b-11eb-94f7-25b32d66c414.png">
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725256974


   @sarutak Because this PR not merged and publish to the online Spark document.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726316069


   **[Test build #131005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131005/testReport)** for PR 30292 at commit [`7120c5b`](https://github.com/apache/spark/commit/7120c5be01e191d31dcae65170a87d8c44d404e0).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725613417


   > If so, we should apply different id from docsearch when we ready release a new spark version. @gatorsmile
   
   Yes. This is true. We need to apply different ID for each new version. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724687732






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724760563






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724674149


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35470/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724466012






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724535405


   > > What browser are you using?
   > 
   > I tried with Chrome/Safari/Firefox on macOS.
   
   Which browser did you use to find your screenshots?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723735570


   **[Test build #130766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130766/testReport)** for PR 30292 at commit [`3607e23`](https://github.com/apache/spark/commit/3607e232db0494accbbd73549a49307361ad0a70).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724797165


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35482/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723735570


   **[Test build #130766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130766/testReport)** for PR 30292 at commit [`3607e23`](https://github.com/apache/spark/commit/3607e232db0494accbbd73549a49307361ad0a70).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang closed pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #30292:
URL: https://github.com/apache/spark/pull/30292


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726240690


   **[Test build #131016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131016/testReport)** for PR 30292 at commit [`7120c5b`](https://github.com/apache/spark/commit/7120c5be01e191d31dcae65170a87d8c44d404e0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726282588


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35622/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723751321






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724438579






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724548469


   After moving to another page by searching with this feature, the search box hides.
   This screenshot is also took with Safari.
   ![Uploading hide.png…]()
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724466012






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723753864






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725540031


   I just try removing the style from dosearch.css and it looks fine:
   ![image](https://user-images.githubusercontent.com/1097932/98840986-5a617800-23fc-11eb-8747-b0e510507013.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725262955


   > @sarutak Because this PR not merged and not publish to the online Spark document.
   Yes. But even if this is published the search results consistently refers to the latest release at the time point.
   Imagine that this feature is merged to 3.1 and then 3.2 is released in the future, and someone still uses Spark 3.1.
   In that case, even though the user uses this feature for 3.1, one moves to the document for 3.2 right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726564502


   Seems good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723738075


   **[Test build #130766 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130766/testReport)** for PR 30292 at commit [`3607e23`](https://github.com/apache/spark/commit/3607e232db0494accbbd73549a49307361ad0a70).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724454430


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35438/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726176317


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726668853


   @gengliangwang @sarutak @gatorsmile @maropu @HyukjinKwon Thanks for your help!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724438423


   **[Test build #130829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130829/testReport)** for PR 30292 at commit [`3a6bf0b`](https://github.com/apache/spark/commit/3a6bf0bb900a3a5867d3437a30b7ad37915d52b5).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723753853


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35377/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723739027


   **[Test build #130768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130768/testReport)** for PR 30292 at commit [`cae8dd1`](https://github.com/apache/spark/commit/cae8dd17320fc79723295998fdda4fff4fe1cc6f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725256974


   @sarutak Because this PR not merged and not publish to the online Spark document.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725262955


   > @sarutak Because this PR not merged and not publish to the online Spark document.
   
   Yes. But even if this is published, the search results consistently refer to the latest release at the time point.
   Imagine that this feature is merged to 3.1 and then 3.2 is released in the future, and someone still uses Spark 3.1.
   In that case, even though the user uses this feature for 3.1, one moves to the document for 3.2 right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723751321






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724639630


   **[Test build #130863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130863/testReport)** for PR 30292 at commit [`5949977`](https://github.com/apache/spark/commit/5949977bbc42923d908cac3862d444047d3afc2c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725537870


   @beliefer Thanks for the work!
   I just tried the PR in my local setup. The element "Documentation" is wired to me. It is always with the same URL as the first search result. Also, I thought the rectangle outside the "Documentation" is an input text box.
   ![image](https://user-images.githubusercontent.com/1097932/98840305-7c0e2f80-23fb-11eb-90dd-36c634d654f3.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724633702


   **[Test build #130863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130863/testReport)** for PR 30292 at commit [`5949977`](https://github.com/apache/spark/commit/5949977bbc42923d908cac3862d444047d3afc2c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726160930


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35612/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725275209


   > > @sarutak Because this PR not merged and not publish to the online Spark document.
   > 
   > Yes. But even if this is published, the search results consistently refer to the latest release at the time point.
   > Imagine that this feature is merged to 3.1 and then 3.2 is released in the future, and someone still uses Spark 3.1.
   > In that case, even though the user uses this feature for 3.1, the search result refer to the document for 3.2 right?
   
   If so, we should apply different id from docsearch when we release a new spark version. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520290288



##########
File path: docs/_layouts/global.html
##########
@@ -30,6 +30,8 @@
         <script src="js/vendor/modernizr-2.6.1-respond-1.1.0.min.js"></script>
 
         <link rel="stylesheet" href="css/pygments-default.css">
+        <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css" />

Review comment:
       For all the external css/js files for Spark UI/Doc, we always download it and make it as part of the source code.
   I think this is to make sure Spark UI/Doc can be run and accessed in a private network.
   However, it seems fine for Spark Doc. cc @srowen @sarutak , WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724760282


   **[Test build #130876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130876/testReport)** for PR 30292 at commit [`9c9d639`](https://github.com/apache/spark/commit/9c9d639ed51ea65be502a059b19494902593b154).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724420772


   > Nice, it's shorter than I thought. Can you show the screenshots too?
   
   I uploaded the screenshots.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724633702


   **[Test build #130863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130863/testReport)** for PR 30292 at commit [`5949977`](https://github.com/apache/spark/commit/5949977bbc42923d908cac3862d444047d3afc2c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520327417



##########
File path: docs/_layouts/global.html
##########
@@ -30,6 +30,8 @@
         <script src="js/vendor/modernizr-2.6.1-respond-1.1.0.min.js"></script>
 
         <link rel="stylesheet" href="css/pygments-default.css">
+        <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css" />

Review comment:
       In my experience, HistoryServer is used within a closed network so I think it's better to make css/js as part of source code.
   On the other hand, I think it's fine for docs to use external link.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726625060


   Thanks, merging to master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723739027


   **[Test build #130768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130768/testReport)** for PR 30292 at commit [`cae8dd1`](https://github.com/apache/spark/commit/cae8dd17320fc79723295998fdda4fff4fe1cc6f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724779263


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35482/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724430975


   cc @gengliangwang and @gatorsmile 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726265514


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35622/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724438579






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724434829


   **[Test build #130829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130829/testReport)** for PR 30292 at commit [`3a6bf0b`](https://github.com/apache/spark/commit/3a6bf0bb900a3a5867d3437a30b7ad37915d52b5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726248274






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726240690


   **[Test build #131016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131016/testReport)** for PR 30292 at commit [`7120c5b`](https://github.com/apache/spark/commit/7120c5be01e191d31dcae65170a87d8c44d404e0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723748179


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35377/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726317238






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726282575






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
beliefer edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725275209


   > > @sarutak Because this PR not merged and not publish to the online Spark document.
   > 
   > Yes. But even if this is published, the search results consistently refer to the latest release at the time point.
   > Imagine that this feature is merged to 3.1 and then 3.2 is released in the future, and someone still uses Spark 3.1.
   > In that case, even though the user uses this feature for 3.1, the search result refer to the document for 3.2 right?
   
   If so, we should apply different id from docsearch when we ready release a new spark version.  @gatorsmile 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725188788


   @beliefer I found the first issue isn't in the latest change. The second issue seems that we move to the online Spark document rather than local document.
   
   Before move:
   <img width="970" alt="before_move" src="https://user-images.githubusercontent.com/4736016/98765284-2482ba80-2421-11eb-8b23-5d479683c7fb.png">
   
   After move:
   <img width="1006" alt="after_move" src="https://user-images.githubusercontent.com/4736016/98765290-2a789b80-2421-11eb-8ba3-8f372ca4aa77.png">
   
   Is this intended?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725262955


   > @sarutak Because this PR not merged and not publish to the online Spark document.
   
   Yes. But even if this is published, the search results consistently refers to the latest release at the time point.
   Imagine that this feature is merged to 3.1 and then 3.2 is released in the future, and someone still uses Spark 3.1.
   In that case, even though the user uses this feature for 3.1, one moves to the document for 3.2 right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang edited a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-725540031


   I just try removing the style from dosearch.css and it looks fine:
   ![image](https://user-images.githubusercontent.com/1097932/98840986-5a617800-23fc-11eb-8747-b0e510507013.png)
   
   I don't think we can just copy the style from https://docsearch.algolia.com/docs/styling here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723738154






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724797190






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520364464



##########
File path: docs/_layouts/global.html
##########
@@ -172,6 +178,15 @@ <h1 class="title">{{ page.title }}</h1>
         <script src="js/vendor/bootstrap.bundle.min.js"></script>
         <script src="js/vendor/anchor.min.js"></script>
         <script src="js/main.js"></script>
+        <script type="text/javascript" src="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.js"></script>
+        <script type="text/javascript"> docsearch({
+            apiKey: 'b18ca3732c502995563043aa17bc6ecb',

Review comment:
       > For other reviewers, this API key was applied by me. Below is the basic descriptions sent by DocSearch
   
   @beliefer How about leaving the info above in the file side so that one can cantact Xiao smoothly if we hit some issues around API accesses?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724434829


   **[Test build #130829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130829/testReport)** for PR 30292 at commit [`3a6bf0b`](https://github.com/apache/spark/commit/3a6bf0bb900a3a5867d3437a30b7ad37915d52b5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724760563






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520290288



##########
File path: docs/_layouts/global.html
##########
@@ -30,6 +30,8 @@
         <script src="js/vendor/modernizr-2.6.1-respond-1.1.0.min.js"></script>
 
         <link rel="stylesheet" href="css/pygments-default.css">
+        <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css" />

Review comment:
       For all the external css/js files for Spark UI/Doc, we always download it and make it as part of the source code.
   I think this is to make sure Spark UI/Doc can be run and accessed in a private network.
   However, it seems fine for Spark Doc to use external link for CSS/JS file. cc @srowen @sarutak , WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723742016






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724639828






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726176317






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726176331


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35612/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724687704


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35470/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-726248274






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723742016






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-724545742


   > Which browser did you use to find your screenshots?
   
   It's Safari.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520298895



##########
File path: docs/_layouts/global.html
##########
@@ -172,6 +178,15 @@ <h1 class="title">{{ page.title }}</h1>
         <script src="js/vendor/bootstrap.bundle.min.js"></script>
         <script src="js/vendor/anchor.min.js"></script>
         <script src="js/main.js"></script>
+        <script type="text/javascript" src="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.js"></script>
+        <script type="text/javascript"> docsearch({
+            apiKey: 'b18ca3732c502995563043aa17bc6ecb',

Review comment:
       It is also free. https://docsearch.algolia.com/docs/faq/#how-much-does-it-cost




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30292:
URL: https://github.com/apache/spark/pull/30292#issuecomment-723746181


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35375/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org