[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7384: NIFI-11696 Upgrade Bouncy Castle from 1.71 to 1.74

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory commented on code in PR #7384:
URL: https://github.com/apache/nifi/pull/7384#discussion_r1231428904


##########
nifi-commons/nifi-repository-encryption/src/main/java/org/apache/nifi/repository/encryption/AesGcmByteArrayRepositoryEncryptor.java:
##########
@@ -74,9 +73,17 @@ protected byte[] encrypt(final byte[] record, final String recordId, final Strin
         try {
             final byte[] encryptedRecord = cipher.doFinal(record);
             final byte[] serializedMetadata = getMetadata(keyId, cipher.getIV(), encryptedRecord.length);
-            return Arrays.concatenate(serializedMetadata, encryptedRecord);
+            return concatenate(serializedMetadata, encryptedRecord);

Review Comment:
   I considered that, but this approach avoids introducing an additional dependency on commons-lang3 for this library, so that's the reason for the manual approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org