[jira] [Commented] (TINKERPOP-2824) Properties on Elements

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689915#comment-17689915 ] 

ASF GitHub Bot commented on TINKERPOP-2824:
-------------------------------------------

spmallette commented on code in PR #1843:
URL: https://github.com/apache/tinkerpop/pull/1843#discussion_r1108901855


##########
gremlin-util/src/main/java/org/apache/tinkerpop/gremlin/util/Tokens.java:
##########
@@ -79,6 +79,11 @@ private Tokens() {}
     public static final String ARGS_HOST = "host";
     public static final String ARGS_SESSION = "session";
     public static final String ARGS_MANAGE_TRANSACTION = "manageTransaction";
+    public static final String ARGS_MATERIALIZE_PROPERTIES = "materializeProperties";
+
+    // todo: discuss: keep here or move to {@code T}?

Review Comment:
   i guess we've relegated "properties on elements" to a feature peculiar to remoting (meaning the `materializeProperties` is ignored for embedded use cases). it seems more like `RequestOptions` than a `T` in my book. as a result, i think it should stay bound to `Tokens` and not `T` which is more an element of Gremlin Structure API and Language itself. unfortunately it does mean that you will need to document this subtle difference.





> Properties on Elements
> ----------------------
>
>                 Key: TINKERPOP-2824
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2824
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet, driver, go, javascript, process, python
>    Affects Versions: 3.5.4
>            Reporter: Valentyn Kahamlyk
>            Assignee: Valentyn Kahamlyk
>            Priority: Major
>
> Problem: When a user writes `g.V()` they get back a Vertex object. The problem is that depending on the execution context of the traversal, the result could be quite different, with or without properties.
> Solution: Implement new finalization strategy DetachStrategy(detachMode, properties) where mode is one of ALL, NONE or CUSTOM. `properties` is list of properties name, are taken into account only for CUSTOM mode.
> Discussion thread in dev list: [Proposal to handle properties on response Elements-Apache Mail Archives|https://lists.apache.org/thread/l8rw7ydj7kym8vhtwk50nhbp45ng9986]
> Stephen's thread in dev list: [The Issue of Detachment-Apache Mail Archives|https://lists.apache.org/thread/xltcon4zxnwq4fyw2r2126syyrqm8spy]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)