[GitHub] [helix] pkuwm commented on issue #677: Add method to wait and return established session's ID

[GitBox <gi...@apache.org>]

pkuwm commented on issue #677: Add method to wait and return established session's ID
URL: https://github.com/apache/helix/pull/677#issuecomment-572785205
 
 
   This PR is ready to be merged, approved by @jiajunwang 
   
   Commit message:
   ```
   zkClient's getSessionId() could bring in session race condition: session A is connected in waitUntilConnected, but when zkClient.getSession() is called in zkHelixManager, session A might be already expired and so zkClient.getSession() gets session B. This session ID is critical for the firs time handling new session after zkclient is created in zkHelixManager.
   
   Solution: add a new method waitForEstablishedSession() to wait for SynCconnected state and return the session id before unlocking the eventLock.
   
   Change list:
   - Add a new method waitForEstablishedSession()
   - Add a unit test to cover the new method.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org