You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eumiro (via GitHub)" <gi...@apache.org> on 2023/09/05 18:29:41 UTC

[GitHub] [airflow] eumiro opened a new pull request, #34110: Refactor: Consolidate import datetime

eumiro opened a new pull request, #34110:
URL: https://github.com/apache/airflow/pull/34110

   There are several files with `from airflow.utils.timezone import datetime` that at the same time `import datetime as dt`, making the two variables confusing. How about changing that `airflow.utils.timezone.datetime` to a more descriptive name?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] hussein-awala commented on pull request #34110: Refactor: Consolidate import datetime

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #34110:
URL: https://github.com/apache/airflow/pull/34110#issuecomment-1707338998

   merge main to fix static checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] hussein-awala commented on a diff in pull request #34110: Refactor: Consolidate import datetime

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #34110:
URL: https://github.com/apache/airflow/pull/34110#discussion_r1316431193


##########
airflow/providers/cncf/kubernetes/pod_launcher_deprecated.py:
##########


Review Comment:
   This module is deprecated.
   @eladkal is it ok to update it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #34110: Refactor: Consolidate import datetime

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #34110:
URL: https://github.com/apache/airflow/pull/34110


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org