You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "cziegeler (via GitHub)" <gi...@apache.org> on 2025/06/30 07:05:00 UTC

Re: [PR] Fixes for SLING-12845 and SLING-12844 [sling-org-apache-sling-engine]

cziegeler commented on code in PR #64:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/64#discussion_r2174371429


##########
src/main/java/org/apache/sling/engine/impl/SlingHttpServletResponseImpl.java:
##########
@@ -332,7 +343,10 @@ private String getCurrentStackTrace() {
 
     @Override
     public void setContentType(final String type) {
-        if (this.isCommitted() || !isInclude()) {
+        boolean isCommitedDueToSendErrorOrRedirect = this.isCommitted()
+                && (CommitReason.SEND_ERROR.equals(this.committedReason)

Review Comment:
   dont use equals for enums, == is ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org