You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by wi...@apache.org on 2021/07/22 20:46:00 UTC

[orc] branch main updated: ORC-841: Remove Superfluous Array Fill in StringHashTableDictionary

This is an automated email from the ASF dual-hosted git repository.

william pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new 9b87fbf  ORC-841: Remove Superfluous Array Fill in StringHashTableDictionary
9b87fbf is described below

commit 9b87fbf599ae037bf65115f055795c486d293a2b
Author: belugabehr <12...@users.noreply.github.com>
AuthorDate: Fri Jul 9 12:45:51 2021 -0400

    ORC-841: Remove Superfluous Array Fill in StringHashTableDictionary
    
    * What changes were proposed in this pull request?
      Remove Superfluous Array Fill in StringHashTableDictionary.
      Java GC will take care of this.
    
    * Why are the changes needed?
      Less code. Performance.
    
    * How was this patch tested?
      No changes to functionality. Uses existing unit tests.
    
    Closes #745
    
    Signed-off-by: William Hyun <wi...@apache.org>
---
 java/core/src/java/org/apache/orc/impl/StringHashTableDictionary.java | 2 --
 1 file changed, 2 deletions(-)

diff --git a/java/core/src/java/org/apache/orc/impl/StringHashTableDictionary.java b/java/core/src/java/org/apache/orc/impl/StringHashTableDictionary.java
index d962947..d940ef8 100644
--- a/java/core/src/java/org/apache/orc/impl/StringHashTableDictionary.java
+++ b/java/core/src/java/org/apache/orc/impl/StringHashTableDictionary.java
@@ -20,7 +20,6 @@ package org.apache.orc.impl;
 
 import java.io.IOException;
 import java.io.OutputStream;
-import java.util.Arrays;
 
 import org.apache.hadoop.io.Text;
 
@@ -196,7 +195,6 @@ public class StringHashTableDictionary implements Dictionary {
       }
     }
 
-    Arrays.fill(hashBuckets, null);
     hashBuckets = resizedHashBuckets;
   }