You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/05/19 21:12:11 UTC
[kudu-CR] kudu-2022 Fix nullptr access at GetLocalNetworks.
Hao Hao has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6931
Change subject: kudu-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
kudu-2022 Fix nullptr access at GetLocalNetworks.
GetLocalNetworks accesses member with nullptr when retrieves
local network interfaces, as both ifaddrs.ifa_addr and
ifaddrs.ifa_netmask fields can contain null pointer. This
patch checks if either of these fields is null before
accessing.
Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
---
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
2 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/6931/1
--
To view, visit http://gerrit.cloudera.org:8080/6931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] kudu-2022 Fix nullptr access at GetLocalNetworks.
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has abandoned this change.
Change subject: kudu-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/6931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] kudu-2022 Fix nullptr access at GetLocalNetworks.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: kudu-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
Patch Set 2:
(1 comment)
This isn't testable without mocking a response from getifaddrs(), right? Probably not worth it.
http://gerrit.cloudera.org:8080/#/c/6931/1//COMMIT_MSG
Commit Message:
Line 7: kudu-2022 Fix nullptr access at GetLocalNetworks.
Nit: KUDU-2022 (in caps)
--
To view, visit http://gerrit.cloudera.org:8080/6931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] kudu-2022 Fix nullptr access at GetLocalNetworks.
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6931
to look at the new patch set (#3).
Change subject: kudu-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
kudu-2022 Fix nullptr access at GetLocalNetworks.
GetLocalNetworks accesses member with nullptr when retrieves
local network interfaces, as both ifaddrs.ifa_addr and
ifaddrs.ifa_netmask fields can contain null pointer. This
patch checks if either of these fields is null before
accessing.
Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
---
D src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
2 files changed, 4 insertions(+), 164 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/6931/3
--
To view, visit http://gerrit.cloudera.org:8080/6931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] kudu-2022 Fix nullptr access at GetLocalNetworks.
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: kudu-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
Patch Set 3:
Will abandon this patch, as accidentally pushed undesired changed.
--
To view, visit http://gerrit.cloudera.org:8080/6931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] kudu-2022 Fix nullptr access at GetLocalNetworks.
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: kudu-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
Patch Set 2:
> (1 comment)
>
> This isn't testable without mocking a response from getifaddrs(),
> right? Probably not worth it.
Right... not sure what is an easy way to do so.
--
To view, visit http://gerrit.cloudera.org:8080/6931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] kudu-2022 Fix nullptr access at GetLocalNetworks.
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has uploaded a new patch set (#2).
Change subject: kudu-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
kudu-2022 Fix nullptr access at GetLocalNetworks.
GetLocalNetworks accesses member with nullptr when retrieves
local network interfaces, as both ifaddrs.ifa_addr and
ifaddrs.ifa_netmask fields can contain null pointer. This
patch checks if either of these fields is null before
accessing.
Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
---
M src/kudu/util/net/net_util.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/6931/2
--
To view, visit http://gerrit.cloudera.org:8080/6931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot