You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "fjpanag (via GitHub)" <gi...@apache.org> on 2023/01/29 15:01:38 UTC

[GitHub] [nuttx] fjpanag commented on a diff in pull request #8340: Fixed non-UTF characters.

fjpanag commented on code in PR #8340:
URL: https://github.com/apache/nuttx/pull/8340#discussion_r1089984250


##########
boards/arm/sama5/jupiter-nano/include/board_sdram.h:
##########
@@ -107,7 +107,7 @@
 
 #define BOARD_ADC_PRESCAL          (7)
 #define BOARD_TSD_STARTUP          (40)        /* 40 nanoseconds */
-#define BOARD_TSD_TRACKTIM         (2000)      /* Min 1�s at 8MHz */
+#define BOARD_TSD_TRACKTIM         (2000)      /* Min 1µs at 8MHz */
 #define BOARD_TSD_DEBOUNCE         (10000000)  /* 10 milliseconds (units nanoseconds) */

Review Comment:
   Generally this is my preference, as I believe that source code should only be ASCII.
   
   But when I raised this concern in the mailing list, it seems that people prefer to use such special symbols.
   
   What do you recommend me to do?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org