[GitHub] [druid] bjozet commented on a change in pull request #9372: Add config option for namespacePrefix

[GitBox <gi...@apache.org>]

bjozet commented on a change in pull request #9372: Add config option for namespacePrefix
URL: https://github.com/apache/druid/pull/9372#discussion_r380634727
 
 

 ##########
 File path: extensions-contrib/opentsdb-emitter/src/test/java/org/apache/druid/emitter/opentsdb/EventConverterTest.java
 ##########
 @@ -32,23 +32,29 @@
 
 public class EventConverterTest
 {
-  private EventConverter converter;
+  private EventConverter converterWithPrefix;
+  private EventConverter converterWithSpacePrefix;
+  private EventConverter converterWithoutPrefix;
 
   @Before
   public void setUp()
   {
-    converter = new EventConverter(new ObjectMapper(), null);
+    converterWithPrefix = new EventConverter(new ObjectMapper(), null, "druid");
+    converterWithSpacePrefix = new EventConverter(new ObjectMapper(), null, "legendary druid");
 
 Review comment:
   You're right, i'll rename the variable to `converterWithPrefixContainingSpace`, and add another test for `converterWithPrefixContainingEmptyString` ("").
   How does that sound?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org