You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jsai28 (via GitHub)" <gi...@apache.org> on 2025/04/04 23:45:08 UTC
[PR] Add disk usage limit configuration to datafusion-cli [datafusion]
jsai28 opened a new pull request, #15586:
URL: https://github.com/apache/datafusion/pull/15586
## Which issue does this PR close?
Closes #15553.
## Rationale for this change
Allows users to specify a disk limit for spill queries.
## What changes are included in this PR?
A CLI option for users to specify a disk limit.
## Are these changes tested?
## Are there any user-facing changes?
Yes, new CLI option in `datafusion-cli`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add disk usage limit configuration to datafusion-cli [datafusion]
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 merged PR #15586:
URL: https://github.com/apache/datafusion/pull/15586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add disk usage limit configuration to datafusion-cli [datafusion]
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on code in PR #15586:
URL: https://github.com/apache/datafusion/pull/15586#discussion_r2029691057
##########
docs/source/user-guide/cli/usage.md:
##########
@@ -57,6 +57,9 @@ OPTIONS:
--mem-pool-type <MEM_POOL_TYPE>
Specify the memory pool type 'greedy' or 'fair', default to 'greedy'
+ -d, --disk-limit <DISK_LIMIT>
+ Available disk space for spilling queries (e.g. '10g'), default to None (no limit)
Review Comment:
```suggestion
Available disk space for spilling queries (e.g. '10g'), default to None (use DataFusion's default value of '100g')
```
##########
datafusion-cli/src/main.rs:
##########
@@ -125,6 +127,14 @@ struct Args {
#[clap(long, help = "Enables console syntax highlighting")]
color: bool,
+
+ #[clap(
+ short = 'd',
+ long,
+ help = "Available disk space for spilling queries (e.g. '10g'), default to None (no limit)",
Review Comment:
```suggestion
help = "Available disk space for spilling queries (e.g. '10g'), default to None (use DataFusion's default value of '100g')",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add disk usage limit configuration to datafusion-cli [datafusion]
Posted by "jsai28 (via GitHub)" <gi...@apache.org>.
jsai28 commented on code in PR #15586:
URL: https://github.com/apache/datafusion/pull/15586#discussion_r2029700750
##########
datafusion-cli/src/main.rs:
##########
@@ -125,6 +127,14 @@ struct Args {
#[clap(long, help = "Enables console syntax highlighting")]
color: bool,
+
+ #[clap(
+ short = 'd',
+ long,
+ help = "Available disk space for spilling queries (e.g. '10g'), default to None (no limit)",
Review Comment:
updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org