You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/08/15 07:00:42 UTC

Review Request 61646: Added a test to verify a fix for MESOS-7863.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61646/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-7863
    https://issues.apache.org/jira/browse/MESOS-7863


Repository: mesos


Description
-------

This test ensures that the agent does not drop the TASK_KILLED
update when all pending tasks from a framework are killed.
See MESOS-7863 for the motivating issue.


Diffs
-----

  src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160 


Diff: https://reviews.apache.org/r/61646/diff/1/


Testing
-------

Ran in repetition.


Thanks,

Benjamin Mahler

Re: Review Request 61646: Added a test to verify a fix for MESOS-7863.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61646/#review183549
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/slave_tests.cpp
Lines 4075-4076 (patched)
<https://reviews.apache.org/r/61646/#comment259571>

    you should get this even before `__run` right? if so, can you move this up before `__run`?



src/tests/slave_tests.cpp
Lines 4081-4082 (patched)
<https://reviews.apache.org/r/61646/#comment259572>

    ditto.


- Vinod Kone


On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61646/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 7 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7863
>     https://issues.apache.org/jira/browse/MESOS-7863
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test ensures that the agent does not drop the TASK_KILLED
> update when all pending tasks from a framework are killed.
> See MESOS-7863 for the motivating issue.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160 
> 
> 
> Diff: https://reviews.apache.org/r/61646/diff/1/
> 
> 
> Testing
> -------
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>