You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/22 17:46:31 UTC
[GitHub] [arrow-rs] alamb opened a new issue #1086: implement `eq_dyn`, `neq_dyn`, `lt_dyn`, `lt_eq_dyn`, `gt_dyn`, `gt_eq_dyn` for timestamp types
alamb opened a new issue #1086:
URL: https://github.com/apache/arrow-rs/issues/1086
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
We are tryng to use the new dynamic comparison kernels added in https://github.com/apache/arrow-rs/pull/858 by @Jimexist
in DataFusion: https://github.com/apache/arrow-datafusion/pull/1475
It turns out that Datafusion also supports operations on the timestamp / time arrays as well so we can't use the dynamic kernels (yet)
**Describe the solution you'd like**
Add support for the following types to `eq_dyn`, `neq_dyn`, `lt_dyn`, `lt_eq_dyn`, `gt_dyn`, `gt_eq_dyn` (there is one macro needed):
```
DataType::Timestamp(TimeUnit::Nanosecond, _) => {
DataType::Timestamp(TimeUnit::Microsecond, _) => {
DataType::Timestamp(TimeUnit::Millisecond, _) => {
DataType::Timestamp(TimeUnit::Second, _) => {
DataType::Date32 => {
DataType::Date64 => {
```
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb closed issue #1086: implement `eq_dyn`, `neq_dyn`, `lt_dyn`, `lt_eq_dyn`, `gt_dyn`, `gt_eq_dyn` for timestamp types
Posted by GitBox <gi...@apache.org>.
alamb closed issue #1086:
URL: https://github.com/apache/arrow-rs/issues/1086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #1086: implement `eq_dyn`, `neq_dyn`, `lt_dyn`, `lt_eq_dyn`, `gt_dyn`, `gt_eq_dyn` for timestamp types
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1086:
URL: https://github.com/apache/arrow-rs/issues/1086#issuecomment-999758851
I think this could be accomplished by implementing the appropriate types in `macro_rules! typed_compares {` in https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/comparison.rs#L1109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org