You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "zhfeng (via GitHub)" <gi...@apache.org> on 2023/02/17 15:19:57 UTC
[GitHub] [camel] zhfeng opened a new pull request, #9374: CAMEL-19065: camel-kafka - deserialize SAGA_LONG_RUNNING_ACTION header
zhfeng opened a new pull request, #9374:
URL: https://github.com/apache/camel/pull/9374
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9374: CAMEL-19065: camel-kafka - Add KafkaSagaIT test
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1436762773
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9374: CAMEL-19065: camel-kafka - Add KafkaSagaIT test
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1439495246
Now it's just an it test. Good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9374: CAMEL-19065: camel-kafka - deserialize SAGA_LONG_RUNNING_ACTION header
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1434859917
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zhfeng commented on pull request #9374: CAMEL-19065: camel-kafka - deserialize SAGA_LONG_RUNNING_ACTION header
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1436539533
Hmm, I added a `KafkaSagaIT` test and it works. After debugging, it looks like
https://github.com/apache/camel/blob/f955a62d128804b45791d4f7e40b58ead58c866b/core/camel-base/src/generated/java/org/apache/camel/converter/CamelBaseBulkConverterLoader.java#L329-L331
which does this `byte[]` to `String` convertion.
Anyway the reproducer https://github.com/codependent/booking-service is based on `camel-spring-boot`, so it might be some issues there and I will keep investigating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9374: CAMEL-19065: camel-kafka - Add KafkaSagaIT test
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1437254472
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zhfeng commented on pull request #9374: CAMEL-19065: camel-kafka - deserialize SAGA_LONG_RUNNING_ACTION header
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1436279151
For `camel-jms`, it seems that it allows `String` as a value. So I think it should be OK in propagating the `SAGA_LONG_RUNNING_ACTION`
https://github.com/apache/camel/blob/f955a62d128804b45791d4f7e40b58ead58c866b/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsBinding.java#L489-L491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #9374: CAMEL-19065: camel-kafka - Add KafkaSagaIT test
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #9374:
URL: https://github.com/apache/camel/pull/9374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9374: CAMEL-19065: camel-kafka - Add KafkaSagaIT test
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1436630457
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zhfeng commented on pull request #9374: CAMEL-19065: camel-kafka - Add KafkaSagaIT test
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1436786297
@davsclaus How to make sure such a `Converter` is also available for `camel-spring-boot`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9374: CAMEL-19065: camel-kafka - deserialize SAGA_LONG_RUNNING_ACTION header
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1434795439
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9374: CAMEL-19065: camel-kafka - deserialize SAGA_LONG_RUNNING_ACTION header
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1434953243
Hmm so there is a a special for this in camel-kafka - I dont like that, what about camel-jms and so on.
Does kafka not just store the header as-is, eg a byte[]. And if so can you not just in camel-saga convert the header to a String in case its byte[] or something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zhfeng commented on pull request #9374: CAMEL-19065: camel-kafka - Add KafkaSagaIT test
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #9374:
URL: https://github.com/apache/camel/pull/9374#issuecomment-1437023578
`camel-spring-boot` also should work. There is an isue in the reproducer https://github.com/codependent/booking-service and it needs to use
```java
log("LRA id is \${headers.Long-Running-Action}")
```
to convert it to `String` explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org