You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/04/20 11:35:40 UTC
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2268
[ZEPPELIN-2403] interpreter property widgets
### What is this PR for?
I spoiled the previous PR #2251
Added widgets (string, text, url, password, url, checkbox) to properties of interpreters. Those are widgets for properties customization. Properties must have the ability to customize the display (for example password).
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2403
### How should this be tested?
- remove conf/interpreter.json
- Try new form (create, edit) of interpreter settings
### Screenshots (if appropriate)
edit
view
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2268
----
commit 45f5f6276d731084b3873cb1885f684ab1449e68
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-14T07:44:29Z
ZEPPELIN-2403 added interpreter property types
commit 12499ae1ef7d329c7f3e74b4298031cfe4b9c490
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:01:39Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/install/upgrade.md
commit 14353b1200443582b1fceafabce0e82cdf83a054
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:02:01Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit dd5d6c809aeb2bdb72357a072954cf4a9c882487
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:38:59Z
ZEPPELIN-2403 did properties immutable, added new type 'checkbox'
commit 4f271d9b03a1748d83fefdf290abbba68d3cd280
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-18T12:16:00Z
ZEPPELIN-2403 rename to widget added new widgets string, number, url
commit fd8d27810cfc004216c8ea61ea7fe5d06aa9bde2
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:42:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403_backup
# Conflicts:
# zeppelin-web/src/app/interpreter/interpreter.controller.js
# zeppelin-web/src/index.js
commit a495137ffccd7d88adb9593ada3cff2cb6e10698
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:49:24Z
ZEPPELIN-2403 eslint fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
As far as I Know, Zeppelin supports backward compatibility even for interpreter settings.
- I think we need some migration code w/ documentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
1. number, string and url can be generalized as `text`. For url, we can use `ng-html` with angular's `$sse` service to draw `<a>..</a>` element
2. if `text` widget means `textarea` DOM, can we change it to `textarea` instead of?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
looks good. initially, the idea with the type well, as the type indicated the type of the stored value (widget is pointing to), but **password** all broke)
@1ambda
what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2268
[ZEPPELIN-2403] interpreter property widgets
### What is this PR for?
I spoiled the previous PR #2251
Added widgets (string, text, url, password, url, checkbox) to properties of interpreters. Those are widgets for properties customization. Properties must have the ability to customize the display (for example password).
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2403
### How should this be tested?
- remove conf/interpreter.json
- Try new form (create, edit) of interpreter settings
### Screenshots (if appropriate)
edit
view
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2268
----
commit 45f5f6276d731084b3873cb1885f684ab1449e68
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-14T07:44:29Z
ZEPPELIN-2403 added interpreter property types
commit 12499ae1ef7d329c7f3e74b4298031cfe4b9c490
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:01:39Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/install/upgrade.md
commit 14353b1200443582b1fceafabce0e82cdf83a054
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:02:01Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit dd5d6c809aeb2bdb72357a072954cf4a9c882487
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:38:59Z
ZEPPELIN-2403 did properties immutable, added new type 'checkbox'
commit 4f271d9b03a1748d83fefdf290abbba68d3cd280
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-18T12:16:00Z
ZEPPELIN-2403 rename to widget added new widgets string, number, url
commit fd8d27810cfc004216c8ea61ea7fe5d06aa9bde2
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:42:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403_backup
# Conflicts:
# zeppelin-web/src/app/interpreter/interpreter.controller.js
# zeppelin-web/src/index.js
commit a495137ffccd7d88adb9593ada3cff2cb6e10698
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:49:24Z
ZEPPELIN-2403 eslint fix
commit 07160e00eb294f9962b7b4c1bc738c1e7788c870
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:40:36Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit e92713c72f41e9c1be2fd85bcc8a4ca35f4b5810
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:44:26Z
[ZEPPELIN-2403] generalized types, added new types
commit 637cb0a155d5e4d525c74f95744a4e9a2edb023d
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-28T10:44:11Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit b41e7a3f19ea982f67d7a0d5fc6570a31ae37467
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-01T16:47:50Z
ZEPPELIN-2403 checkstyle
commit 76a9808307e53040a60c01eb5099d9fbe627c520
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T04:24:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403
commit c6d24c4c35b51628fd1de1f37e0135c4ac8b3e5c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:11:07Z
[ZEPPELIN-2403] converter for old settings to new (with widgets)
commit f735c0a9465390b4a083de32719962004d2247b6
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:51:35Z
[ZEPPELIN-2403] fix test
commit 99daca6d5892c3485162734520470186f128afec
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T09:01:32Z
[ZEPPELIN-2403] fix rest api test
commit ca1e2bf7602bb21e410e9e4fe6b7ad41f157163b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-15T08:14:45Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit 10ce996a10d19805dba1c1968678f2f72726e1fe
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-22T11:32:13Z
[ZEPPELIN-2403] merge widget and type
commit 7c25b6db825f7600bbb4211ba0b34b6091468294
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:45:38Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit e35ff58f96600a02c6d60e869425a916564b878b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:55:15Z
[ZEPPELIN-2403] fix checkstyle
commit fd25c467ac10763fcbb40995b735662ddae9e102
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T02:26:34Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
commit a5f1327243d25cb3963de0790e3d3e1fa37d23ff
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T03:38:21Z
[ZEPPELIN-2403] checkstyle fix
commit 098fbd140e43e365f6b2171cb034cefc10a4ad9c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-24T10:53:56Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/setup/operation/upgrading.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
Ready to review :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@Leemoonsoo
first three comments
...
I think it's not complicated. IMO, it's the part we should design carefully since it's hard to change (backward compatibility)
...
widget means UI, and type defines their actual value types. Sometime they might be mixed together, but usually not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
Let me review and comment soon for this awesome improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
I am not a big fan of this approach. But reviewers discussed and I partially agree in terms of complexity.
I will check few things since it was quite old when I last reviewed this,
Then if it's good will merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@tinkoff-dwh Please resolve conflict.
Usually, we merge after 1 day when someone left LGTM, but this time, conflict occurred before 1 day.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
One example of separating widget with value types.
```
// https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/tabledata/advanced-transformation-util.test.js#L19-L25
const MockParameter = {
'floatParam': { valueType: 'float', defaultValue: 10, description: '', },
'intParam': { valueType: 'int', defaultValue: 50, description: '', },
'jsonParam': { valueType: 'JSON', defaultValue: '', description: '', widget: 'textarea', },
'stringParam1': { valueType: 'string', defaultValue: '', description: '', },
'stringParam2': { valueType: 'string', defaultValue: '', description: '', widget: 'input', },
'boolParam': { valueType: 'boolean', defaultValue: false, description: '', widget: 'checkbox', },
'optionParam': { valueType: 'string', defaultValue: 'line', description: '', widget: 'option', optionValues: [ 'line', 'smoothedLine', ], },
}
```
1. In case of password, value type will be decided by its definition. If it's number, we can validate it as number. (string as well)
2. In case of combobox, type will be boolean.
3. We can parse values based on their type like https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/tabledata/advanced-transformation-util.js#L85-#L117
4. I think it's not complicated. IMO, it's the part we should design carefully since it's hard to change (backward compatibility)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@1ambda
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@tinkoff-dwh Let me take a look!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@1ambda
i wrote about migration in upgrade.md. I'll see Notebook.java if the documentation is not enough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@Leemoonsoo
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2268
[ZEPPELIN-2403] interpreter property widgets
### What is this PR for?
I spoiled the previous PR #2251
Added widgets (string, text, url, password, url, checkbox) to properties of interpreters. Those are widgets for properties customization. Properties must have the ability to customize the display (for example password).
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2403
### How should this be tested?
- remove conf/interpreter.json
- Try new form (create, edit) of interpreter settings
### Screenshots (if appropriate)
edit
view
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2268
----
commit 45f5f6276d731084b3873cb1885f684ab1449e68
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-14T07:44:29Z
ZEPPELIN-2403 added interpreter property types
commit 12499ae1ef7d329c7f3e74b4298031cfe4b9c490
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:01:39Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/install/upgrade.md
commit 14353b1200443582b1fceafabce0e82cdf83a054
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:02:01Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit dd5d6c809aeb2bdb72357a072954cf4a9c882487
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:38:59Z
ZEPPELIN-2403 did properties immutable, added new type 'checkbox'
commit 4f271d9b03a1748d83fefdf290abbba68d3cd280
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-18T12:16:00Z
ZEPPELIN-2403 rename to widget added new widgets string, number, url
commit fd8d27810cfc004216c8ea61ea7fe5d06aa9bde2
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:42:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403_backup
# Conflicts:
# zeppelin-web/src/app/interpreter/interpreter.controller.js
# zeppelin-web/src/index.js
commit a495137ffccd7d88adb9593ada3cff2cb6e10698
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:49:24Z
ZEPPELIN-2403 eslint fix
commit 07160e00eb294f9962b7b4c1bc738c1e7788c870
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:40:36Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit e92713c72f41e9c1be2fd85bcc8a4ca35f4b5810
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:44:26Z
[ZEPPELIN-2403] generalized types, added new types
commit 637cb0a155d5e4d525c74f95744a4e9a2edb023d
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-28T10:44:11Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit b41e7a3f19ea982f67d7a0d5fc6570a31ae37467
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-01T16:47:50Z
ZEPPELIN-2403 checkstyle
commit 76a9808307e53040a60c01eb5099d9fbe627c520
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T04:24:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403
commit c6d24c4c35b51628fd1de1f37e0135c4ac8b3e5c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:11:07Z
[ZEPPELIN-2403] converter for old settings to new (with widgets)
commit f735c0a9465390b4a083de32719962004d2247b6
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:51:35Z
[ZEPPELIN-2403] fix test
commit 99daca6d5892c3485162734520470186f128afec
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T09:01:32Z
[ZEPPELIN-2403] fix rest api test
commit ca1e2bf7602bb21e410e9e4fe6b7ad41f157163b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-15T08:14:45Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit 10ce996a10d19805dba1c1968678f2f72726e1fe
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-22T11:32:13Z
[ZEPPELIN-2403] merge widget and type
commit 7c25b6db825f7600bbb4211ba0b34b6091468294
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:45:38Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit e35ff58f96600a02c6d60e869425a916564b878b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:55:15Z
[ZEPPELIN-2403] fix checkstyle
commit fd25c467ac10763fcbb40995b735662ddae9e102
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T02:26:34Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
commit a5f1327243d25cb3963de0790e3d3e1fa37d23ff
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T03:38:21Z
[ZEPPELIN-2403] checkstyle fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@1ambda
I think it's too complicate code, for example generate list (combobox) of widgets. How will the selection of the type of the password, second combobox?. I see no reason to generalize number, string and url.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2268
If i list all combinations of widget-type in this PR,
| widget | type |
| ------------- | ------------- |
| input | **string** |
| input | **number** |
| **textarea** | string |
| **password** | password |
| **checkbox** | boolean |
| input | **url** |
As we can see, each combination can be uniquely identified by either widget or type. (bold font)
Unless there's big plan in the future add a lot of combinations of those, i think just keeping one field 'type' is enough to identify all possible combinations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2268
[ZEPPELIN-2403] interpreter property widgets
### What is this PR for?
I spoiled the previous PR #2251
Added widgets (string, text, url, password, url, checkbox) to properties of interpreters. Those are widgets for properties customization. Properties must have the ability to customize the display (for example password).
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2403
### How should this be tested?
- remove conf/interpreter.json
- Try new form (create, edit) of interpreter settings
### Screenshots (if appropriate)
edit
view
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2268
----
commit 45f5f6276d731084b3873cb1885f684ab1449e68
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-14T07:44:29Z
ZEPPELIN-2403 added interpreter property types
commit 12499ae1ef7d329c7f3e74b4298031cfe4b9c490
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:01:39Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/install/upgrade.md
commit 14353b1200443582b1fceafabce0e82cdf83a054
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:02:01Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit dd5d6c809aeb2bdb72357a072954cf4a9c882487
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:38:59Z
ZEPPELIN-2403 did properties immutable, added new type 'checkbox'
commit 4f271d9b03a1748d83fefdf290abbba68d3cd280
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-18T12:16:00Z
ZEPPELIN-2403 rename to widget added new widgets string, number, url
commit fd8d27810cfc004216c8ea61ea7fe5d06aa9bde2
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:42:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403_backup
# Conflicts:
# zeppelin-web/src/app/interpreter/interpreter.controller.js
# zeppelin-web/src/index.js
commit a495137ffccd7d88adb9593ada3cff2cb6e10698
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:49:24Z
ZEPPELIN-2403 eslint fix
commit 07160e00eb294f9962b7b4c1bc738c1e7788c870
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:40:36Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit e92713c72f41e9c1be2fd85bcc8a4ca35f4b5810
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:44:26Z
[ZEPPELIN-2403] generalized types, added new types
commit 637cb0a155d5e4d525c74f95744a4e9a2edb023d
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-28T10:44:11Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit b41e7a3f19ea982f67d7a0d5fc6570a31ae37467
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-01T16:47:50Z
ZEPPELIN-2403 checkstyle
commit 76a9808307e53040a60c01eb5099d9fbe627c520
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T04:24:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403
commit c6d24c4c35b51628fd1de1f37e0135c4ac8b3e5c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:11:07Z
[ZEPPELIN-2403] converter for old settings to new (with widgets)
commit f735c0a9465390b4a083de32719962004d2247b6
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:51:35Z
[ZEPPELIN-2403] fix test
commit 99daca6d5892c3485162734520470186f128afec
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T09:01:32Z
[ZEPPELIN-2403] fix rest api test
commit ca1e2bf7602bb21e410e9e4fe6b7ad41f157163b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-15T08:14:45Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit 10ce996a10d19805dba1c1968678f2f72726e1fe
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-22T11:32:13Z
[ZEPPELIN-2403] merge widget and type
commit 7c25b6db825f7600bbb4211ba0b34b6091468294
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:45:38Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit e35ff58f96600a02c6d60e869425a916564b878b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:55:15Z
[ZEPPELIN-2403] fix checkstyle
commit fd25c467ac10763fcbb40995b735662ddae9e102
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T02:26:34Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
commit a5f1327243d25cb3963de0790e3d3e1fa37d23ff
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T03:38:21Z
[ZEPPELIN-2403] checkstyle fix
commit 098fbd140e43e365f6b2171cb034cefc10a4ad9c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-24T10:53:56Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/setup/operation/upgrading.md
commit b17dfb592d4cfd5ac8d23b80add631659d8c66ca
Author: isys.mreshetov <m....@i-sys.ru>
Date: 2017-06-29T07:47:35Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@Leemoonsoo
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
CI red (checkstyle errors in all modules)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2268
> the separation discussed above in the comments
maybe i missed, @tinkoff-dwh could you point out the comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2268
[ZEPPELIN-2403] interpreter property widgets
### What is this PR for?
I spoiled the previous PR #2251
Added widgets (string, text, url, password, url, checkbox) to properties of interpreters. Those are widgets for properties customization. Properties must have the ability to customize the display (for example password).
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2403
### How should this be tested?
- remove conf/interpreter.json
- Try new form (create, edit) of interpreter settings
### Screenshots (if appropriate)
edit
view
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2268
----
commit 45f5f6276d731084b3873cb1885f684ab1449e68
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-14T07:44:29Z
ZEPPELIN-2403 added interpreter property types
commit 12499ae1ef7d329c7f3e74b4298031cfe4b9c490
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:01:39Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/install/upgrade.md
commit 14353b1200443582b1fceafabce0e82cdf83a054
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:02:01Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit dd5d6c809aeb2bdb72357a072954cf4a9c882487
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:38:59Z
ZEPPELIN-2403 did properties immutable, added new type 'checkbox'
commit 4f271d9b03a1748d83fefdf290abbba68d3cd280
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-18T12:16:00Z
ZEPPELIN-2403 rename to widget added new widgets string, number, url
commit fd8d27810cfc004216c8ea61ea7fe5d06aa9bde2
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:42:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403_backup
# Conflicts:
# zeppelin-web/src/app/interpreter/interpreter.controller.js
# zeppelin-web/src/index.js
commit a495137ffccd7d88adb9593ada3cff2cb6e10698
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:49:24Z
ZEPPELIN-2403 eslint fix
commit 07160e00eb294f9962b7b4c1bc738c1e7788c870
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:40:36Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit e92713c72f41e9c1be2fd85bcc8a4ca35f4b5810
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:44:26Z
[ZEPPELIN-2403] generalized types, added new types
commit 637cb0a155d5e4d525c74f95744a4e9a2edb023d
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-28T10:44:11Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit b41e7a3f19ea982f67d7a0d5fc6570a31ae37467
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-01T16:47:50Z
ZEPPELIN-2403 checkstyle
commit 76a9808307e53040a60c01eb5099d9fbe627c520
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T04:24:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403
commit c6d24c4c35b51628fd1de1f37e0135c4ac8b3e5c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:11:07Z
[ZEPPELIN-2403] converter for old settings to new (with widgets)
commit f735c0a9465390b4a083de32719962004d2247b6
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:51:35Z
[ZEPPELIN-2403] fix test
commit 99daca6d5892c3485162734520470186f128afec
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T09:01:32Z
[ZEPPELIN-2403] fix rest api test
commit ca1e2bf7602bb21e410e9e4fe6b7ad41f157163b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-15T08:14:45Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit 10ce996a10d19805dba1c1968678f2f72726e1fe
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-22T11:32:13Z
[ZEPPELIN-2403] merge widget and type
commit 7c25b6db825f7600bbb4211ba0b34b6091468294
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:45:38Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit e35ff58f96600a02c6d60e869425a916564b878b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:55:15Z
[ZEPPELIN-2403] fix checkstyle
commit fd25c467ac10763fcbb40995b735662ddae9e102
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T02:26:34Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
commit a5f1327243d25cb3963de0790e3d3e1fa37d23ff
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T03:38:21Z
[ZEPPELIN-2403] checkstyle fix
commit 098fbd140e43e365f6b2171cb034cefc10a4ad9c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-24T10:53:56Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/setup/operation/upgrading.md
commit b17dfb592d4cfd5ac8d23b80add631659d8c66ca
Author: isys.mreshetov <m....@i-sys.ru>
Date: 2017-06-29T07:47:35Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit 726c1f31fe65ab2e599b8426cff8a0fe0dbe3f13
Author: isys.mreshetov <m....@i-sys.ru>
Date: 2017-06-29T09:32:38Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# pig/src/main/resources/interpreter-setting.json
commit 4b63399371272f029924f819d8c7025c56ca921d
Author: isys.mreshetov <m....@i-sys.ru>
Date: 2017-07-03T08:13:33Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# bigquery/src/main/resources/interpreter-setting.json
commit 585fc3644cea19ee7e55c067829a414fa651d249
Author: isys.mreshetov <m....@i-sys.ru>
Date: 2017-07-03T08:13:57Z
ZEPPELIN-2403 documentation fix
commit 7be8ddffabb65181a53067a3364c986180589f9f
Author: isys.mreshetov <m....@i-sys.ru>
Date: 2017-07-05T04:04:40Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# zeppelin-server/src/main/java/org/apache/zeppelin/rest/InterpreterRestApi.java
# zeppelin-server/src/main/java/org/apache/zeppelin/rest/message/UpdateInterpreterSettingRequest.java
# zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/InterpreterFactoryTest.java
commit 75a104644feefb147b4fef8e93f646ee59199b5c
Author: isys.mreshetov <m....@i-sys.ru>
Date: 2017-07-05T04:08:30Z
ZEPPELIN-2403 imports fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
LGTM, merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
1. Please resolve the conflict.
2. Left a minor comment please check that.
3. Tested locally and works well with 6 newly added types.
4. Backward compatibility will be handed by the `convertFlatPropertiesToPropertiesWithWidgets` func (check interpreter config and convert old format to new format)
After 1, 2 are resolved, merge it if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
1,2 done
@1ambda thx for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
Sorry for the late review.
seems that it doesn't work with existing settings. Even can't start Zeppelin instance.
```
Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to com.google.gson.internal.StringMap
at org.apache.zeppelin.interpreter.InterpreterSettingManager.loadFromFile(InterpreterSettingManager.java:174)
at org.apache.zeppelin.interpreter.InterpreterSettingManager.init(InterpreterSettingManager.java:345)
at org.apache.zeppelin.interpreter.InterpreterSettingManager.<init>(InterpreterSettingManager.java:150)
at org.apache.zeppelin.server.ZeppelinServer.<init>(ZeppelinServer.java:149)
... 29 more
```
- It would be nicer to provide migration function like https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java#L418
- or use the default type / widget if a field doens't have (e.g `string`, `input`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2268
[ZEPPELIN-2403] interpreter property widgets
### What is this PR for?
I spoiled the previous PR #2251
Added widgets (string, text, url, password, url, checkbox) to properties of interpreters. Those are widgets for properties customization. Properties must have the ability to customize the display (for example password).
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2403
### How should this be tested?
- remove conf/interpreter.json
- Try new form (create, edit) of interpreter settings
### Screenshots (if appropriate)
edit
view
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2268
----
commit 45f5f6276d731084b3873cb1885f684ab1449e68
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-14T07:44:29Z
ZEPPELIN-2403 added interpreter property types
commit 12499ae1ef7d329c7f3e74b4298031cfe4b9c490
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:01:39Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/install/upgrade.md
commit 14353b1200443582b1fceafabce0e82cdf83a054
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:02:01Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit dd5d6c809aeb2bdb72357a072954cf4a9c882487
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-17T08:38:59Z
ZEPPELIN-2403 did properties immutable, added new type 'checkbox'
commit 4f271d9b03a1748d83fefdf290abbba68d3cd280
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-18T12:16:00Z
ZEPPELIN-2403 rename to widget added new widgets string, number, url
commit fd8d27810cfc004216c8ea61ea7fe5d06aa9bde2
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:42:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403_backup
# Conflicts:
# zeppelin-web/src/app/interpreter/interpreter.controller.js
# zeppelin-web/src/index.js
commit a495137ffccd7d88adb9593ada3cff2cb6e10698
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-20T10:49:24Z
ZEPPELIN-2403 eslint fix
commit 07160e00eb294f9962b7b4c1bc738c1e7788c870
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:40:36Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit e92713c72f41e9c1be2fd85bcc8a4ca35f4b5810
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-27T10:44:26Z
[ZEPPELIN-2403] generalized types, added new types
commit 637cb0a155d5e4d525c74f95744a4e9a2edb023d
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-28T10:44:11Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit b41e7a3f19ea982f67d7a0d5fc6570a31ae37467
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-01T16:47:50Z
ZEPPELIN-2403 checkstyle
commit 76a9808307e53040a60c01eb5099d9fbe627c520
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T04:24:05Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403
commit c6d24c4c35b51628fd1de1f37e0135c4ac8b3e5c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:11:07Z
[ZEPPELIN-2403] converter for old settings to new (with widgets)
commit f735c0a9465390b4a083de32719962004d2247b6
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T06:51:35Z
[ZEPPELIN-2403] fix test
commit 99daca6d5892c3485162734520470186f128afec
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-11T09:01:32Z
[ZEPPELIN-2403] fix rest api test
commit ca1e2bf7602bb21e410e9e4fe6b7ad41f157163b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-15T08:14:45Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
commit 10ce996a10d19805dba1c1968678f2f72726e1fe
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-05-22T11:32:13Z
[ZEPPELIN-2403] merge widget and type
commit 7c25b6db825f7600bbb4211ba0b34b6091468294
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:45:38Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
commit e35ff58f96600a02c6d60e869425a916564b878b
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-07T18:55:15Z
[ZEPPELIN-2403] fix checkstyle
commit fd25c467ac10763fcbb40995b735662ddae9e102
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T02:26:34Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
# zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
commit a5f1327243d25cb3963de0790e3d3e1fa37d23ff
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-23T03:38:21Z
[ZEPPELIN-2403] checkstyle fix
commit 098fbd140e43e365f6b2171cb034cefc10a4ad9c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-06-24T10:53:56Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403
# Conflicts:
# docs/setup/operation/upgrading.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2268
IMO, It's ok if we are not going to add other types like `JSON` which can be `type` and used for other widgets (e.g `textarea`, ...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2268
This PR adds two new field 'widget' and 'type' to each properties.
'widget' : input, checkbox, textarea, password
'type' : number, string, boolean, url, password
How about just add single field 'type' with possible values "string"(input), "number", "url", "password", "checkbox", "text"(textarea) ?
@1ambda mentioned about backward compatibility. It'll help users who upgrade Zeppelin, if this PR reads `conf/interpreter.json` generated by previous version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
CI red https://travis-ci.org/tinkoff-dwh/zeppelin/builds/231079773
another tests
SecurityRestApiTest.testGetUserList:69 » JsonSyntax java.lang.IllegalStateExce...
SecurityRestApiTest.testTicket:55 » JsonSyntax java.lang.IllegalStateException...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@Leemoonsoo
the separation discussed above in the comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2268
@Leemoonsoo @1ambda
maybe merge? 2 month :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---