You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by db...@apache.org on 2012/02/14 19:22:53 UTC

svn commit: r1244144 - /openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java

Author: dblevins
Date: Tue Feb 14 18:22:53 2012
New Revision: 1244144

URL: http://svn.apache.org/viewvc?rev=1244144&view=rev
Log:
these can be "name" now rather than "lookup"

Modified:
    openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java

Modified: openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java?rev=1244144&r1=1244143&r2=1244144&view=diff
==============================================================================
--- openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java (original)
+++ openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java Tue Feb 14 18:22:53 2012
@@ -89,8 +89,8 @@ public class DataSourceDefinitionTest {
     })
     @Stateless
     public static class DatasourceDefinitionsBean {
-        @Resource(lookup = "java:comp/env/superMegaDS") private DataSource mega;
-        @Resource(lookup = "java:comp/env/superGigaDS") private DataSource giga;
+        @Resource(name = "java:comp/env/superMegaDS") private DataSource mega;
+        @Resource(name = "java:comp/env/superGigaDS") private DataSource giga;
 
         public DataSource getMega() {
             return mega;

Fwd: svn commit: r1244144 - /openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java

Posted by Romain Manni-Bucau <rm...@gmail.com>.
this test was testing lookup attribute.

if you rename it name simply remove the test.

- Romain


---------- Forwarded message ----------
From: <db...@apache.org>
Date: 2012/2/14
Subject: svn commit: r1244144 -
/openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java
To: commits@openejb.apache.org


Author: dblevins
Date: Tue Feb 14 18:22:53 2012
New Revision: 1244144

URL: http://svn.apache.org/viewvc?rev=1244144&view=rev
Log:
these can be "name" now rather than "lookup"

Modified:

 openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java

Modified:
openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java
URL:
http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java?rev=1244144&r1=1244143&r2=1244144&view=diff
==============================================================================
---
openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java
(original)
+++
openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionTest.java
Tue Feb 14 18:22:53 2012
@@ -89,8 +89,8 @@ public class DataSourceDefinitionTest {
    })
    @Stateless
    public static class DatasourceDefinitionsBean {
-        @Resource(lookup = "java:comp/env/superMegaDS") private DataSource
mega;
-        @Resource(lookup = "java:comp/env/superGigaDS") private DataSource
giga;
+        @Resource(name = "java:comp/env/superMegaDS") private DataSource
mega;
+        @Resource(name = "java:comp/env/superGigaDS") private DataSource
giga;

        public DataSource getMega() {
            return mega;