[jira] [Commented] (HBASE-12517) Several HConstant members are assignable

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216532#comment-14216532 ] 

Sean Busbey commented on HBASE-12517:
-------------------------------------

Current list:
{code}
 HBASE_CLIENT_SCANNER_MAX_RESULT_SIZE_KEY 
 DEFAULT_HBASE_CLIENT_SCANNER_MAX_RESULT_SIZE 
 HBASE_CLIENT_PAUSE 
 DEFAULT_HBASE_CLIENT_PAUSE 
 HBASE_SERVER_PAUSE 
 DEFAULT_HBASE_SERVER_PAUSE 
 HBASE_CLIENT_RETRIES_NUMBER 
 DEFAULT_HBASE_CLIENT_RETRIES_NUMBER 
 HBASE_CLIENT_SCANNER_CACHING 
 DEFAULT_HBASE_CLIENT_SCANNER_CACHING 
 HBASE_META_SCANNER_CACHING 
 DEFAULT_HBASE_META_SCANNER_CACHING 
 HBASE_META_VERSIONS 
 DEFAULT_HBASE_META_VERSIONS 
 HBASE_META_BLOCK_SIZE 
 DEFAULT_HBASE_META_BLOCK_SIZE 
 HBASE_CLIENT_INSTANCE_ID 
 HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD 
 HBASE_REGIONSERVER_LEASE_PERIOD_KEY 
 DEFAULT_HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD 
 HBASE_RPC_TIMEOUT_KEY 
 DEFAULT_HBASE_RPC_TIMEOUT 
 HBASE_RPC_SHORTOPERATION_TIMEOUT_KEY 
 DEFAULT_HBASE_RPC_SHORTOPERATION_TIMEOUT 
 HBASE_RS_NONCES_ENABLED 
{code}


> Several HConstant members are assignable
> ----------------------------------------
>
>                 Key: HBASE-12517
>                 URL: https://issues.apache.org/jira/browse/HBASE-12517
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sean Busbey
>            Priority: Critical
>              Labels: beginner, checkstyle
>
> Several of the members in HConstants are not marked final.
> Generate up-to-date list with command:
> 0.98+
> {code}
> for line in "`grep -e '^ *public' hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java | grep -v final`"; do echo "${line}" | grep -o -e " [A-Z_][A-Z_]* "; done
> {code}
> 0.94:
> {code}
> for line in "`grep -e '^ *public' src/main/java/org/apache/hadoop/hbase/HConstants.java | grep -v final`"; do echo "${line}" | grep -o -e " [A-Z_][A-Z_]* "; done
> {code}
> These mutable versions have been in many releases. We correctly don't assign to them in our codebase, but there's no way to know if anyone does downstream.
> HConstants is IA.Public and IS.Stable, but I'm fairly certain this behavior was unintentional and there isn't a non-broken use for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)