You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/10/01 16:04:30 UTC
Review Request: SQOOP-613: Add support for integer type to metadata model
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7371/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Pretty straightforward implementation of new metadata data type.
This addresses bug SQOOP-613.
https://issues.apache.org/jira/browse/SQOOP-613
Diffs
-----
client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java af3ff8a
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 6b7332a
common/src/main/java/org/apache/sqoop/model/MInputType.java 7acdbca
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java PRE-CREATION
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 657eab2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java c44270e
Diff: https://reviews.apache.org/r/7371/diff/
Testing
-------
No new unit tests introduced, just "by hand" testing at the moment.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-613: Add support for integer type to metadata model
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7371/#review12152
-----------------------------------------------------------
Ship it!
Ship It!
- Bilung Lee
On Oct. 1, 2012, 2:04 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7371/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2012, 2:04 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Pretty straightforward implementation of new metadata data type.
>
>
> This addresses bug SQOOP-613.
> https://issues.apache.org/jira/browse/SQOOP-613
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java af3ff8a
> common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 6b7332a
> common/src/main/java/org/apache/sqoop/model/MInputType.java 7acdbca
> common/src/main/java/org/apache/sqoop/model/MIntegerInput.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 657eab2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java c44270e
>
> Diff: https://reviews.apache.org/r/7371/diff/
>
>
> Testing
> -------
>
> No new unit tests introduced, just "by hand" testing at the moment.
>
>
> Thanks,
>
> Jarek Cecho
>
>