[GitHub] [beam] lukecwik commented on a diff in pull request #17243: [BEAM-13015] Disable retries for fnapi grpc channels which otherwise defaults on.

[GitBox <gi...@apache.org>]

lukecwik commented on code in PR #17243:
URL: https://github.com/apache/beam/pull/17243#discussion_r842155089


##########
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/channel/ManagedChannelFactory.java:
##########
@@ -89,6 +89,10 @@ public ManagedChannel forDescriptor(ApiServiceDescriptor apiServiceDescriptor) {
             // Set the message size to max value here. The actual size is governed by the
             // buffer size in the layers above.
             .maxInboundMessageSize(Integer.MAX_VALUE)
+            // Disable automatic retries as it introduces complexity and we send long-lived 
+            // rpcs which will exceed the per-rpc retry request buffer and not be retried 
+            // anyway. See https://github.com/grpc/proposal/blob/master/A6-client-retries.md#when-retries-are-valid

Review Comment:
   ```suggestion
               // anyway. See
               // https://github.com/grpc/proposal/blob/master/A6-client-retries.md#when-retries-are-valid
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org