You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/02/02 15:21:30 UTC
[GitHub] [arrow] wgtmac opened a new pull request, #34006: GH-34003: [C++] AddWithOverflow and friends should be [[nodiscard]]
wgtmac opened a new pull request, #34006:
URL: https://github.com/apache/arrow/pull/34006
### Rationale for this change
Enforce checking return values of the arithmetic operations in case of overflow.
### What changes are included in this PR?
Add `[[nodiscard]]` attribute to those functions.
### Are these changes tested?
Make sure all tests pass.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #34006: GH-34003: [C++] AddWithOverflow and friends should be [[nodiscard]]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #34006:
URL: https://github.com/apache/arrow/pull/34006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34006: GH-34003: [C++] AddWithOverflow and friends should be [[nodiscard]]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34006:
URL: https://github.com/apache/arrow/pull/34006#issuecomment-1413916271
* Closes: #34003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34006: GH-34003: [C++] AddWithOverflow and friends should be [[nodiscard]]
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34006:
URL: https://github.com/apache/arrow/pull/34006#issuecomment-1414477808
Benchmark runs are scheduled for baseline = fd2c80fb22d26d78b574b8f397979137b9c615b6 and contender = 5b705a4311fa1acfe961e6641a970de47e8c5c2b. 5b705a4311fa1acfe961e6641a970de47e8c5c2b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b4ca7250e7a64ce5b4d132a52a4bdebe...24da8f0a2b784064a85472e9ce9aef47/)
[Failed :arrow_down:0.43% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bfa9fe0433f54a4a8e67cbd29348035b...5cf82ee04b114fa98ab2aa21b7d2a30c/)
[Finished :arrow_down:5.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1adf31978295407faab403138f171dd3...54466430d0234e8a89d8b54443133775/)
[Finished :arrow_down:0.38% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f34e8120f89e42cd9dc2fb3e1a0b7b7f...a81e7d9255aa4a03a2621bb282d11ebe/)
Buildkite builds:
[Finished] [`5b705a43` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2311)
[Finished] [`5b705a43` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2337)
[Finished] [`5b705a43` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2308)
[Finished] [`5b705a43` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2329)
[Finished] [`fd2c80fb` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2310)
[Failed] [`fd2c80fb` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2336)
[Finished] [`fd2c80fb` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2307)
[Finished] [`fd2c80fb` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2328)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34006: GH-34003: [C++] AddWithOverflow and friends should be [[nodiscard]]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34006:
URL: https://github.com/apache/arrow/pull/34006#issuecomment-1413916337
:warning: GitHub issue #34003 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34006: GH-34003: [C++] AddWithOverflow and friends should be [[nodiscard]]
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34006:
URL: https://github.com/apache/arrow/pull/34006#issuecomment-1414478047
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1adf31978295407faab403138f171dd3...54466430d0234e8a89d8b54443133775/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org