You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Roshni Basu (JIRA)" <ji...@apache.org> on 2009/07/16 12:20:59 UTC
[jira] Created: (TILES-441) ignore="true" is not working for
importAttribute tag
ignore="true" is not working for importAttribute tag
----------------------------------------------------
Key: TILES-441
URL: https://issues.apache.org/struts/browse/TILES-441
Project: Tiles
Issue Type: Bug
Components: tiles-jsp (jsp support)
Affects Versions: 2.1.3
Reporter: Roshni Basu
In tiles:importAttribute, ignore="true" is not working.
In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
if (attributeValue == null) {
throw new TilesJspException(
"Error importing attributes. " + "Attribute '"
+ name + "' has a null value ");
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-441:
-----------------------------------
Applied patch by Roshni Basu. Thanks Roshni!
Added some more checks.
This issue is fixed for 2.1.x branch, but it should be fixed for 2.2.0 in a totally different way.
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-441:
-----------------------------------
Assignee: Antonio Petrelli
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli closed TILES-441.
----------------------------------
Resolution: Fixed
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli reopened TILES-441:
------------------------------------
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Roshni Basu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roshni Basu updated TILES-441:
------------------------------
Attachment: ImportAttributeTag_patch.java
Patch attached
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46489#action_46489 ]
Antonio Petrelli commented on TILES-441:
----------------------------------------
This bug is not present in 2.2.0. The template class, ImportAttributeTemplate, has already the check of the "ignore" flag.
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-441:
-----------------------------------
Fix Version/s: 2.1.4
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support), tiles-template
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Fix For: 2.1.4
>
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli closed TILES-441.
----------------------------------
Resolution: Fixed
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TILES-441) ignore="true" is not
working for importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46489#action_46489 ]
Antonio Petrelli edited comment on TILES-441 at 7/16/09 4:12 AM:
-----------------------------------------------------------------
This bug is not present in the trunk (the future 2.2.0 version). The template class, ImportAttributeTemplate, has already the check of the "ignore" flag.
was (Author: brenmcguire):
This bug is not present in 2.2.0. The template class, ImportAttributeTemplate, has already the check of the "ignore" flag.
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-441:
-----------------------------------
Fix Version/s: 2.2.0
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support), tiles-template
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Fix For: 2.1.4, 2.2.0
>
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-441:
-----------------------------------
Added fix to trunk, by modifying ImportAttributeModel in tiles-template module.
Added new testcases.
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-441:
-----------------------------------
I was wrong, even 2.2.0 is affected by the bug!
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-441) ignore="true" is not working for
importAttribute tag
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-441:
-----------------------------------
Component/s: tiles-template
> ignore="true" is not working for importAttribute tag
> ----------------------------------------------------
>
> Key: TILES-441
> URL: https://issues.apache.org/struts/browse/TILES-441
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support), tiles-template
> Affects Versions: 2.1.3
> Reporter: Roshni Basu
> Assignee: Antonio Petrelli
> Attachments: ImportAttributeTag_patch.java
>
>
> In tiles:importAttribute, ignore="true" is not working.
> In ImportAttributeTag.java, with the following check it is necessary to check whether value of "ignore" is false.
> if (attributeValue == null) {
> throw new TilesJspException(
> "Error importing attributes. " + "Attribute '"
> + name + "' has a null value ");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.