You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/08 00:23:20 UTC
[jira] [Commented] (CB-11970) Support CocoaPod pod specification
other than version
[ https://issues.apache.org/jira/browse/CB-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556730#comment-15556730 ]
ASF GitHub Bot commented on CB-11970:
-------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/267
CB-11970 - Support CocoaPod pod specification other than version
### Platforms affected
iOS
### What does this PR do?
Add support for CocoaPod specs that are not just versions, but other specifications.
i.e.
```
<framework src="MyPod" type="podspec" spec=":configurations => ['Debug', 'Beta']" />
<framework src="MyVersionedPod" type="podspec" spec="1.2" />
```
### What testing has been done on this change?
npm run unit-tests
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-11970
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
----
commit a24a69d725cbc468feafd0d0a29b643541e320fd
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-10-08T00:19:16Z
CB-11970 - Support CocoaPod pod specification other than version
----
> Support CocoaPod pod specification other than version
> -----------------------------------------------------
>
> Key: CB-11970
> URL: https://issues.apache.org/jira/browse/CB-11970
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
>
> https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L149
> Podfile spec:
> https://guides.cocoapods.org/syntax/podfile.html#pod
> If the spec begins with a colon ":", don't quote it when writing to the Podfile.
> Make sure this function works as well, after: https://github.com/apache/cordova-ios/blob/636113f047ee2c7dae742dff2beafae2121ceb62/bin/templates/scripts/cordova/lib/Podfile.js#L61
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org