[impala] 01/03: IMPALA-10379: Add missing HiveLexer classes to shared-deps

[ta...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 701714b10a77aee62cf2ad3e25db9e2dfd418780
Author: Tamas Mate <tm...@cloudera.com>
AuthorDate: Mon Feb 1 10:41:40 2021 +0100

    IMPALA-10379: Add missing HiveLexer classes to shared-deps
    
    HIVE-19064 introduced additional lexer classes that are required during
    runtime. This commit adds the missing HiveLexer lexer classes to the
    shared-deps. Without these classes queries such as 'select 1 as "``"'
    would fail with 'NoClassDefFoundError'.
    
    Testing:
     - added a misc.test to verify that the classes are available and that
    IMPALA-9641 is fixed by HIVE-19064
    
    Change-Id: I6e3a00335983f26498c1130ab9f109f6e67256f5
    Reviewed-on: http://gerrit.cloudera.org:8080/17019
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 java/shaded-deps/hive-exec/pom.xml                              | 3 +++
 testdata/workloads/functional-query/queries/QueryTest/misc.test | 9 +++++++++
 2 files changed, 12 insertions(+)

diff --git a/java/shaded-deps/hive-exec/pom.xml b/java/shaded-deps/hive-exec/pom.xml
index 6c6d070..639abc6 100644
--- a/java/shaded-deps/hive-exec/pom.xml
+++ b/java/shaded-deps/hive-exec/pom.xml
@@ -97,6 +97,9 @@ the same dependencies
                 <include>org/apache/hadoop/hive/ql/exec/FunctionUtils*</include>
                 <include>org/apache/hadoop/hive/ql/parse/GenericHiveLexer*</include>
                 <include>org/apache/hadoop/hive/ql/parse/HiveLexer*</include>
+                <include>org/apache/hadoop/hive/ql/parse/ANTLRNoCaseStringStream*</include>
+                <include>org/apache/hadoop/hive/ql/parse/ParseError*</include>
+                <include>org/apache/hadoop/hive/ql/parse/Quotation*</include>
                 <include>org/apache/hadoop/hive/ql/udf/**/*</include>
                 <!-- Many of the UDFs are annotated with their vectorized counter-parts.
                  Including them makes sure that we don't break -->
diff --git a/testdata/workloads/functional-query/queries/QueryTest/misc.test b/testdata/workloads/functional-query/queries/QueryTest/misc.test
index 903101c..2f48788 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/misc.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/misc.test
@@ -109,6 +109,15 @@ SELECT "quote \"", 'quote \''
 string, string
 ====
 ---- QUERY
+# IMPALA-9641: Empty double quotation should not cause infinite loop in the
+# ImpalaD Frontend
+SELECT 1 as "``"
+---- RESULTS
+1
+---- TYPES
+int
+====
+---- QUERY
 #  Select from table that contains unsupported primitive types
 SELECT int_col, str_col, bigint_col from functional.unsupported_types
 ---- RESULTS