[jira] [Work logged] (BEAM-4727) Reduce metrics overhead

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-4727?focusedWorklogId=130580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-130580 ]

ASF GitHub Bot logged work on BEAM-4727:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/18 18:46
            Start Date: 02/Aug/18 18:46
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on issue #5884: [BEAM-4727] Re-use metric context throughout bundle
URL: https://github.com/apache/beam/pull/5884#issuecomment-410029391
 
 
   Ping @herohde; I think I've covered all your comments in this iteration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 130580)
    Time Spent: 3h 40m  (was: 3.5h)

> Reduce metrics overhead
> -----------------------
>
>                 Key: BEAM-4727
>                 URL: https://issues.apache.org/jira/browse/BEAM-4727
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Robert Burke
>            Priority: Major
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> There are a few opportunities to avoid metrics overhead.
> First when setting state in the context, we allocate a new one for the stored value, per element. This generates a fair amount of objects for the garbage collector too. If we retain and re-use contexts within a bundle, we would have the opportunity to save on these costs.
> Also, it's possible that we have overhead on the metric updating paths. We can possibly do better than the general sync.Map, and avoid the type assertion cost for extracting values of known types from the maps.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)