You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/22 03:39:34 UTC
[GitHub] [airflow] jhtimmins opened a new issue #11073: Test that the xcom API endpoint handles joins properly
jhtimmins opened a new issue #11073:
URL: https://github.com/apache/airflow/issues/11073
The XCom endpoint joins the XCom and DagRun tables. Currently, the output of the join isn't getting stored as a new `query` variable, as seen in the link to the following PR. We should add a new test to check that these tables are getting joined correctly.
https://github.com/apache/airflow/pull/10594/files/1fe1da978763c9919cee0d2c7eccd96438631993#diff-aa0c2f68c6177fb1587a6de6b5cfb28cR59
I will make these changes after #10594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11073: Test that the xcom API endpoint handles joins properly
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11073:
URL: https://github.com/apache/airflow/issues/11073#issuecomment-708626691
@OmairK Thank you for wanting to maintain this code still. I really appreciate it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OmairK commented on issue #11073: Test that the xcom API endpoint handles joins properly
Posted by GitBox <gi...@apache.org>.
OmairK commented on issue #11073:
URL: https://github.com/apache/airflow/issues/11073#issuecomment-708625571
@mik-laj Can you assign me this ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #11073: Test that the xcom API endpoint handles joins properly
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #11073:
URL: https://github.com/apache/airflow/issues/11073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OmairK commented on issue #11073: Test that the xcom API endpoint handles joins properly
Posted by GitBox <gi...@apache.org>.
OmairK commented on issue #11073:
URL: https://github.com/apache/airflow/issues/11073#issuecomment-713872651
@jhtimmins is this issue still relevant after this [change](https://github.com/apache/airflow/pull/10594/commits/bbd08a3c529f7af40842b80c42793b775071743e)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11073: Test that the xcom API endpoint handles joins properly
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11073:
URL: https://github.com/apache/airflow/issues/11073#issuecomment-708623649
@ephraimbuddy @OmairK Can you look at it also?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11073: Test that the xcom API endpoint handles joins properly
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11073:
URL: https://github.com/apache/airflow/issues/11073#issuecomment-701325378
CC: @randr97 @ephraimbuddy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11073: Test that the xcom API endpoint handles joins properly
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11073:
URL: https://github.com/apache/airflow/issues/11073#issuecomment-713883150
I think we need to add unit tests to prevent regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org