You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/21 20:36:29 UTC
[GitHub] [accumulo] ctubbsii opened a new issue #2027: Create a QA check for GitHub Actions that checks for breaking API changes
ctubbsii opened a new issue #2027:
URL: https://github.com/apache/accumulo/issues/2027
**Is your feature request related to a problem? Please describe.**
Sometimes, we unintentionally break API. It would be nice if we could detect this in a PR.
**Describe the solution you'd like**
A new matrix line in our QA / CI checks in GitHub Actions could be added to check our public API classes to see if they have had a breaking change (change of method signature or removal of method). We could also detect API additions. It would be okay for this check to fail, if the change is actually intended. But, having this check fail when such changes do occur in a PR will bring our attention to changes we might not have intended to make.
**Describe alternatives you've considered**
Catch it in code review manually (what we do now) or check periodically (what we tend to do at release time).
**Additional context**
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #2027: Create a QA check for GitHub Actions that checks for breaking API changes
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #2027:
URL: https://github.com/apache/accumulo/issues/2027#issuecomment-900675683
This task is basically to highlight whenever we change the API in a potentially breaking way. It's not necessarily intended to restrict the imports or to analyze the API classes, but just to highlight that the API changed in some way. I hadn't put a lot of thought into how this would work, but it could theoretically work by analyzing the diff against the base branch to see whether any public API methods have been added, deleted, or modified in public API classes. The intent wasn't to identify a PR that should not be merged, but just to fail the task to highlight that we should look more closely at the API implications. The task could be called "No API changes" or similar, so that a failure would simply imply that there were API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on issue #2027: Create a QA check for GitHub Actions that checks for breaking API changes
Posted by GitBox <gi...@apache.org>.
milleruntime commented on issue #2027:
URL: https://github.com/apache/accumulo/issues/2027#issuecomment-898605395
We use the apilyzer-maven-plugin. Check out https://accumulo.apache.org/blog/2019/11/04/checkstyle-import-control.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #2027: Create a QA check for GitHub Actions that checks for breaking API changes
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #2027:
URL: https://github.com/apache/accumulo/issues/2027#issuecomment-900675683
This task is basically to highlight whenever we change the API in a potentially breaking way. It's not necessarily intended to restrict the imports or to analyze the API classes, but just to highlight that the API changed in some way. I hadn't put a lot of thought into how this would work, but it could theoretically work by analyzing the diff against the base branch to see whether any public API methods have been added, deleted, or modified in public API classes. The intent wasn't to identify a PR that should not be merged, but just to fail the task to highlight that we should look more closely at the API implications. The task could be called "No API changes" or similar, so that a failure would simply imply that there were API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on issue #2027: Create a QA check for GitHub Actions that checks for breaking API changes
Posted by GitBox <gi...@apache.org>.
Manno15 commented on issue #2027:
URL: https://github.com/apache/accumulo/issues/2027#issuecomment-898589278
What command do we run at release time to check for API breakage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 edited a comment on issue #2027: Create a QA check for GitHub Actions that checks for breaking API changes
Posted by GitBox <gi...@apache.org>.
Manno15 edited a comment on issue #2027:
URL: https://github.com/apache/accumulo/issues/2027#issuecomment-898589278
What command do we run at release time to check for API breakage? Just maven's apilyzer plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org