You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "MonkeyDLufy (via GitHub)" <gi...@apache.org> on 2024/01/16 02:58:27 UTC
[I] feat: As a user, I want to ..., so that ... [apisix]
MonkeyDLufy opened a new issue, #10826:
URL: https://github.com/apache/apisix/issues/10826
### Description
As a tcp server user, I want to use apisix for proxy tcp servers. So I need the stream upstream can support active health check. But I try and found that, the active health check seem only support for http, it can't work on tcp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "fatihusta (via GitHub)" <gi...@apache.org>.
fatihusta commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-2206250347
> @fatihusta it would be much better if you write your proposal first.
I re-imlemented this [PR](https://github.com/apache/apisix/pull/2546). Also I added new control API functions.
Control API is in http context. upstream-healthcheck-stream shared-dict is in stream context. There is no access between http and stream context for shared-dicts. So I added unix domain socket in stream context. After that I access the unix socket from control API. Is this right way to do this or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #10826: feat: support health check for TCP upstreams
URL: https://github.com/apache/apisix/issues/10826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "MonkeyDLufy (via GitHub)" <gi...@apache.org>.
MonkeyDLufy commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-1893173011
curl http://127.0.0.1:9180/apisix/admin/stream_routes/1 -X PUT -d '
{
"server_port": 9100,
"upstream": {
"nodes": {
"10.178.178.178:80": 1,
"10.187.187.187:80": 1
},
"type": "roundrobin",
"scheme": "tcp",
"checks": {
"active": {
"type": "tcp",
"unhealthy": {
"interval": 1,
"tcp_failures": 3
},
"healthy": {
"interval": 2,
"successes": 1
}
}
}
}
}'
This is my config. I used tcpdump to capture packets and observed that the probe packets for active health checks were not sent. Among the two IP addresses in the example, one of them is not reachable. I expected it to be circuit broken and not receive any traffic, but apisix still sent traffic to it until the connection timed out and then retried with another available node.
> Hi @MonkeyDLufy please check the docs here if this is what you are looking for https://apisix.apache.org/docs/apisix/next/tutorials/health-check/#active-check
>
> Are you having any specific problems in configuring it?
curl http://127.0.0.1:9180/apisix/admin/stream_routes/1 -X PUT -d '
{
"server_port": 9100,
"upstream": {
"nodes": {
"10.178.178.178:80": 1,
"10.187.187.187:80": 1
},
"type": "roundrobin",
"scheme": "tcp",
"checks": {
"active": {
"type": "tcp",
"unhealthy": {
"interval": 1,
"tcp_failures": 3
},
"healthy": {
"interval": 2,
"successes": 1
}
}
}
}
}'
This is my config. I used tcpdump to capture packets and observed that the probe packets for active health checks were not sent. Among the two IP addresses in the example, one of them is not reachable. I expected it to be circuit broken and not receive any traffic, but apisix still sent traffic to it until the connection timed out and then retried with another available node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "MonkeyDLufy (via GitHub)" <gi...@apache.org>.
MonkeyDLufy commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-1894824689
Thank you for helping me confirm this information. I hope that Apisix can provide support for this feature in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "fatihusta (via GitHub)" <gi...@apache.org>.
fatihusta commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-2206229037
I re-implemented this [PR](https://github.com/apache/apisix/pull/2546). Also I added control api functions.
Control api is in http context. upstream-healthcheck-stream is in stream context. There is no access between http and stream context shared dicts. So I added unix socket in stream context. After that I access the unix socket from control api. Is this right way to do this or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "theweakgod (via GitHub)" <gi...@apache.org>.
theweakgod commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-1899983647
@shreemaan-abhishek I can handle this issue, can you assign this to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-2987511561
This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-2206042375
@fatihusta it would be much better if you write your proposal here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-1894152382
AFAIK, healthchek for TCP upstreams isn't supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-3031679422
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: As a user, I want to ..., so that ... [apisix]
Posted by "lakshya8066 (via GitHub)" <gi...@apache.org>.
lakshya8066 commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-1893007939
Hi @MonkeyDLufy please check the docs here if this is what you are looking for
https://apisix.apache.org/docs/apisix/next/tutorials/health-check/#active-check
Are you having any specific problems in configuring it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: support health check for TCP upstreams [apisix]
Posted by "MonkeyDLufy (via GitHub)" <gi...@apache.org>.
MonkeyDLufy commented on issue #10826:
URL: https://github.com/apache/apisix/issues/10826#issuecomment-1906076508
I think health check for UDP upstreams is also necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org