You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/02/11 22:59:30 UTC
[GitHub] [trafficserver] a-canary opened a new pull request #7520: Parent autest
a-canary opened a new pull request #7520:
URL: https://github.com/apache/trafficserver/pull/7520
WIP
This is an attempt for autests to run a complete CDN, and evaluate via headers for correct routing and caching behavior for parent selection or other upstream routing plugins.
TODO:
+ move pop.py and util.py into autest extensions?
+ use namespace to create 8+ virtual IPs
+ use the virtual IPs for each process. [DNS, uServer, ATS]
+ convert carp's cacheControl autests for parent selection.
+ replicate tests for Nexthop
+ replicate tests for Rob's Router Plugin
+ write test for CARP style architecture (single pop, self hashing)
Notes:
ParentSelection's self detection may/will cause issues. I'm hoping the VIP will work for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7520: Parent autest
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7520:
URL: https://github.com/apache/trafficserver/pull/7520#issuecomment-823551004
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7520: Parent autest
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7520:
URL: https://github.com/apache/trafficserver/pull/7520#issuecomment-781672319
@jrushford is going to take this PR over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7520: Parent autest
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7520:
URL: https://github.com/apache/trafficserver/pull/7520#issuecomment-779964288
[approve ci autest]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras closed pull request #7520: Parent autest
Posted by GitBox <gi...@apache.org>.
ywkaras closed pull request #7520:
URL: https://github.com/apache/trafficserver/pull/7520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7520: Parent autest
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7520:
URL: https://github.com/apache/trafficserver/pull/7520#issuecomment-823551004
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #7520: Parent autest
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #7520:
URL: https://github.com/apache/trafficserver/pull/7520#discussion_r578731460
##########
File path: tests/gold_tests/custom_routing/parent_basic.test.py
##########
@@ -0,0 +1,101 @@
+'''
+'''
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import pop
Review comment:
I can install pop on the CI machines to solve that issue easily enough. I'm concerned that the test/Pipfile isn't updated with this new Python package requirement. That is, I can fix things for CI by installing pop on the CI machines that run autest, but for our local autest runs pop will need to be installed which will require the Pipfile update.
I'll hold off on udpating the CI machines until the Pipfile in the PR is updated with this and any other requirements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7520: Parent autest
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7520:
URL: https://github.com/apache/trafficserver/pull/7520#issuecomment-823674068
Replaced by https://github.com/apache/trafficserver/pull/7728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on a change in pull request #7520: Parent autest
Posted by GitBox <gi...@apache.org>.
shinrich commented on a change in pull request #7520:
URL: https://github.com/apache/trafficserver/pull/7520#discussion_r578697896
##########
File path: tests/gold_tests/custom_routing/parent_basic.test.py
##########
@@ -0,0 +1,101 @@
+'''
+'''
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import pop
Review comment:
This import is failing on the CI machine. Causes an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org