You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "f-ambroz (via GitHub)" <gi...@apache.org> on 2023/07/26 05:59:44 UTC
[GitHub] [camel-karavan] f-ambroz opened a new pull request, #830: Refactoring of Karavan Core
f-ambroz opened a new pull request, #830:
URL: https://github.com/apache/camel-karavan/pull/830
- Bumped up the version of typescript to ES2022
- Added prettier to the project
- Refactored iterating so it uses classic _**for**_ loops for better performance
- Added private constructors to static classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on pull request #830: Refactoring of Karavan Core
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on PR #830:
URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1651917762
@f-ambroz thanks!
Could you please fix tests in karavan-core (just simple sort yaml results) and vscode build ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] f-ambroz commented on pull request #830: Refactoring of Karavan Core
Posted by "f-ambroz (via GitHub)" <gi...@apache.org>.
f-ambroz commented on PR #830:
URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1659660944
> @f-ambroz is it OK that karavan-app is still `"target": "es5"` while core, designer are `"target": "es2022"` ?
That is a good question that I do not have the answer for. 😄
Theoretically, it should be OK, but this is javascript we are talking about, so I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] f-ambroz commented on pull request #830: Refactoring of Karavan Core
Posted by "f-ambroz (via GitHub)" <gi...@apache.org>.
f-ambroz commented on PR #830:
URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1655337710
@mgubaidullin Tests are fixed. So the build should work now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] f-ambroz commented on pull request #830: Refactoring of Karavan Core
Posted by "f-ambroz (via GitHub)" <gi...@apache.org>.
f-ambroz commented on PR #830:
URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1652956645
> @f-ambroz thanks! Could you please fix tests in karavan-core (just simple sort yaml results) and vscode build ?
Will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on pull request #830: Refactoring of Karavan Core
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on PR #830:
URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1658604952
@f-ambroz is it OK that karavan-app is still `"target": "es5"` while core, designer are `"target": "es2022"` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin merged pull request #830: Refactoring of Karavan Core
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin merged PR #830:
URL: https://github.com/apache/camel-karavan/pull/830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] f-ambroz commented on pull request #830: Refactoring of Karavan Core
Posted by "f-ambroz (via GitHub)" <gi...@apache.org>.
f-ambroz commented on PR #830:
URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1657818023
@mgubaidullin everything seems to be fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org