You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/05/01 20:51:40 UTC

[GitHub] storm pull request #2644: STORM-3041 improve worker-launcher messages

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2644#discussion_r185330090
  
    --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
    @@ -309,7 +309,7 @@ int set_user(const char *user) {
     }
     
     /**
    - * Open a file as the node manager and return a file descriptor for it.
    + * Open a file as the worker-launcher user and return a file descriptor for it.
    --- End diff --
    
    Is this referring to "node manager" because it was copy pasted, or what is node manager referring to?
    
    Maybe we should rename the functions that refer to "nm" as well?


---