[GitHub] [pulsar] candlerb edited a comment on issue #5365: python API missing `is_read_compacted` in create_reader()

[GitBox <gi...@apache.org>]

candlerb edited a comment on issue #5365: python API missing `is_read_compacted` in create_reader()
URL: https://github.com/apache/pulsar/issues/5365#issuecomment-546940621
 
 
   I notice in `pulsar-client-cpp/python/pulsar/__init__.py` that `subscribe` has this option:
   
   ```
       def subscribe(self, topic, subscription_name,
                     consumer_type=ConsumerType.Exclusive,
                     schema=schema.BytesSchema(),
                     message_listener=None,
                     receiver_queue_size=1000,
                     max_total_receiver_queue_size_across_partitions=50000,
                     consumer_name=None,
                     unacked_messages_timeout_ms=None,
                     broker_consumer_stats_cache_time_ms=30000,
                     negative_ack_redelivery_delay_ms=60000,
                     is_read_compacted=False,   <<<<<
                     properties=None,
                     pattern_auto_discovery_period=60,
                     initial_position=InitialPosition.Latest
                     ):
   ...
           conf = _pulsar.ConsumerConfiguration()
           conf.consumer_type(consumer_type)
           conf.read_compacted(is_read_compacted)
   ```
   
   but `create_reader` does not:
   
   ```
       def create_reader(self, topic, start_message_id,
                         schema=schema.BytesSchema(),
                         reader_listener=None,
                         receiver_queue_size=1000,
                         reader_name=None,
                         subscription_role_prefix=None
                         ):
   ...
           conf = _pulsar.ReaderConfiguration()
   ```
   
   I think it's just omitting to pass this on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services