You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "tqchen (via GitHub)" <gi...@apache.org> on 2023/06/27 22:27:36 UTC
[GitHub] [tvm] tqchen commented on a diff in pull request #15140: [Unity][IR][UX] Privacy annotation in Relax
tqchen commented on code in PR #15140:
URL: https://github.com/apache/tvm/pull/15140#discussion_r1244434012
##########
tests/python/relax/test_transform_merge_composite_functions.py:
##########
@@ -41,7 +41,7 @@ def main(
R.output(gv)
return gv
- @R.function
+ @R.function(private=True)
Review Comment:
I think by default fusion pass should not produce functions with global symbol. Ideally we should prevent fusing functions that with global symbol --- because user expects to access the original function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org