[GitHub] [airflow] RosterIn edited a comment on issue #5430: [AIRFLOW-4810] Bump supported mysqlclient to <1.5

[GitBox <gi...@apache.org>]

RosterIn edited a comment on issue #5430: [AIRFLOW-4810] Bump supported mysqlclient to <1.5
URL: https://github.com/apache/airflow/pull/5430#issuecomment-503640116
 
 
   @ashb It doesn't make sense to me.
   There is nothing relevant in the change log of PyMySQL https://github.com/PyMySQL/mysqlclient-python/blob/master/HISTORY.rst
   in fact the only reason they bumped version is because they dropped support for Python 3.4 
   
   Moreover, the issue with `test_database_schema_and_sqlalchemy_model_are_in_sync`  is a compare issue.
   Note that the other tests regarding `CREATE TABLE`, `DROP TABLE` of MySQL passed successfully. 
   So, if there is a problem with the compare and the DB has more/less tables than the model I would expect that `test_mysql_to_mysql `: https://github.com/apache/airflow/blob/577f8936727454eb4ff54588cd525c5244ef6d52/tests/operators/test_operators.py#L145 or the `teardown `https://github.com/apache/airflow/blob/577f8936727454eb4ff54588cd525c5244ef6d52/tests/operators/test_operators.py#L47
    would fail to.
   
   I would love to fix whatever needed but I don't have a clue about what is the problem.  Maybe you can give me a better indication or try to rerun the test to see if it was flaky?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services