You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nathanejohnson <gi...@git.apache.org> on 2016/08/09 19:18:51 UTC
[GitHub] cloudstack pull request #1632: Honor the forced parameter for stopVirtualMac...
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1632
Honor the forced parameter for stopVirtualMachine api call
CLOUDSTACK-9451
https://issues.apache.org/jira/browse/CLOUDSTACK-9451
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/myENA/cloudstack feature/honor_force_stop_vm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1632
----
commit 8e8b511388df62eef9a5488677a57417c32d67db
Author: Nathan Johnson <nj...@ena.com>
Date: 2016-08-09T19:16:00Z
Honor the forced parameter for stopVirtualMachine api call
CLOUDSTACK-9451
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1632: Honor the forced parameter for stopVirtualMac...
Posted by nathanejohnson <gi...@git.apache.org>.
Github user nathanejohnson closed the pull request at:
https://github.com/apache/cloudstack/pull/1632
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by ProjectMoon <gi...@git.apache.org>.
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1632
It goes all the way back to 4.7. Isn't the oldest supported release currently 4.8 at the moment? If so, it should be opened against 4.8, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1632
@ProjectMoon Thats correct. bugfixes should go to 4.8, the oldest supported branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1632
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1632
@nathanejohnson LGTM, but this bug affects 4.9 as well; please close this PR and reopen against 4.9. Your PR when accepted will be merged on 4.9 and fwd-merged on master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by ProjectMoon <gi...@git.apache.org>.
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1632
I thought it was: new features -> master, bug fixes -> oldest supported release branch? 4.7 is no longer supported but as far as I know 4.8 is still supported (I could be wrong on this).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1632
Packaging result: \u2714centos6 \u2714centos7 \u2714debian repo: http://packages.shapeblue.com/cloudstack/pr/1632
Job ID-80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1632
@karuturi @jburwell test keyword has been disabled due to infrastructural issues, I'll try to get this fixed today. Also, we need to run package first, to evaluate build/test/package checks before running Trillian test as each Trillian test is relatively more expensive.
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1632
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by nathanejohnson <gi...@git.apache.org>.
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1632
@karaturi @ProjectMoon @rthyd I will close and reopen against 4.8, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1632
@ProjectMoon With our current branch support policy, we should merge bugfixes/changes on master and the last release branch (i.e. 4.9 and also since 4.9 is current/to-be lts branch). I'm fine with sending the PR for 4.7/4.8 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---