You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/07/12 14:49:26 UTC
[14/28] hbase-site git commit: Published site at
3fc23fe930aa93e8755cf2bd478bd9907f719fd2.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/c7c8351c/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.html
index d3c469e..3e9e637 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.html
@@ -50,353 +50,364 @@
<span class="sourceLineNo">042</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.42"></a>
<span class="sourceLineNo">043</span>import org.slf4j.Logger;<a name="line.43"></a>
<span class="sourceLineNo">044</span>import org.slf4j.LoggerFactory;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.apache.hbase.thirdparty.com.google.common.collect.Lists;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.CreateTableState;<a name="line.49"></a>
-<span class="sourceLineNo">050</span><a name="line.50"></a>
-<span class="sourceLineNo">051</span>@InterfaceAudience.Private<a name="line.51"></a>
-<span class="sourceLineNo">052</span>public class CreateTableProcedure<a name="line.52"></a>
-<span class="sourceLineNo">053</span> extends AbstractStateMachineTableProcedure<CreateTableState> {<a name="line.53"></a>
-<span class="sourceLineNo">054</span> private static final Logger LOG = LoggerFactory.getLogger(CreateTableProcedure.class);<a name="line.54"></a>
-<span class="sourceLineNo">055</span><a name="line.55"></a>
-<span class="sourceLineNo">056</span> private TableDescriptor tableDescriptor;<a name="line.56"></a>
-<span class="sourceLineNo">057</span> private List<RegionInfo> newRegions;<a name="line.57"></a>
-<span class="sourceLineNo">058</span><a name="line.58"></a>
-<span class="sourceLineNo">059</span> public CreateTableProcedure() {<a name="line.59"></a>
-<span class="sourceLineNo">060</span> // Required by the Procedure framework to create the procedure on replay<a name="line.60"></a>
-<span class="sourceLineNo">061</span> super();<a name="line.61"></a>
-<span class="sourceLineNo">062</span> }<a name="line.62"></a>
-<span class="sourceLineNo">063</span><a name="line.63"></a>
-<span class="sourceLineNo">064</span> public CreateTableProcedure(final MasterProcedureEnv env,<a name="line.64"></a>
-<span class="sourceLineNo">065</span> final TableDescriptor tableDescriptor, final RegionInfo[] newRegions) {<a name="line.65"></a>
-<span class="sourceLineNo">066</span> this(env, tableDescriptor, newRegions, null);<a name="line.66"></a>
-<span class="sourceLineNo">067</span> }<a name="line.67"></a>
-<span class="sourceLineNo">068</span><a name="line.68"></a>
-<span class="sourceLineNo">069</span> public CreateTableProcedure(final MasterProcedureEnv env,<a name="line.69"></a>
-<span class="sourceLineNo">070</span> final TableDescriptor tableDescriptor, final RegionInfo[] newRegions,<a name="line.70"></a>
-<span class="sourceLineNo">071</span> final ProcedurePrepareLatch syncLatch) {<a name="line.71"></a>
-<span class="sourceLineNo">072</span> super(env, syncLatch);<a name="line.72"></a>
-<span class="sourceLineNo">073</span> this.tableDescriptor = tableDescriptor;<a name="line.73"></a>
-<span class="sourceLineNo">074</span> this.newRegions = newRegions != null ? Lists.newArrayList(newRegions) : null;<a name="line.74"></a>
-<span class="sourceLineNo">075</span> }<a name="line.75"></a>
-<span class="sourceLineNo">076</span><a name="line.76"></a>
-<span class="sourceLineNo">077</span> @Override<a name="line.77"></a>
-<span class="sourceLineNo">078</span> protected Flow executeFromState(final MasterProcedureEnv env, final CreateTableState state)<a name="line.78"></a>
-<span class="sourceLineNo">079</span> throws InterruptedException {<a name="line.79"></a>
-<span class="sourceLineNo">080</span> if (LOG.isTraceEnabled()) {<a name="line.80"></a>
-<span class="sourceLineNo">081</span> LOG.trace(this + " execute state=" + state);<a name="line.81"></a>
-<span class="sourceLineNo">082</span> }<a name="line.82"></a>
-<span class="sourceLineNo">083</span> try {<a name="line.83"></a>
-<span class="sourceLineNo">084</span> switch (state) {<a name="line.84"></a>
-<span class="sourceLineNo">085</span> case CREATE_TABLE_PRE_OPERATION:<a name="line.85"></a>
-<span class="sourceLineNo">086</span> // Verify if we can create the table<a name="line.86"></a>
-<span class="sourceLineNo">087</span> boolean exists = !prepareCreate(env);<a name="line.87"></a>
-<span class="sourceLineNo">088</span> releaseSyncLatch();<a name="line.88"></a>
-<span class="sourceLineNo">089</span><a name="line.89"></a>
-<span class="sourceLineNo">090</span> if (exists) {<a name="line.90"></a>
-<span class="sourceLineNo">091</span> assert isFailed() : "the delete should have an exception here";<a name="line.91"></a>
-<span class="sourceLineNo">092</span> return Flow.NO_MORE_STATE;<a name="line.92"></a>
-<span class="sourceLineNo">093</span> }<a name="line.93"></a>
-<span class="sourceLineNo">094</span><a name="line.94"></a>
-<span class="sourceLineNo">095</span> preCreate(env);<a name="line.95"></a>
-<span class="sourceLineNo">096</span> setNextState(CreateTableState.CREATE_TABLE_WRITE_FS_LAYOUT);<a name="line.96"></a>
-<span class="sourceLineNo">097</span> break;<a name="line.97"></a>
-<span class="sourceLineNo">098</span> case CREATE_TABLE_WRITE_FS_LAYOUT:<a name="line.98"></a>
-<span class="sourceLineNo">099</span> newRegions = createFsLayout(env, tableDescriptor, newRegions);<a name="line.99"></a>
-<span class="sourceLineNo">100</span> setNextState(CreateTableState.CREATE_TABLE_ADD_TO_META);<a name="line.100"></a>
-<span class="sourceLineNo">101</span> break;<a name="line.101"></a>
-<span class="sourceLineNo">102</span> case CREATE_TABLE_ADD_TO_META:<a name="line.102"></a>
-<span class="sourceLineNo">103</span> newRegions = addTableToMeta(env, tableDescriptor, newRegions);<a name="line.103"></a>
-<span class="sourceLineNo">104</span> setNextState(CreateTableState.CREATE_TABLE_ASSIGN_REGIONS);<a name="line.104"></a>
-<span class="sourceLineNo">105</span> break;<a name="line.105"></a>
-<span class="sourceLineNo">106</span> case CREATE_TABLE_ASSIGN_REGIONS:<a name="line.106"></a>
-<span class="sourceLineNo">107</span> setEnablingState(env, getTableName());<a name="line.107"></a>
-<span class="sourceLineNo">108</span> addChildProcedure(env.getAssignmentManager().createRoundRobinAssignProcedures(newRegions));<a name="line.108"></a>
-<span class="sourceLineNo">109</span> setNextState(CreateTableState.CREATE_TABLE_UPDATE_DESC_CACHE);<a name="line.109"></a>
-<span class="sourceLineNo">110</span> break;<a name="line.110"></a>
-<span class="sourceLineNo">111</span> case CREATE_TABLE_UPDATE_DESC_CACHE:<a name="line.111"></a>
-<span class="sourceLineNo">112</span> setEnabledState(env, getTableName());<a name="line.112"></a>
-<span class="sourceLineNo">113</span> updateTableDescCache(env, getTableName());<a name="line.113"></a>
-<span class="sourceLineNo">114</span> setNextState(CreateTableState.CREATE_TABLE_POST_OPERATION);<a name="line.114"></a>
-<span class="sourceLineNo">115</span> break;<a name="line.115"></a>
-<span class="sourceLineNo">116</span> case CREATE_TABLE_POST_OPERATION:<a name="line.116"></a>
-<span class="sourceLineNo">117</span> postCreate(env);<a name="line.117"></a>
-<span class="sourceLineNo">118</span> return Flow.NO_MORE_STATE;<a name="line.118"></a>
-<span class="sourceLineNo">119</span> default:<a name="line.119"></a>
-<span class="sourceLineNo">120</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.120"></a>
-<span class="sourceLineNo">121</span> }<a name="line.121"></a>
-<span class="sourceLineNo">122</span> } catch (IOException e) {<a name="line.122"></a>
-<span class="sourceLineNo">123</span> if (isRollbackSupported(state)) {<a name="line.123"></a>
-<span class="sourceLineNo">124</span> setFailure("master-create-table", e);<a name="line.124"></a>
-<span class="sourceLineNo">125</span> } else {<a name="line.125"></a>
-<span class="sourceLineNo">126</span> LOG.warn("Retriable error trying to create table=" + getTableName() + " state=" + state, e);<a name="line.126"></a>
-<span class="sourceLineNo">127</span> }<a name="line.127"></a>
-<span class="sourceLineNo">128</span> }<a name="line.128"></a>
-<span class="sourceLineNo">129</span> return Flow.HAS_MORE_STATE;<a name="line.129"></a>
-<span class="sourceLineNo">130</span> }<a name="line.130"></a>
-<span class="sourceLineNo">131</span><a name="line.131"></a>
-<span class="sourceLineNo">132</span> @Override<a name="line.132"></a>
-<span class="sourceLineNo">133</span> protected void rollbackState(final MasterProcedureEnv env, final CreateTableState state)<a name="line.133"></a>
-<span class="sourceLineNo">134</span> throws IOException {<a name="line.134"></a>
-<span class="sourceLineNo">135</span> if (state == CreateTableState.CREATE_TABLE_PRE_OPERATION) {<a name="line.135"></a>
-<span class="sourceLineNo">136</span> // nothing to rollback, pre-create is just table-state checks.<a name="line.136"></a>
-<span class="sourceLineNo">137</span> // We can fail if the table does exist or the descriptor is malformed.<a name="line.137"></a>
-<span class="sourceLineNo">138</span> // TODO: coprocessor rollback semantic is still undefined.<a name="line.138"></a>
-<span class="sourceLineNo">139</span> DeleteTableProcedure.deleteTableStates(env, getTableName());<a name="line.139"></a>
-<span class="sourceLineNo">140</span> releaseSyncLatch();<a name="line.140"></a>
-<span class="sourceLineNo">141</span> return;<a name="line.141"></a>
-<span class="sourceLineNo">142</span> }<a name="line.142"></a>
-<span class="sourceLineNo">143</span><a name="line.143"></a>
-<span class="sourceLineNo">144</span> // The procedure doesn't have a rollback. The execution will succeed, at some point.<a name="line.144"></a>
-<span class="sourceLineNo">145</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.145"></a>
-<span class="sourceLineNo">146</span> }<a name="line.146"></a>
-<span class="sourceLineNo">147</span><a name="line.147"></a>
-<span class="sourceLineNo">148</span> @Override<a name="line.148"></a>
-<span class="sourceLineNo">149</span> protected boolean isRollbackSupported(final CreateTableState state) {<a name="line.149"></a>
-<span class="sourceLineNo">150</span> switch (state) {<a name="line.150"></a>
-<span class="sourceLineNo">151</span> case CREATE_TABLE_PRE_OPERATION:<a name="line.151"></a>
-<span class="sourceLineNo">152</span> return true;<a name="line.152"></a>
-<span class="sourceLineNo">153</span> default:<a name="line.153"></a>
-<span class="sourceLineNo">154</span> return false;<a name="line.154"></a>
-<span class="sourceLineNo">155</span> }<a name="line.155"></a>
-<span class="sourceLineNo">156</span> }<a name="line.156"></a>
-<span class="sourceLineNo">157</span><a name="line.157"></a>
-<span class="sourceLineNo">158</span> @Override<a name="line.158"></a>
-<span class="sourceLineNo">159</span> protected CreateTableState getState(final int stateId) {<a name="line.159"></a>
-<span class="sourceLineNo">160</span> return CreateTableState.valueOf(stateId);<a name="line.160"></a>
-<span class="sourceLineNo">161</span> }<a name="line.161"></a>
-<span class="sourceLineNo">162</span><a name="line.162"></a>
-<span class="sourceLineNo">163</span> @Override<a name="line.163"></a>
-<span class="sourceLineNo">164</span> protected int getStateId(final CreateTableState state) {<a name="line.164"></a>
-<span class="sourceLineNo">165</span> return state.getNumber();<a name="line.165"></a>
-<span class="sourceLineNo">166</span> }<a name="line.166"></a>
-<span class="sourceLineNo">167</span><a name="line.167"></a>
-<span class="sourceLineNo">168</span> @Override<a name="line.168"></a>
-<span class="sourceLineNo">169</span> protected CreateTableState getInitialState() {<a name="line.169"></a>
-<span class="sourceLineNo">170</span> return CreateTableState.CREATE_TABLE_PRE_OPERATION;<a name="line.170"></a>
-<span class="sourceLineNo">171</span> }<a name="line.171"></a>
-<span class="sourceLineNo">172</span><a name="line.172"></a>
-<span class="sourceLineNo">173</span> @Override<a name="line.173"></a>
-<span class="sourceLineNo">174</span> public TableName getTableName() {<a name="line.174"></a>
-<span class="sourceLineNo">175</span> return tableDescriptor.getTableName();<a name="line.175"></a>
-<span class="sourceLineNo">176</span> }<a name="line.176"></a>
-<span class="sourceLineNo">177</span><a name="line.177"></a>
-<span class="sourceLineNo">178</span> @Override<a name="line.178"></a>
-<span class="sourceLineNo">179</span> public TableOperationType getTableOperationType() {<a name="line.179"></a>
-<span class="sourceLineNo">180</span> return TableOperationType.CREATE;<a name="line.180"></a>
-<span class="sourceLineNo">181</span> }<a name="line.181"></a>
-<span class="sourceLineNo">182</span><a name="line.182"></a>
-<span class="sourceLineNo">183</span> @Override<a name="line.183"></a>
-<span class="sourceLineNo">184</span> protected void serializeStateData(ProcedureStateSerializer serializer)<a name="line.184"></a>
-<span class="sourceLineNo">185</span> throws IOException {<a name="line.185"></a>
-<span class="sourceLineNo">186</span> super.serializeStateData(serializer);<a name="line.186"></a>
-<span class="sourceLineNo">187</span><a name="line.187"></a>
-<span class="sourceLineNo">188</span> MasterProcedureProtos.CreateTableStateData.Builder state =<a name="line.188"></a>
-<span class="sourceLineNo">189</span> MasterProcedureProtos.CreateTableStateData.newBuilder()<a name="line.189"></a>
-<span class="sourceLineNo">190</span> .setUserInfo(MasterProcedureUtil.toProtoUserInfo(getUser()))<a name="line.190"></a>
-<span class="sourceLineNo">191</span> .setTableSchema(ProtobufUtil.toTableSchema(tableDescriptor));<a name="line.191"></a>
-<span class="sourceLineNo">192</span> if (newRegions != null) {<a name="line.192"></a>
-<span class="sourceLineNo">193</span> for (RegionInfo hri: newRegions) {<a name="line.193"></a>
-<span class="sourceLineNo">194</span> state.addRegionInfo(ProtobufUtil.toRegionInfo(hri));<a name="line.194"></a>
-<span class="sourceLineNo">195</span> }<a name="line.195"></a>
-<span class="sourceLineNo">196</span> }<a name="line.196"></a>
-<span class="sourceLineNo">197</span> serializer.serialize(state.build());<a name="line.197"></a>
-<span class="sourceLineNo">198</span> }<a name="line.198"></a>
-<span class="sourceLineNo">199</span><a name="line.199"></a>
-<span class="sourceLineNo">200</span> @Override<a name="line.200"></a>
-<span class="sourceLineNo">201</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.201"></a>
-<span class="sourceLineNo">202</span> throws IOException {<a name="line.202"></a>
-<span class="sourceLineNo">203</span> super.deserializeStateData(serializer);<a name="line.203"></a>
-<span class="sourceLineNo">204</span><a name="line.204"></a>
-<span class="sourceLineNo">205</span> MasterProcedureProtos.CreateTableStateData state =<a name="line.205"></a>
-<span class="sourceLineNo">206</span> serializer.deserialize(MasterProcedureProtos.CreateTableStateData.class);<a name="line.206"></a>
-<span class="sourceLineNo">207</span> setUser(MasterProcedureUtil.toUserInfo(state.getUserInfo()));<a name="line.207"></a>
-<span class="sourceLineNo">208</span> tableDescriptor = ProtobufUtil.toTableDescriptor(state.getTableSchema());<a name="line.208"></a>
-<span class="sourceLineNo">209</span> if (state.getRegionInfoCount() == 0) {<a name="line.209"></a>
-<span class="sourceLineNo">210</span> newRegions = null;<a name="line.210"></a>
-<span class="sourceLineNo">211</span> } else {<a name="line.211"></a>
-<span class="sourceLineNo">212</span> newRegions = new ArrayList<>(state.getRegionInfoCount());<a name="line.212"></a>
-<span class="sourceLineNo">213</span> for (HBaseProtos.RegionInfo hri: state.getRegionInfoList()) {<a name="line.213"></a>
-<span class="sourceLineNo">214</span> newRegions.add(ProtobufUtil.toRegionInfo(hri));<a name="line.214"></a>
-<span class="sourceLineNo">215</span> }<a name="line.215"></a>
-<span class="sourceLineNo">216</span> }<a name="line.216"></a>
-<span class="sourceLineNo">217</span> }<a name="line.217"></a>
-<span class="sourceLineNo">218</span><a name="line.218"></a>
-<span class="sourceLineNo">219</span> @Override<a name="line.219"></a>
-<span class="sourceLineNo">220</span> protected LockState acquireLock(final MasterProcedureEnv env) {<a name="line.220"></a>
-<span class="sourceLineNo">221</span> if (!getTableName().isSystemTable() && env.waitInitialized(this)) {<a name="line.221"></a>
-<span class="sourceLineNo">222</span> return LockState.LOCK_EVENT_WAIT;<a name="line.222"></a>
-<span class="sourceLineNo">223</span> }<a name="line.223"></a>
-<span class="sourceLineNo">224</span> if (env.getProcedureScheduler().waitTableExclusiveLock(this, getTableName())) {<a name="line.224"></a>
+<span class="sourceLineNo">045</span>import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hbase.thirdparty.com.google.common.collect.Lists;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.CreateTableState;<a name="line.50"></a>
+<span class="sourceLineNo">051</span><a name="line.51"></a>
+<span class="sourceLineNo">052</span>@InterfaceAudience.Private<a name="line.52"></a>
+<span class="sourceLineNo">053</span>public class CreateTableProcedure<a name="line.53"></a>
+<span class="sourceLineNo">054</span> extends AbstractStateMachineTableProcedure<CreateTableState> {<a name="line.54"></a>
+<span class="sourceLineNo">055</span> private static final Logger LOG = LoggerFactory.getLogger(CreateTableProcedure.class);<a name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span> private TableDescriptor tableDescriptor;<a name="line.57"></a>
+<span class="sourceLineNo">058</span> private List<RegionInfo> newRegions;<a name="line.58"></a>
+<span class="sourceLineNo">059</span><a name="line.59"></a>
+<span class="sourceLineNo">060</span> public CreateTableProcedure() {<a name="line.60"></a>
+<span class="sourceLineNo">061</span> // Required by the Procedure framework to create the procedure on replay<a name="line.61"></a>
+<span class="sourceLineNo">062</span> super();<a name="line.62"></a>
+<span class="sourceLineNo">063</span> }<a name="line.63"></a>
+<span class="sourceLineNo">064</span><a name="line.64"></a>
+<span class="sourceLineNo">065</span> public CreateTableProcedure(final MasterProcedureEnv env,<a name="line.65"></a>
+<span class="sourceLineNo">066</span> final TableDescriptor tableDescriptor, final RegionInfo[] newRegions) {<a name="line.66"></a>
+<span class="sourceLineNo">067</span> this(env, tableDescriptor, newRegions, null);<a name="line.67"></a>
+<span class="sourceLineNo">068</span> }<a name="line.68"></a>
+<span class="sourceLineNo">069</span><a name="line.69"></a>
+<span class="sourceLineNo">070</span> public CreateTableProcedure(final MasterProcedureEnv env,<a name="line.70"></a>
+<span class="sourceLineNo">071</span> final TableDescriptor tableDescriptor, final RegionInfo[] newRegions,<a name="line.71"></a>
+<span class="sourceLineNo">072</span> final ProcedurePrepareLatch syncLatch) {<a name="line.72"></a>
+<span class="sourceLineNo">073</span> super(env, syncLatch);<a name="line.73"></a>
+<span class="sourceLineNo">074</span> this.tableDescriptor = tableDescriptor;<a name="line.74"></a>
+<span class="sourceLineNo">075</span> this.newRegions = newRegions != null ? Lists.newArrayList(newRegions) : null;<a name="line.75"></a>
+<span class="sourceLineNo">076</span> }<a name="line.76"></a>
+<span class="sourceLineNo">077</span><a name="line.77"></a>
+<span class="sourceLineNo">078</span> @Override<a name="line.78"></a>
+<span class="sourceLineNo">079</span> protected Flow executeFromState(final MasterProcedureEnv env, final CreateTableState state)<a name="line.79"></a>
+<span class="sourceLineNo">080</span> throws InterruptedException {<a name="line.80"></a>
+<span class="sourceLineNo">081</span> if (LOG.isTraceEnabled()) {<a name="line.81"></a>
+<span class="sourceLineNo">082</span> LOG.trace(this + " execute state=" + state);<a name="line.82"></a>
+<span class="sourceLineNo">083</span> }<a name="line.83"></a>
+<span class="sourceLineNo">084</span> try {<a name="line.84"></a>
+<span class="sourceLineNo">085</span> switch (state) {<a name="line.85"></a>
+<span class="sourceLineNo">086</span> case CREATE_TABLE_PRE_OPERATION:<a name="line.86"></a>
+<span class="sourceLineNo">087</span> // Verify if we can create the table<a name="line.87"></a>
+<span class="sourceLineNo">088</span> boolean exists = !prepareCreate(env);<a name="line.88"></a>
+<span class="sourceLineNo">089</span> releaseSyncLatch();<a name="line.89"></a>
+<span class="sourceLineNo">090</span><a name="line.90"></a>
+<span class="sourceLineNo">091</span> if (exists) {<a name="line.91"></a>
+<span class="sourceLineNo">092</span> assert isFailed() : "the delete should have an exception here";<a name="line.92"></a>
+<span class="sourceLineNo">093</span> return Flow.NO_MORE_STATE;<a name="line.93"></a>
+<span class="sourceLineNo">094</span> }<a name="line.94"></a>
+<span class="sourceLineNo">095</span><a name="line.95"></a>
+<span class="sourceLineNo">096</span> preCreate(env);<a name="line.96"></a>
+<span class="sourceLineNo">097</span> setNextState(CreateTableState.CREATE_TABLE_WRITE_FS_LAYOUT);<a name="line.97"></a>
+<span class="sourceLineNo">098</span> break;<a name="line.98"></a>
+<span class="sourceLineNo">099</span> case CREATE_TABLE_WRITE_FS_LAYOUT:<a name="line.99"></a>
+<span class="sourceLineNo">100</span> DeleteTableProcedure.deleteFromFs(env, getTableName(), newRegions, true);<a name="line.100"></a>
+<span class="sourceLineNo">101</span> newRegions = createFsLayout(env, tableDescriptor, newRegions);<a name="line.101"></a>
+<span class="sourceLineNo">102</span> setNextState(CreateTableState.CREATE_TABLE_ADD_TO_META);<a name="line.102"></a>
+<span class="sourceLineNo">103</span> break;<a name="line.103"></a>
+<span class="sourceLineNo">104</span> case CREATE_TABLE_ADD_TO_META:<a name="line.104"></a>
+<span class="sourceLineNo">105</span> newRegions = addTableToMeta(env, tableDescriptor, newRegions);<a name="line.105"></a>
+<span class="sourceLineNo">106</span> setNextState(CreateTableState.CREATE_TABLE_ASSIGN_REGIONS);<a name="line.106"></a>
+<span class="sourceLineNo">107</span> break;<a name="line.107"></a>
+<span class="sourceLineNo">108</span> case CREATE_TABLE_ASSIGN_REGIONS:<a name="line.108"></a>
+<span class="sourceLineNo">109</span> setEnablingState(env, getTableName());<a name="line.109"></a>
+<span class="sourceLineNo">110</span> addChildProcedure(env.getAssignmentManager()<a name="line.110"></a>
+<span class="sourceLineNo">111</span> .createRoundRobinAssignProcedures(newRegions));<a name="line.111"></a>
+<span class="sourceLineNo">112</span> setNextState(CreateTableState.CREATE_TABLE_UPDATE_DESC_CACHE);<a name="line.112"></a>
+<span class="sourceLineNo">113</span> break;<a name="line.113"></a>
+<span class="sourceLineNo">114</span> case CREATE_TABLE_UPDATE_DESC_CACHE:<a name="line.114"></a>
+<span class="sourceLineNo">115</span> setEnabledState(env, getTableName());<a name="line.115"></a>
+<span class="sourceLineNo">116</span> updateTableDescCache(env, getTableName());<a name="line.116"></a>
+<span class="sourceLineNo">117</span> setNextState(CreateTableState.CREATE_TABLE_POST_OPERATION);<a name="line.117"></a>
+<span class="sourceLineNo">118</span> break;<a name="line.118"></a>
+<span class="sourceLineNo">119</span> case CREATE_TABLE_POST_OPERATION:<a name="line.119"></a>
+<span class="sourceLineNo">120</span> postCreate(env);<a name="line.120"></a>
+<span class="sourceLineNo">121</span> return Flow.NO_MORE_STATE;<a name="line.121"></a>
+<span class="sourceLineNo">122</span> default:<a name="line.122"></a>
+<span class="sourceLineNo">123</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.123"></a>
+<span class="sourceLineNo">124</span> }<a name="line.124"></a>
+<span class="sourceLineNo">125</span> } catch (IOException e) {<a name="line.125"></a>
+<span class="sourceLineNo">126</span> if (isRollbackSupported(state)) {<a name="line.126"></a>
+<span class="sourceLineNo">127</span> setFailure("master-create-table", e);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> } else {<a name="line.128"></a>
+<span class="sourceLineNo">129</span> LOG.warn("Retriable error trying to create table=" + getTableName() + " state=" + state, e);<a name="line.129"></a>
+<span class="sourceLineNo">130</span> }<a name="line.130"></a>
+<span class="sourceLineNo">131</span> }<a name="line.131"></a>
+<span class="sourceLineNo">132</span> return Flow.HAS_MORE_STATE;<a name="line.132"></a>
+<span class="sourceLineNo">133</span> }<a name="line.133"></a>
+<span class="sourceLineNo">134</span><a name="line.134"></a>
+<span class="sourceLineNo">135</span> @Override<a name="line.135"></a>
+<span class="sourceLineNo">136</span> protected void rollbackState(final MasterProcedureEnv env, final CreateTableState state)<a name="line.136"></a>
+<span class="sourceLineNo">137</span> throws IOException {<a name="line.137"></a>
+<span class="sourceLineNo">138</span> if (state == CreateTableState.CREATE_TABLE_PRE_OPERATION) {<a name="line.138"></a>
+<span class="sourceLineNo">139</span> // nothing to rollback, pre-create is just table-state checks.<a name="line.139"></a>
+<span class="sourceLineNo">140</span> // We can fail if the table does exist or the descriptor is malformed.<a name="line.140"></a>
+<span class="sourceLineNo">141</span> // TODO: coprocessor rollback semantic is still undefined.<a name="line.141"></a>
+<span class="sourceLineNo">142</span> DeleteTableProcedure.deleteTableStates(env, getTableName());<a name="line.142"></a>
+<span class="sourceLineNo">143</span> releaseSyncLatch();<a name="line.143"></a>
+<span class="sourceLineNo">144</span> return;<a name="line.144"></a>
+<span class="sourceLineNo">145</span> }<a name="line.145"></a>
+<span class="sourceLineNo">146</span><a name="line.146"></a>
+<span class="sourceLineNo">147</span> // The procedure doesn't have a rollback. The execution will succeed, at some point.<a name="line.147"></a>
+<span class="sourceLineNo">148</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.148"></a>
+<span class="sourceLineNo">149</span> }<a name="line.149"></a>
+<span class="sourceLineNo">150</span><a name="line.150"></a>
+<span class="sourceLineNo">151</span> @Override<a name="line.151"></a>
+<span class="sourceLineNo">152</span> protected boolean isRollbackSupported(final CreateTableState state) {<a name="line.152"></a>
+<span class="sourceLineNo">153</span> switch (state) {<a name="line.153"></a>
+<span class="sourceLineNo">154</span> case CREATE_TABLE_PRE_OPERATION:<a name="line.154"></a>
+<span class="sourceLineNo">155</span> return true;<a name="line.155"></a>
+<span class="sourceLineNo">156</span> default:<a name="line.156"></a>
+<span class="sourceLineNo">157</span> return false;<a name="line.157"></a>
+<span class="sourceLineNo">158</span> }<a name="line.158"></a>
+<span class="sourceLineNo">159</span> }<a name="line.159"></a>
+<span class="sourceLineNo">160</span><a name="line.160"></a>
+<span class="sourceLineNo">161</span> @Override<a name="line.161"></a>
+<span class="sourceLineNo">162</span> protected CreateTableState getState(final int stateId) {<a name="line.162"></a>
+<span class="sourceLineNo">163</span> return CreateTableState.valueOf(stateId);<a name="line.163"></a>
+<span class="sourceLineNo">164</span> }<a name="line.164"></a>
+<span class="sourceLineNo">165</span><a name="line.165"></a>
+<span class="sourceLineNo">166</span> @Override<a name="line.166"></a>
+<span class="sourceLineNo">167</span> protected int getStateId(final CreateTableState state) {<a name="line.167"></a>
+<span class="sourceLineNo">168</span> return state.getNumber();<a name="line.168"></a>
+<span class="sourceLineNo">169</span> }<a name="line.169"></a>
+<span class="sourceLineNo">170</span><a name="line.170"></a>
+<span class="sourceLineNo">171</span> @Override<a name="line.171"></a>
+<span class="sourceLineNo">172</span> protected CreateTableState getInitialState() {<a name="line.172"></a>
+<span class="sourceLineNo">173</span> return CreateTableState.CREATE_TABLE_PRE_OPERATION;<a name="line.173"></a>
+<span class="sourceLineNo">174</span> }<a name="line.174"></a>
+<span class="sourceLineNo">175</span><a name="line.175"></a>
+<span class="sourceLineNo">176</span> @Override<a name="line.176"></a>
+<span class="sourceLineNo">177</span> public TableName getTableName() {<a name="line.177"></a>
+<span class="sourceLineNo">178</span> return tableDescriptor.getTableName();<a name="line.178"></a>
+<span class="sourceLineNo">179</span> }<a name="line.179"></a>
+<span class="sourceLineNo">180</span><a name="line.180"></a>
+<span class="sourceLineNo">181</span> @Override<a name="line.181"></a>
+<span class="sourceLineNo">182</span> public TableOperationType getTableOperationType() {<a name="line.182"></a>
+<span class="sourceLineNo">183</span> return TableOperationType.CREATE;<a name="line.183"></a>
+<span class="sourceLineNo">184</span> }<a name="line.184"></a>
+<span class="sourceLineNo">185</span><a name="line.185"></a>
+<span class="sourceLineNo">186</span> @Override<a name="line.186"></a>
+<span class="sourceLineNo">187</span> protected void serializeStateData(ProcedureStateSerializer serializer)<a name="line.187"></a>
+<span class="sourceLineNo">188</span> throws IOException {<a name="line.188"></a>
+<span class="sourceLineNo">189</span> super.serializeStateData(serializer);<a name="line.189"></a>
+<span class="sourceLineNo">190</span><a name="line.190"></a>
+<span class="sourceLineNo">191</span> MasterProcedureProtos.CreateTableStateData.Builder state =<a name="line.191"></a>
+<span class="sourceLineNo">192</span> MasterProcedureProtos.CreateTableStateData.newBuilder()<a name="line.192"></a>
+<span class="sourceLineNo">193</span> .setUserInfo(MasterProcedureUtil.toProtoUserInfo(getUser()))<a name="line.193"></a>
+<span class="sourceLineNo">194</span> .setTableSchema(ProtobufUtil.toTableSchema(tableDescriptor));<a name="line.194"></a>
+<span class="sourceLineNo">195</span> if (newRegions != null) {<a name="line.195"></a>
+<span class="sourceLineNo">196</span> for (RegionInfo hri: newRegions) {<a name="line.196"></a>
+<span class="sourceLineNo">197</span> state.addRegionInfo(ProtobufUtil.toRegionInfo(hri));<a name="line.197"></a>
+<span class="sourceLineNo">198</span> }<a name="line.198"></a>
+<span class="sourceLineNo">199</span> }<a name="line.199"></a>
+<span class="sourceLineNo">200</span> serializer.serialize(state.build());<a name="line.200"></a>
+<span class="sourceLineNo">201</span> }<a name="line.201"></a>
+<span class="sourceLineNo">202</span><a name="line.202"></a>
+<span class="sourceLineNo">203</span> @Override<a name="line.203"></a>
+<span class="sourceLineNo">204</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.204"></a>
+<span class="sourceLineNo">205</span> throws IOException {<a name="line.205"></a>
+<span class="sourceLineNo">206</span> super.deserializeStateData(serializer);<a name="line.206"></a>
+<span class="sourceLineNo">207</span><a name="line.207"></a>
+<span class="sourceLineNo">208</span> MasterProcedureProtos.CreateTableStateData state =<a name="line.208"></a>
+<span class="sourceLineNo">209</span> serializer.deserialize(MasterProcedureProtos.CreateTableStateData.class);<a name="line.209"></a>
+<span class="sourceLineNo">210</span> setUser(MasterProcedureUtil.toUserInfo(state.getUserInfo()));<a name="line.210"></a>
+<span class="sourceLineNo">211</span> tableDescriptor = ProtobufUtil.toTableDescriptor(state.getTableSchema());<a name="line.211"></a>
+<span class="sourceLineNo">212</span> if (state.getRegionInfoCount() == 0) {<a name="line.212"></a>
+<span class="sourceLineNo">213</span> newRegions = null;<a name="line.213"></a>
+<span class="sourceLineNo">214</span> } else {<a name="line.214"></a>
+<span class="sourceLineNo">215</span> newRegions = new ArrayList<>(state.getRegionInfoCount());<a name="line.215"></a>
+<span class="sourceLineNo">216</span> for (HBaseProtos.RegionInfo hri: state.getRegionInfoList()) {<a name="line.216"></a>
+<span class="sourceLineNo">217</span> newRegions.add(ProtobufUtil.toRegionInfo(hri));<a name="line.217"></a>
+<span class="sourceLineNo">218</span> }<a name="line.218"></a>
+<span class="sourceLineNo">219</span> }<a name="line.219"></a>
+<span class="sourceLineNo">220</span> }<a name="line.220"></a>
+<span class="sourceLineNo">221</span><a name="line.221"></a>
+<span class="sourceLineNo">222</span> @Override<a name="line.222"></a>
+<span class="sourceLineNo">223</span> protected LockState acquireLock(final MasterProcedureEnv env) {<a name="line.223"></a>
+<span class="sourceLineNo">224</span> if (!getTableName().isSystemTable() && env.waitInitialized(this)) {<a name="line.224"></a>
<span class="sourceLineNo">225</span> return LockState.LOCK_EVENT_WAIT;<a name="line.225"></a>
<span class="sourceLineNo">226</span> }<a name="line.226"></a>
-<span class="sourceLineNo">227</span> return LockState.LOCK_ACQUIRED;<a name="line.227"></a>
-<span class="sourceLineNo">228</span> }<a name="line.228"></a>
-<span class="sourceLineNo">229</span><a name="line.229"></a>
-<span class="sourceLineNo">230</span> private boolean prepareCreate(final MasterProcedureEnv env) throws IOException {<a name="line.230"></a>
-<span class="sourceLineNo">231</span> final TableName tableName = getTableName();<a name="line.231"></a>
-<span class="sourceLineNo">232</span> if (MetaTableAccessor.tableExists(env.getMasterServices().getConnection(), tableName)) {<a name="line.232"></a>
-<span class="sourceLineNo">233</span> setFailure("master-create-table", new TableExistsException(getTableName()));<a name="line.233"></a>
-<span class="sourceLineNo">234</span> return false;<a name="line.234"></a>
-<span class="sourceLineNo">235</span> }<a name="line.235"></a>
-<span class="sourceLineNo">236</span><a name="line.236"></a>
-<span class="sourceLineNo">237</span> // check that we have at least 1 CF<a name="line.237"></a>
-<span class="sourceLineNo">238</span> if (tableDescriptor.getColumnFamilyCount() == 0) {<a name="line.238"></a>
-<span class="sourceLineNo">239</span> setFailure("master-create-table", new DoNotRetryIOException("Table " +<a name="line.239"></a>
-<span class="sourceLineNo">240</span> getTableName().toString() + " should have at least one column family."));<a name="line.240"></a>
-<span class="sourceLineNo">241</span> return false;<a name="line.241"></a>
-<span class="sourceLineNo">242</span> }<a name="line.242"></a>
-<span class="sourceLineNo">243</span><a name="line.243"></a>
-<span class="sourceLineNo">244</span> return true;<a name="line.244"></a>
-<span class="sourceLineNo">245</span> }<a name="line.245"></a>
+<span class="sourceLineNo">227</span> if (env.getProcedureScheduler().waitTableExclusiveLock(this, getTableName())) {<a name="line.227"></a>
+<span class="sourceLineNo">228</span> return LockState.LOCK_EVENT_WAIT;<a name="line.228"></a>
+<span class="sourceLineNo">229</span> }<a name="line.229"></a>
+<span class="sourceLineNo">230</span> return LockState.LOCK_ACQUIRED;<a name="line.230"></a>
+<span class="sourceLineNo">231</span> }<a name="line.231"></a>
+<span class="sourceLineNo">232</span><a name="line.232"></a>
+<span class="sourceLineNo">233</span> private boolean prepareCreate(final MasterProcedureEnv env) throws IOException {<a name="line.233"></a>
+<span class="sourceLineNo">234</span> final TableName tableName = getTableName();<a name="line.234"></a>
+<span class="sourceLineNo">235</span> if (MetaTableAccessor.tableExists(env.getMasterServices().getConnection(), tableName)) {<a name="line.235"></a>
+<span class="sourceLineNo">236</span> setFailure("master-create-table", new TableExistsException(getTableName()));<a name="line.236"></a>
+<span class="sourceLineNo">237</span> return false;<a name="line.237"></a>
+<span class="sourceLineNo">238</span> }<a name="line.238"></a>
+<span class="sourceLineNo">239</span><a name="line.239"></a>
+<span class="sourceLineNo">240</span> // check that we have at least 1 CF<a name="line.240"></a>
+<span class="sourceLineNo">241</span> if (tableDescriptor.getColumnFamilyCount() == 0) {<a name="line.241"></a>
+<span class="sourceLineNo">242</span> setFailure("master-create-table", new DoNotRetryIOException("Table " +<a name="line.242"></a>
+<span class="sourceLineNo">243</span> getTableName().toString() + " should have at least one column family."));<a name="line.243"></a>
+<span class="sourceLineNo">244</span> return false;<a name="line.244"></a>
+<span class="sourceLineNo">245</span> }<a name="line.245"></a>
<span class="sourceLineNo">246</span><a name="line.246"></a>
-<span class="sourceLineNo">247</span> private void preCreate(final MasterProcedureEnv env)<a name="line.247"></a>
-<span class="sourceLineNo">248</span> throws IOException, InterruptedException {<a name="line.248"></a>
-<span class="sourceLineNo">249</span> if (!getTableName().isSystemTable()) {<a name="line.249"></a>
-<span class="sourceLineNo">250</span> ProcedureSyncWait.getMasterQuotaManager(env)<a name="line.250"></a>
-<span class="sourceLineNo">251</span> .checkNamespaceTableAndRegionQuota(<a name="line.251"></a>
-<span class="sourceLineNo">252</span> getTableName(), (newRegions != null ? newRegions.size() : 0));<a name="line.252"></a>
-<span class="sourceLineNo">253</span> }<a name="line.253"></a>
-<span class="sourceLineNo">254</span><a name="line.254"></a>
-<span class="sourceLineNo">255</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.255"></a>
-<span class="sourceLineNo">256</span> if (cpHost != null) {<a name="line.256"></a>
-<span class="sourceLineNo">257</span> final RegionInfo[] regions = newRegions == null ? null :<a name="line.257"></a>
-<span class="sourceLineNo">258</span> newRegions.toArray(new RegionInfo[newRegions.size()]);<a name="line.258"></a>
-<span class="sourceLineNo">259</span> cpHost.preCreateTableAction(tableDescriptor, regions, getUser());<a name="line.259"></a>
-<span class="sourceLineNo">260</span> }<a name="line.260"></a>
-<span class="sourceLineNo">261</span> }<a name="line.261"></a>
-<span class="sourceLineNo">262</span><a name="line.262"></a>
-<span class="sourceLineNo">263</span> private void postCreate(final MasterProcedureEnv env)<a name="line.263"></a>
-<span class="sourceLineNo">264</span> throws IOException, InterruptedException {<a name="line.264"></a>
-<span class="sourceLineNo">265</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.265"></a>
-<span class="sourceLineNo">266</span> if (cpHost != null) {<a name="line.266"></a>
-<span class="sourceLineNo">267</span> final RegionInfo[] regions = (newRegions == null) ? null :<a name="line.267"></a>
-<span class="sourceLineNo">268</span> newRegions.toArray(new RegionInfo[newRegions.size()]);<a name="line.268"></a>
-<span class="sourceLineNo">269</span> cpHost.postCompletedCreateTableAction(tableDescriptor, regions, getUser());<a name="line.269"></a>
-<span class="sourceLineNo">270</span> }<a name="line.270"></a>
-<span class="sourceLineNo">271</span> }<a name="line.271"></a>
-<span class="sourceLineNo">272</span><a name="line.272"></a>
-<span class="sourceLineNo">273</span> protected interface CreateHdfsRegions {<a name="line.273"></a>
-<span class="sourceLineNo">274</span> List<RegionInfo> createHdfsRegions(final MasterProcedureEnv env,<a name="line.274"></a>
-<span class="sourceLineNo">275</span> final Path tableRootDir, final TableName tableName,<a name="line.275"></a>
-<span class="sourceLineNo">276</span> final List<RegionInfo> newRegions) throws IOException;<a name="line.276"></a>
-<span class="sourceLineNo">277</span> }<a name="line.277"></a>
-<span class="sourceLineNo">278</span><a name="line.278"></a>
-<span class="sourceLineNo">279</span> protected static List<RegionInfo> createFsLayout(final MasterProcedureEnv env,<a name="line.279"></a>
-<span class="sourceLineNo">280</span> final TableDescriptor tableDescriptor, final List<RegionInfo> newRegions)<a name="line.280"></a>
-<span class="sourceLineNo">281</span> throws IOException {<a name="line.281"></a>
-<span class="sourceLineNo">282</span> return createFsLayout(env, tableDescriptor, newRegions, new CreateHdfsRegions() {<a name="line.282"></a>
-<span class="sourceLineNo">283</span> @Override<a name="line.283"></a>
-<span class="sourceLineNo">284</span> public List<RegionInfo> createHdfsRegions(final MasterProcedureEnv env,<a name="line.284"></a>
-<span class="sourceLineNo">285</span> final Path tableRootDir, final TableName tableName,<a name="line.285"></a>
-<span class="sourceLineNo">286</span> final List<RegionInfo> newRegions) throws IOException {<a name="line.286"></a>
-<span class="sourceLineNo">287</span> RegionInfo[] regions = newRegions != null ?<a name="line.287"></a>
-<span class="sourceLineNo">288</span> newRegions.toArray(new RegionInfo[newRegions.size()]) : null;<a name="line.288"></a>
-<span class="sourceLineNo">289</span> return ModifyRegionUtils.createRegions(env.getMasterConfiguration(),<a name="line.289"></a>
-<span class="sourceLineNo">290</span> tableRootDir, tableDescriptor, regions, null);<a name="line.290"></a>
-<span class="sourceLineNo">291</span> }<a name="line.291"></a>
-<span class="sourceLineNo">292</span> });<a name="line.292"></a>
-<span class="sourceLineNo">293</span> }<a name="line.293"></a>
-<span class="sourceLineNo">294</span><a name="line.294"></a>
-<span class="sourceLineNo">295</span> protected static List<RegionInfo> createFsLayout(final MasterProcedureEnv env,<a name="line.295"></a>
-<span class="sourceLineNo">296</span> final TableDescriptor tableDescriptor, List<RegionInfo> newRegions,<a name="line.296"></a>
-<span class="sourceLineNo">297</span> final CreateHdfsRegions hdfsRegionHandler) throws IOException {<a name="line.297"></a>
-<span class="sourceLineNo">298</span> final MasterFileSystem mfs = env.getMasterServices().getMasterFileSystem();<a name="line.298"></a>
-<span class="sourceLineNo">299</span> final Path tempdir = mfs.getTempDir();<a name="line.299"></a>
-<span class="sourceLineNo">300</span><a name="line.300"></a>
-<span class="sourceLineNo">301</span> // 1. Create Table Descriptor<a name="line.301"></a>
-<span class="sourceLineNo">302</span> // using a copy of descriptor, table will be created enabling first<a name="line.302"></a>
-<span class="sourceLineNo">303</span> final Path tempTableDir = FSUtils.getTableDir(tempdir, tableDescriptor.getTableName());<a name="line.303"></a>
-<span class="sourceLineNo">304</span> ((FSTableDescriptors)(env.getMasterServices().getTableDescriptors()))<a name="line.304"></a>
-<span class="sourceLineNo">305</span> .createTableDescriptorForTableDirectory(<a name="line.305"></a>
-<span class="sourceLineNo">306</span> tempTableDir, tableDescriptor, false);<a name="line.306"></a>
-<span class="sourceLineNo">307</span><a name="line.307"></a>
-<span class="sourceLineNo">308</span> // 2. Create Regions<a name="line.308"></a>
-<span class="sourceLineNo">309</span> newRegions = hdfsRegionHandler.createHdfsRegions(env, tempdir,<a name="line.309"></a>
-<span class="sourceLineNo">310</span> tableDescriptor.getTableName(), newRegions);<a name="line.310"></a>
-<span class="sourceLineNo">311</span><a name="line.311"></a>
-<span class="sourceLineNo">312</span> // 3. Move Table temp directory to the hbase root location<a name="line.312"></a>
-<span class="sourceLineNo">313</span> moveTempDirectoryToHBaseRoot(env, tableDescriptor, tempTableDir);<a name="line.313"></a>
+<span class="sourceLineNo">247</span> return true;<a name="line.247"></a>
+<span class="sourceLineNo">248</span> }<a name="line.248"></a>
+<span class="sourceLineNo">249</span><a name="line.249"></a>
+<span class="sourceLineNo">250</span> private void preCreate(final MasterProcedureEnv env)<a name="line.250"></a>
+<span class="sourceLineNo">251</span> throws IOException, InterruptedException {<a name="line.251"></a>
+<span class="sourceLineNo">252</span> if (!getTableName().isSystemTable()) {<a name="line.252"></a>
+<span class="sourceLineNo">253</span> ProcedureSyncWait.getMasterQuotaManager(env)<a name="line.253"></a>
+<span class="sourceLineNo">254</span> .checkNamespaceTableAndRegionQuota(<a name="line.254"></a>
+<span class="sourceLineNo">255</span> getTableName(), (newRegions != null ? newRegions.size() : 0));<a name="line.255"></a>
+<span class="sourceLineNo">256</span> }<a name="line.256"></a>
+<span class="sourceLineNo">257</span><a name="line.257"></a>
+<span class="sourceLineNo">258</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.258"></a>
+<span class="sourceLineNo">259</span> if (cpHost != null) {<a name="line.259"></a>
+<span class="sourceLineNo">260</span> final RegionInfo[] regions = newRegions == null ? null :<a name="line.260"></a>
+<span class="sourceLineNo">261</span> newRegions.toArray(new RegionInfo[newRegions.size()]);<a name="line.261"></a>
+<span class="sourceLineNo">262</span> cpHost.preCreateTableAction(tableDescriptor, regions, getUser());<a name="line.262"></a>
+<span class="sourceLineNo">263</span> }<a name="line.263"></a>
+<span class="sourceLineNo">264</span> }<a name="line.264"></a>
+<span class="sourceLineNo">265</span><a name="line.265"></a>
+<span class="sourceLineNo">266</span> private void postCreate(final MasterProcedureEnv env)<a name="line.266"></a>
+<span class="sourceLineNo">267</span> throws IOException, InterruptedException {<a name="line.267"></a>
+<span class="sourceLineNo">268</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.268"></a>
+<span class="sourceLineNo">269</span> if (cpHost != null) {<a name="line.269"></a>
+<span class="sourceLineNo">270</span> final RegionInfo[] regions = (newRegions == null) ? null :<a name="line.270"></a>
+<span class="sourceLineNo">271</span> newRegions.toArray(new RegionInfo[newRegions.size()]);<a name="line.271"></a>
+<span class="sourceLineNo">272</span> cpHost.postCompletedCreateTableAction(tableDescriptor, regions, getUser());<a name="line.272"></a>
+<span class="sourceLineNo">273</span> }<a name="line.273"></a>
+<span class="sourceLineNo">274</span> }<a name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span> protected interface CreateHdfsRegions {<a name="line.276"></a>
+<span class="sourceLineNo">277</span> List<RegionInfo> createHdfsRegions(final MasterProcedureEnv env,<a name="line.277"></a>
+<span class="sourceLineNo">278</span> final Path tableRootDir, final TableName tableName,<a name="line.278"></a>
+<span class="sourceLineNo">279</span> final List<RegionInfo> newRegions) throws IOException;<a name="line.279"></a>
+<span class="sourceLineNo">280</span> }<a name="line.280"></a>
+<span class="sourceLineNo">281</span><a name="line.281"></a>
+<span class="sourceLineNo">282</span> protected static List<RegionInfo> createFsLayout(final MasterProcedureEnv env,<a name="line.282"></a>
+<span class="sourceLineNo">283</span> final TableDescriptor tableDescriptor, final List<RegionInfo> newRegions)<a name="line.283"></a>
+<span class="sourceLineNo">284</span> throws IOException {<a name="line.284"></a>
+<span class="sourceLineNo">285</span> return createFsLayout(env, tableDescriptor, newRegions, new CreateHdfsRegions() {<a name="line.285"></a>
+<span class="sourceLineNo">286</span> @Override<a name="line.286"></a>
+<span class="sourceLineNo">287</span> public List<RegionInfo> createHdfsRegions(final MasterProcedureEnv env,<a name="line.287"></a>
+<span class="sourceLineNo">288</span> final Path tableRootDir, final TableName tableName,<a name="line.288"></a>
+<span class="sourceLineNo">289</span> final List<RegionInfo> newRegions) throws IOException {<a name="line.289"></a>
+<span class="sourceLineNo">290</span> RegionInfo[] regions = newRegions != null ?<a name="line.290"></a>
+<span class="sourceLineNo">291</span> newRegions.toArray(new RegionInfo[newRegions.size()]) : null;<a name="line.291"></a>
+<span class="sourceLineNo">292</span> return ModifyRegionUtils.createRegions(env.getMasterConfiguration(),<a name="line.292"></a>
+<span class="sourceLineNo">293</span> tableRootDir, tableDescriptor, regions, null);<a name="line.293"></a>
+<span class="sourceLineNo">294</span> }<a name="line.294"></a>
+<span class="sourceLineNo">295</span> });<a name="line.295"></a>
+<span class="sourceLineNo">296</span> }<a name="line.296"></a>
+<span class="sourceLineNo">297</span><a name="line.297"></a>
+<span class="sourceLineNo">298</span> protected static List<RegionInfo> createFsLayout(final MasterProcedureEnv env,<a name="line.298"></a>
+<span class="sourceLineNo">299</span> final TableDescriptor tableDescriptor, List<RegionInfo> newRegions,<a name="line.299"></a>
+<span class="sourceLineNo">300</span> final CreateHdfsRegions hdfsRegionHandler) throws IOException {<a name="line.300"></a>
+<span class="sourceLineNo">301</span> final MasterFileSystem mfs = env.getMasterServices().getMasterFileSystem();<a name="line.301"></a>
+<span class="sourceLineNo">302</span> final Path tempdir = mfs.getTempDir();<a name="line.302"></a>
+<span class="sourceLineNo">303</span><a name="line.303"></a>
+<span class="sourceLineNo">304</span> // 1. Create Table Descriptor<a name="line.304"></a>
+<span class="sourceLineNo">305</span> // using a copy of descriptor, table will be created enabling first<a name="line.305"></a>
+<span class="sourceLineNo">306</span> final Path tempTableDir = FSUtils.getTableDir(tempdir, tableDescriptor.getTableName());<a name="line.306"></a>
+<span class="sourceLineNo">307</span> ((FSTableDescriptors)(env.getMasterServices().getTableDescriptors()))<a name="line.307"></a>
+<span class="sourceLineNo">308</span> .createTableDescriptorForTableDirectory(<a name="line.308"></a>
+<span class="sourceLineNo">309</span> tempTableDir, tableDescriptor, false);<a name="line.309"></a>
+<span class="sourceLineNo">310</span><a name="line.310"></a>
+<span class="sourceLineNo">311</span> // 2. Create Regions<a name="line.311"></a>
+<span class="sourceLineNo">312</span> newRegions = hdfsRegionHandler.createHdfsRegions(env, tempdir,<a name="line.312"></a>
+<span class="sourceLineNo">313</span> tableDescriptor.getTableName(), newRegions);<a name="line.313"></a>
<span class="sourceLineNo">314</span><a name="line.314"></a>
-<span class="sourceLineNo">315</span> return newRegions;<a name="line.315"></a>
-<span class="sourceLineNo">316</span> }<a name="line.316"></a>
+<span class="sourceLineNo">315</span> // 3. Move Table temp directory to the hbase root location<a name="line.315"></a>
+<span class="sourceLineNo">316</span> moveTempDirectoryToHBaseRoot(env, tableDescriptor, tempTableDir);<a name="line.316"></a>
<span class="sourceLineNo">317</span><a name="line.317"></a>
-<span class="sourceLineNo">318</span> protected static void moveTempDirectoryToHBaseRoot(<a name="line.318"></a>
-<span class="sourceLineNo">319</span> final MasterProcedureEnv env,<a name="line.319"></a>
-<span class="sourceLineNo">320</span> final TableDescriptor tableDescriptor,<a name="line.320"></a>
-<span class="sourceLineNo">321</span> final Path tempTableDir) throws IOException {<a name="line.321"></a>
-<span class="sourceLineNo">322</span> final MasterFileSystem mfs = env.getMasterServices().getMasterFileSystem();<a name="line.322"></a>
-<span class="sourceLineNo">323</span> final Path tableDir = FSUtils.getTableDir(mfs.getRootDir(), tableDescriptor.getTableName());<a name="line.323"></a>
-<span class="sourceLineNo">324</span> FileSystem fs = mfs.getFileSystem();<a name="line.324"></a>
-<span class="sourceLineNo">325</span> if (!fs.delete(tableDir, true) && fs.exists(tableDir)) {<a name="line.325"></a>
-<span class="sourceLineNo">326</span> throw new IOException("Couldn't delete " + tableDir);<a name="line.326"></a>
-<span class="sourceLineNo">327</span> }<a name="line.327"></a>
-<span class="sourceLineNo">328</span> if (!fs.rename(tempTableDir, tableDir)) {<a name="line.328"></a>
-<span class="sourceLineNo">329</span> throw new IOException("Unable to move table from temp=" + tempTableDir +<a name="line.329"></a>
-<span class="sourceLineNo">330</span> " to hbase root=" + tableDir);<a name="line.330"></a>
-<span class="sourceLineNo">331</span> }<a name="line.331"></a>
-<span class="sourceLineNo">332</span> }<a name="line.332"></a>
-<span class="sourceLineNo">333</span><a name="line.333"></a>
-<span class="sourceLineNo">334</span> protected static List<RegionInfo> addTableToMeta(final MasterProcedureEnv env,<a name="line.334"></a>
-<span class="sourceLineNo">335</span> final TableDescriptor tableDescriptor,<a name="line.335"></a>
-<span class="sourceLineNo">336</span> final List<RegionInfo> regions) throws IOException {<a name="line.336"></a>
-<span class="sourceLineNo">337</span> assert (regions != null && regions.size() > 0) : "expected at least 1 region, got " + regions;<a name="line.337"></a>
-<span class="sourceLineNo">338</span><a name="line.338"></a>
-<span class="sourceLineNo">339</span> ProcedureSyncWait.waitMetaRegions(env);<a name="line.339"></a>
-<span class="sourceLineNo">340</span><a name="line.340"></a>
-<span class="sourceLineNo">341</span> // Add replicas if needed<a name="line.341"></a>
-<span class="sourceLineNo">342</span> // we need to create regions with replicaIds starting from 1<a name="line.342"></a>
-<span class="sourceLineNo">343</span> List<RegionInfo> newRegions = RegionReplicaUtil.addReplicas(tableDescriptor, regions, 1,<a name="line.343"></a>
-<span class="sourceLineNo">344</span> tableDescriptor.getRegionReplication());<a name="line.344"></a>
-<span class="sourceLineNo">345</span><a name="line.345"></a>
-<span class="sourceLineNo">346</span> // Add regions to META<a name="line.346"></a>
-<span class="sourceLineNo">347</span> addRegionsToMeta(env, tableDescriptor, newRegions);<a name="line.347"></a>
+<span class="sourceLineNo">318</span> return newRegions;<a name="line.318"></a>
+<span class="sourceLineNo">319</span> }<a name="line.319"></a>
+<span class="sourceLineNo">320</span><a name="line.320"></a>
+<span class="sourceLineNo">321</span> protected static void moveTempDirectoryToHBaseRoot(<a name="line.321"></a>
+<span class="sourceLineNo">322</span> final MasterProcedureEnv env,<a name="line.322"></a>
+<span class="sourceLineNo">323</span> final TableDescriptor tableDescriptor,<a name="line.323"></a>
+<span class="sourceLineNo">324</span> final Path tempTableDir) throws IOException {<a name="line.324"></a>
+<span class="sourceLineNo">325</span> final MasterFileSystem mfs = env.getMasterServices().getMasterFileSystem();<a name="line.325"></a>
+<span class="sourceLineNo">326</span> final Path tableDir = FSUtils.getTableDir(mfs.getRootDir(), tableDescriptor.getTableName());<a name="line.326"></a>
+<span class="sourceLineNo">327</span> FileSystem fs = mfs.getFileSystem();<a name="line.327"></a>
+<span class="sourceLineNo">328</span> if (!fs.delete(tableDir, true) && fs.exists(tableDir)) {<a name="line.328"></a>
+<span class="sourceLineNo">329</span> throw new IOException("Couldn't delete " + tableDir);<a name="line.329"></a>
+<span class="sourceLineNo">330</span> }<a name="line.330"></a>
+<span class="sourceLineNo">331</span> if (!fs.rename(tempTableDir, tableDir)) {<a name="line.331"></a>
+<span class="sourceLineNo">332</span> throw new IOException("Unable to move table from temp=" + tempTableDir +<a name="line.332"></a>
+<span class="sourceLineNo">333</span> " to hbase root=" + tableDir);<a name="line.333"></a>
+<span class="sourceLineNo">334</span> }<a name="line.334"></a>
+<span class="sourceLineNo">335</span> }<a name="line.335"></a>
+<span class="sourceLineNo">336</span><a name="line.336"></a>
+<span class="sourceLineNo">337</span> protected static List<RegionInfo> addTableToMeta(final MasterProcedureEnv env,<a name="line.337"></a>
+<span class="sourceLineNo">338</span> final TableDescriptor tableDescriptor,<a name="line.338"></a>
+<span class="sourceLineNo">339</span> final List<RegionInfo> regions) throws IOException {<a name="line.339"></a>
+<span class="sourceLineNo">340</span> assert (regions != null && regions.size() > 0) : "expected at least 1 region, got " + regions;<a name="line.340"></a>
+<span class="sourceLineNo">341</span><a name="line.341"></a>
+<span class="sourceLineNo">342</span> ProcedureSyncWait.waitMetaRegions(env);<a name="line.342"></a>
+<span class="sourceLineNo">343</span><a name="line.343"></a>
+<span class="sourceLineNo">344</span> // Add replicas if needed<a name="line.344"></a>
+<span class="sourceLineNo">345</span> // we need to create regions with replicaIds starting from 1<a name="line.345"></a>
+<span class="sourceLineNo">346</span> List<RegionInfo> newRegions = RegionReplicaUtil.addReplicas(tableDescriptor, regions, 1,<a name="line.346"></a>
+<span class="sourceLineNo">347</span> tableDescriptor.getRegionReplication());<a name="line.347"></a>
<span class="sourceLineNo">348</span><a name="line.348"></a>
-<span class="sourceLineNo">349</span> // Setup replication for region replicas if needed<a name="line.349"></a>
-<span class="sourceLineNo">350</span> if (tableDescriptor.getRegionReplication() > 1) {<a name="line.350"></a>
-<span class="sourceLineNo">351</span> ServerRegionReplicaUtil.setupRegionReplicaReplication(env.getMasterConfiguration());<a name="line.351"></a>
-<span class="sourceLineNo">352</span> }<a name="line.352"></a>
-<span class="sourceLineNo">353</span> return newRegions;<a name="line.353"></a>
-<span class="sourceLineNo">354</span> }<a name="line.354"></a>
-<span class="sourceLineNo">355</span><a name="line.355"></a>
-<span class="sourceLineNo">356</span> protected static void setEnablingState(final MasterProcedureEnv env, final TableName tableName)<a name="line.356"></a>
-<span class="sourceLineNo">357</span> throws IOException {<a name="line.357"></a>
-<span class="sourceLineNo">358</span> // Mark the table as Enabling<a name="line.358"></a>
-<span class="sourceLineNo">359</span> env.getMasterServices().getTableStateManager()<a name="line.359"></a>
-<span class="sourceLineNo">360</span> .setTableState(tableName, TableState.State.ENABLING);<a name="line.360"></a>
-<span class="sourceLineNo">361</span> }<a name="line.361"></a>
-<span class="sourceLineNo">362</span><a name="line.362"></a>
-<span class="sourceLineNo">363</span> protected static void setEnabledState(final MasterProcedureEnv env, final TableName tableName)<a name="line.363"></a>
-<span class="sourceLineNo">364</span> throws IOException {<a name="line.364"></a>
-<span class="sourceLineNo">365</span> // Enable table<a name="line.365"></a>
-<span class="sourceLineNo">366</span> env.getMasterServices().getTableStateManager()<a name="line.366"></a>
-<span class="sourceLineNo">367</span> .setTableState(tableName, TableState.State.ENABLED);<a name="line.367"></a>
-<span class="sourceLineNo">368</span> }<a name="line.368"></a>
-<span class="sourceLineNo">369</span><a name="line.369"></a>
-<span class="sourceLineNo">370</span> /**<a name="line.370"></a>
-<span class="sourceLineNo">371</span> * Add the specified set of regions to the hbase:meta table.<a name="line.371"></a>
-<span class="sourceLineNo">372</span> */<a name="line.372"></a>
-<span class="sourceLineNo">373</span> private static void addRegionsToMeta(final MasterProcedureEnv env,<a name="line.373"></a>
-<span class="sourceLineNo">374</span> final TableDescriptor tableDescriptor,<a name="line.374"></a>
-<span class="sourceLineNo">375</span> final List<RegionInfo> regionInfos) throws IOException {<a name="line.375"></a>
-<span class="sourceLineNo">376</span> MetaTableAccessor.addRegionsToMeta(env.getMasterServices().getConnection(),<a name="line.376"></a>
-<span class="sourceLineNo">377</span> regionInfos, tableDescriptor.getRegionReplication());<a name="line.377"></a>
-<span class="sourceLineNo">378</span> }<a name="line.378"></a>
-<span class="sourceLineNo">379</span><a name="line.379"></a>
-<span class="sourceLineNo">380</span> protected static void updateTableDescCache(final MasterProcedureEnv env,<a name="line.380"></a>
-<span class="sourceLineNo">381</span> final TableName tableName) throws IOException {<a name="line.381"></a>
-<span class="sourceLineNo">382</span> env.getMasterServices().getTableDescriptors().get(tableName);<a name="line.382"></a>
-<span class="sourceLineNo">383</span> }<a name="line.383"></a>
-<span class="sourceLineNo">384</span><a name="line.384"></a>
-<span class="sourceLineNo">385</span> @Override<a name="line.385"></a>
-<span class="sourceLineNo">386</span> protected boolean shouldWaitClientAck(MasterProcedureEnv env) {<a name="line.386"></a>
-<span class="sourceLineNo">387</span> // system tables are created on bootstrap internally by the system<a name="line.387"></a>
-<span class="sourceLineNo">388</span> // the client does not know about this procedures.<a name="line.388"></a>
-<span class="sourceLineNo">389</span> return !getTableName().isSystemTable();<a name="line.389"></a>
-<span class="sourceLineNo">390</span> }<a name="line.390"></a>
-<span class="sourceLineNo">391</span>}<a name="line.391"></a>
+<span class="sourceLineNo">349</span> // Add regions to META<a name="line.349"></a>
+<span class="sourceLineNo">350</span> addRegionsToMeta(env, tableDescriptor, newRegions);<a name="line.350"></a>
+<span class="sourceLineNo">351</span><a name="line.351"></a>
+<span class="sourceLineNo">352</span> // Setup replication for region replicas if needed<a name="line.352"></a>
+<span class="sourceLineNo">353</span> if (tableDescriptor.getRegionReplication() > 1) {<a name="line.353"></a>
+<span class="sourceLineNo">354</span> ServerRegionReplicaUtil.setupRegionReplicaReplication(env.getMasterConfiguration());<a name="line.354"></a>
+<span class="sourceLineNo">355</span> }<a name="line.355"></a>
+<span class="sourceLineNo">356</span> return newRegions;<a name="line.356"></a>
+<span class="sourceLineNo">357</span> }<a name="line.357"></a>
+<span class="sourceLineNo">358</span><a name="line.358"></a>
+<span class="sourceLineNo">359</span> protected static void setEnablingState(final MasterProcedureEnv env, final TableName tableName)<a name="line.359"></a>
+<span class="sourceLineNo">360</span> throws IOException {<a name="line.360"></a>
+<span class="sourceLineNo">361</span> // Mark the table as Enabling<a name="line.361"></a>
+<span class="sourceLineNo">362</span> env.getMasterServices().getTableStateManager()<a name="line.362"></a>
+<span class="sourceLineNo">363</span> .setTableState(tableName, TableState.State.ENABLING);<a name="line.363"></a>
+<span class="sourceLineNo">364</span> }<a name="line.364"></a>
+<span class="sourceLineNo">365</span><a name="line.365"></a>
+<span class="sourceLineNo">366</span> protected static void setEnabledState(final MasterProcedureEnv env, final TableName tableName)<a name="line.366"></a>
+<span class="sourceLineNo">367</span> throws IOException {<a name="line.367"></a>
+<span class="sourceLineNo">368</span> // Enable table<a name="line.368"></a>
+<span class="sourceLineNo">369</span> env.getMasterServices().getTableStateManager()<a name="line.369"></a>
+<span class="sourceLineNo">370</span> .setTableState(tableName, TableState.State.ENABLED);<a name="line.370"></a>
+<span class="sourceLineNo">371</span> }<a name="line.371"></a>
+<span class="sourceLineNo">372</span><a name="line.372"></a>
+<span class="sourceLineNo">373</span> /**<a name="line.373"></a>
+<span class="sourceLineNo">374</span> * Add the specified set of regions to the hbase:meta table.<a name="line.374"></a>
+<span class="sourceLineNo">375</span> */<a name="line.375"></a>
+<span class="sourceLineNo">376</span> private static void addRegionsToMeta(final MasterProcedureEnv env,<a name="line.376"></a>
+<span class="sourceLineNo">377</span> final TableDescriptor tableDescriptor,<a name="line.377"></a>
+<span class="sourceLineNo">378</span> final List<RegionInfo> regionInfos) throws IOException {<a name="line.378"></a>
+<span class="sourceLineNo">379</span> MetaTableAccessor.addRegionsToMeta(env.getMasterServices().getConnection(),<a name="line.379"></a>
+<span class="sourceLineNo">380</span> regionInfos, tableDescriptor.getRegionReplication());<a name="line.380"></a>
+<span class="sourceLineNo">381</span> }<a name="line.381"></a>
+<span class="sourceLineNo">382</span><a name="line.382"></a>
+<span class="sourceLineNo">383</span> protected static void updateTableDescCache(final MasterProcedureEnv env,<a name="line.383"></a>
+<span class="sourceLineNo">384</span> final TableName tableName) throws IOException {<a name="line.384"></a>
+<span class="sourceLineNo">385</span> env.getMasterServices().getTableDescriptors().get(tableName);<a name="line.385"></a>
+<span class="sourceLineNo">386</span> }<a name="line.386"></a>
+<span class="sourceLineNo">387</span><a name="line.387"></a>
+<span class="sourceLineNo">388</span> @Override<a name="line.388"></a>
+<span class="sourceLineNo">389</span> protected boolean shouldWaitClientAck(MasterProcedureEnv env) {<a name="line.389"></a>
+<span class="sourceLineNo">390</span> // system tables are created on bootstrap internally by the system<a name="line.390"></a>
+<span class="sourceLineNo">391</span> // the client does not know about this procedures.<a name="line.391"></a>
+<span class="sourceLineNo">392</span> return !getTableName().isSystemTable();<a name="line.392"></a>
+<span class="sourceLineNo">393</span> }<a name="line.393"></a>
+<span class="sourceLineNo">394</span><a name="line.394"></a>
+<span class="sourceLineNo">395</span> @VisibleForTesting<a name="line.395"></a>
+<span class="sourceLineNo">396</span> RegionInfo getFirstRegionInfo() {<a name="line.396"></a>
+<span class="sourceLineNo">397</span> if (newRegions == null || newRegions.isEmpty()) {<a name="line.397"></a>
+<span class="sourceLineNo">398</span> return null;<a name="line.398"></a>
+<span class="sourceLineNo">399</span> }<a name="line.399"></a>
+<span class="sourceLineNo">400</span> return newRegions.get(0);<a name="line.400"></a>
+<span class="sourceLineNo">401</span> }<a name="line.401"></a>
+<span class="sourceLineNo">402</span>}<a name="line.402"></a>