You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by gyfora <gi...@git.apache.org> on 2015/09/14 13:26:49 UTC
[GitHub] flink pull request: [FLINK-2664] [streaming] Allow partitioned sta...
GitHub user gyfora opened a pull request:
https://github.com/apache/flink/pull/1126
[FLINK-2664] [streaming] Allow partitioned state removal
This PR changes the way Partitioned states handle null values.
Before this PR the user was not allowed to put null values in a partitioned state and an exception was thrown. This did not allow the user to remove the state for the current key (so the default value will be retreived next time).
Now whenever a user updates a partitioned state with a null value, the system will remove the state for the respective key from that map containing all the <key,state> pairs allowing for the garbage collection of unwanted user state.
The StatefulOperatorTest has also been modified to test for the changed behavior.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gyfora/flink 2664
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1126
----
commit dd40ea508f78c0487e003de2c2cf13cb12681db9
Author: Gyula Fora <gy...@apache.org>
Date: 2015-09-14T09:13:29Z
[FLINK-2664] [streaming] Allow partitioned state removal
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2664] [streaming] Allow partitioned sta...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/1126#discussion_r39383921
--- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/EagerStateStore.java ---
@@ -43,7 +44,7 @@ public EagerStateStore(StateCheckpointer<S, C> checkpointer, StateHandleProvider
}
@Override
- public S getStateForKey(Serializable key) throws Exception {
+ public S getStateForKey(Serializable key) throws IOException {
--- End diff --
While this is currently not used, once we implement things like out-of-core state access or lazy state access this will probably become necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2664] [streaming] Allow partitioned sta...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1126#discussion_r39383837
--- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/EagerStateStore.java ---
@@ -43,7 +44,7 @@ public EagerStateStore(StateCheckpointer<S, C> checkpointer, StateHandleProvider
}
@Override
- public S getStateForKey(Serializable key) throws Exception {
+ public S getStateForKey(Serializable key) throws IOException {
--- End diff --
Why do you specify the exception as IO here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2664] [streaming] Allow partitioned sta...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1126#issuecomment-140071198
If no objections, I would like to merge this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2664] [streaming] Allow partitioned sta...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1126#issuecomment-140045524
Apart from that one comment looks good to me, handy feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2664] [streaming] Allow partitioned sta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---